brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.57k stars 2.28k forks source link

Update Cards widget styling on the NTP #38752

Closed rebron closed 3 months ago

rebron commented 3 months ago

Description

We updated the design of several elements in the NTP to match the ghost effect design of Brave News and the Search Widget. Here's a detail of the changes for the cards and Rewards card widget:

https://www.figma.com/file/QCBklDojDtDTKApz10XqSQ/%F0%9F%97%82-New-Tab-Page?type=design&node-id=1%3A648&mode=design&t=MkeWs0VdCwTbTGPd-1

Steps to reproduce

n/a

Actual result

Screenshot 2024-05-31 at 3 50 49 PM

Expected result

Screenshot 2024-06-25 at 9 52 05 AM

See Figma. For assets and remaining details.

Widget cards

Rewards widget card

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.x

Channel information

Reproducibility

Miscellaneous information

Related issues: https://github.com/brave/brave-browser/issues/37213 https://github.com/brave/brave-browser/issues/38183

Miyayes commented 3 months ago

Noting that the Figma needs to be updated, since the contents of the rewards widget are now different.

Current design and contents in 1.66.x, for example. image

kjozwiak commented 2 months ago

Removing the feature/web3/wallet as the above looks like a Rewards UI/UX fix/improvement. Seems like the brave-builds bot labelled the above incorrectly. @rebron please correct me if we should re-add the wallet label.

aguscruiz commented 2 months ago

Looks ok based on the screenshots in this issue https://github.com/brave/brave-core/pull/24211

We'll be updating the design to the whole card later on, but this is the expected result at this moment

kjozwiak commented 2 months ago

The above requires 1.68.103 or higher for 1.68.x verification 👍

LaurenWags commented 2 months ago

Verified with

Brave | 1.68.105 Chromium: 126.0.6478.126 (Official Build) beta (x86_64)
-- | --
Revision | 0f19763468e437ae45d4603935bce4bb0a941333
OS | macOS Version 13.6.7 (Build 22G720)
Talk - PASSED - Confirmed the Talk widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 - Confirmed no "Edit Cards" option displayed below the cards - Confirmed each option from the 3 dots menu on the Rewards card worked as expected: - Hide Talk --> hid the Talk card from NTP - Confirmed card selection is "sticky" (Talk card is "on top") on new tabs if it was selected. It remains "on top" on subsequent relaunches of the browser unless Rewards card is selected. 1.67.x | 1.68.x --- | --- Screenshot 2024-06-25 at 3 34 47 PM | Screenshot 2024-07-01 at 9 54 52 AM Screenshot 2024-06-25 at 3 35 38 PM | Screenshot 2024-07-01 at 9 55 01 AM - Confirmed clicking on the "Start call" button on the card opened a new Brave Talk meeting in the tab - Confirmed clicking on "About your data" opened `https://brave.com/privacy/browser/#brave-talk-learn` in a new tab Example | Example --- | --- Screenshot 2024-07-01 at 9 56 32 AM | Screenshot 2024-07-01 at 9 56 56 AM - Confirmed able to hide Talk card via 3 dots menu - Confirmed able to unhide Talk card via "Cards" under "Customize Dashboard" - Confirmed able to hide Talk card via "Cards" under "Customize Dashboard" Example | Example --- | --- Screenshot 2024-07-01 at 9 57 58 AM | Screenshot 2024-07-01 at 9 58 07 AM
Rewards - Overall PASSED, see individual cases for additional notes and follow ups
Not opted into Rewards - PASSED - Confirmed on a new profile when not opted into Rewards, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 - Confirmed no "Edit Cards" option displayed below the cards - Confirmed each option from the 3 dots menu on the Rewards card worked as expected: - Open Rewards Panel --> opened panel in URL bar - Rewards settings --> opened brave://rewards - Learn more --> opened `https://brave.com/brave-rewards/` in a new tab - Hide Brave Rewards --> hid the Rewards card from NTP - Confirmed card selection is "sticky" (Rewards card is "on top" by default) on new tabs if it was selected. It remains "on top" on subsequent relaunches of the browser unless Talk card is selected. 1.67.x | 1.68.x --- | --- Screenshot 2024-06-25 at 3 27 39 PM | Screenshot 2024-07-01 at 11 06 20 AM Screenshot 2024-06-25 at 3 27 46 PM | Screenshot 2024-07-01 at 11 06 27 AM - Confirmed clicking on the "Learn more" button on the card opened the panel: Screenshot 2024-07-01 at 11 23 42 AM - Confirmed able to hide Rewards card via 3 dots menu - Confirmed able to unhide Rewards card via "Cards" under "Customize Dashboard" - Confirmed able to hide Rewards card via "Cards" under "Customize Dashboard" Example | Example --- | --- Screenshot 2024-07-01 at 11 24 08 AM | Screenshot 2024-07-01 at 11 24 16 AM
Opted into Rewards - Unconnected state - PASSED - Confirmed on a new profile when opted into Rewards, but no custodian connected, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 1.67.x | 1.68.x --- | --- Screenshot 2024-06-25 at 3 52 18 PM | Screenshot 2024-07-01 at 11 43 25 AM Screenshot 2024-06-25 at 3 53 56 PM | Screenshot 2024-07-01 at 11 43 31 AM - Confirmed visiting verified creators increases the count on the Rewards card as expected: Example | Example --- | --- Screenshot 2024-07-01 at 11 45 14 AM | Screenshot 2024-07-01 at 11 46 42 AM - Confirmed clicking on the "Connect account" button on the card opened brave://rewards/#verify in a new tab: Screenshot 2024-07-01 at 11 47 52 AM
Opted into Rewards - Connected state - PASSED - Confirmed on a new profile when opted into Rewards with a custodian connected, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 1.67.x | 1.68.x --- | --- Screenshot 2024-06-25 at 4 14 21 PM | Screenshot 2024-07-01 at 2 06 23 PM Screenshot 2024-06-25 at 4 14 34 PM | Screenshot 2024-07-01 at 2 06 29 PM - Confirmed the balances displayed as expected on the widget (balances on widget matched panel and brave://rewards page) - Confirmed tooltip text on the widget - Confirmed clicking on "Manage ads" on widget tooltip opened brave://rewards page Example | Example | Example | Example --- | --- | --- | --- Screenshot 2024-07-01 at 2 06 23 PM | Screenshot 2024-07-01 at 2 09 08 PM | Screenshot 2024-07-01 at 2 09 20 PM | Screenshot 2024-07-01 at 2 09 32 PM - Confirmed the various payout banners (pending, processing, completed, none) displayed on the widget as expected - For the "Processing" status banner, confirmed "Check status" link directs to `https://brave.com/payout-status` which redirects to community specific page regarding payout status for the particular payout - For the "Complete" status banner, confirmed "Support" link directs to `https://community.brave.com/` Pending | Processing | Complete | None --- | --- | --- | --- Screenshot 2024-08-03 at 2 32 54 PM | Screenshot 2024-08-09 at 2 34 19 PM | Screenshot 2024-08-09 at 2 34 56 PM | Screenshot 2024-08-09 at 2 37 33 PM Note, here's the display of these banners in 1.67.x for comparison
Pending | Processing | Complete | None --- | --- | --- | --- 67 pend | 67 prog | 67 comp | 67 off
Below are some pointers on getting these banners to display if you're not familiar with them:
Pre-reqs for all banners: - Be connected to a custodian, then proceed to below - Have ad tokens "cashed in"/redeemed with the server for the current month (in this case, June) For "Pending": - Before launching browser to check, advance computer clock date to between 1st and 7th of next month (in this case, July) - Also have a Charles Proxy rule configured so that the `parameters` endpoint doesn't return a status for the custodian or returns "off". See what is returned for `Uphold` in below response as examples: - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"off","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}` - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}` For "Processing": - Before launching browser to check, advance computer clock date to between 7th and end of next month (in this case, July) - Also have a Charles Proxy rule configured so that the `parameters` endpoint returns "processing". See what is returned for `Uphold` in below response as an example: - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"processing","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}` For "Complete": - Before launching browser to check, advance computer clock date to between 7th and end of next month (in this case, July) - Also have a Charles Proxy rule configured so that the `parameters` endpoint returns "complete". See what is returned for `Uphold` in below response as an example: - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"complete","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}` For "Off": - Before launching browser to check, advance computer clock date to between 7th and end of next month (in this case, July) - Also have a Charles Proxy rule configured so that the `parameters` endpoint returns "off". See what is returned for `Uphold` in below response as an example: - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"off","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}`
Opted into Rewards - Disconnected state - PASSED - Compared disconnected state in 1.68.x to 1.67.x - Confirmed widget prompted to re-connect to custodian - Confirmed clicking on the prompt navigated me to custodian site for re-authorization 1.67.x | 1.68.x --- | --- Screenshot 2024-06-26 at 9 28 30 AM | Screenshot 2024-07-01 at 3 06 09 PM
Opted into Rewards - Custodian spot check - 4 PASSED, 1 SKIPPED - Confirmed each custodial option displayed balance on the widget as expected Uphold | Gemini | ZebPay | bitFlyer | Self-Custody --- | --- | --- | --- | --- Screenshot 2024-07-01 at 3 09 10 PM | Screenshot 2024-07-01 at 3 13 58 PM | skipped, site issue | Screenshot 2024-07-01 at 3 44 37 PM | Screenshot 2024-07-01 at 4 00 29 PM
Terms of Service notification on widget - PASSED with follow up issue - Confirmed "Terms of Service update" notification displayed on widget as expected for unconnected, connected, and disconnected rewards custodial states - Encountered https://github.com/brave/brave-browser/issues/39386. Unconnected | Connected | Disconnected --- | --- | --- uncon | con | discon
Self Custody notification on widget - PASSED with follow up issue - Confirmed "Self Custody" notification displayed on widget as expected - Confirmed "Connect account" button directs user to brave://rewards/#verify - Confirmed "Not now" closes the notification - Encountered https://github.com/brave/brave-browser/issues/39393 1.67.x | 1.68.x --- | --- Screenshot 2024-06-26 at 11 22 14 AM | Screenshot 2024-07-02 at 10 14 49 AM
LaurenWags commented 2 months ago

Verified with

Brave   1.68.106 Chromium: 126.0.6478.126 (Official Build) beta (64-bit) 
Revision    8d682ca0cb836cac019e09be7744d3852e68953e
OS  Linux

Encountered and logged https://github.com/brave/brave-browser/issues/39532.

Talk - PASSED with follow up issue - Confirmed the Talk widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 - Confirmed no "Edit Cards" option displayed below the cards - Confirmed each option from the 3 dots menu on the Rewards card worked as expected: - Hide Talk --> hid the Talk card from NTP - Confirmed card selection is "sticky" (Talk card is "on top") on new tabs if it was selected. It remains "on top" on subsequent relaunches of the browser unless Rewards card is selected. - Encountered and logged https://github.com/brave/brave-browser/issues/39532 1.67.x | 1.68.x --- | --- Screenshot 2024-07-02 at 12 28 46 PM | Screenshot 2024-07-02 at 12 28 57 PM Screenshot 2024-07-02 at 1 41 17 PM | Screenshot 2024-07-02 at 1 41 09 PM - Confirmed clicking on the "Start call" button on the card opened a new Brave Talk meeting in the tab - Confirmed clicking on "About your data" opened `https://brave.com/privacy/browser/#brave-talk-learn` in a new tab Example | Example --- | --- Screenshot 2024-07-02 at 1 41 45 PM | Screenshot 2024-07-02 at 1 42 02 PM - Confirmed able to hide Talk card via 3 dots menu - Confirmed able to unhide Talk card via "Cards" under "Customize Dashboard" - Confirmed able to hide Talk card via "Cards" under "Customize Dashboard" Example | Example --- | --- Screenshot 2024-07-02 at 1 42 42 PM | Screenshot 2024-07-02 at 1 42 53 PM
Rewards - Overall PASSED, see follow up issues referenced below - Encountered https://github.com/brave/brave-browser/issues/39532 - Encountered https://github.com/brave/brave-browser/issues/39393
Not opted into Rewards - PASSED - Confirmed on a new profile when not opted into Rewards, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 - Confirmed no "Edit Cards" option displayed below the cards - Confirmed each option from the 3 dots menu on the Rewards card worked as expected: - Open Rewards Panel --> opened panel in URL bar - Rewards settings --> opened brave://rewards - Learn more --> opened `https://brave.com/brave-rewards/` in a new tab - Hide Brave Rewards --> hid the Rewards card from NTP - Confirmed card selection is "sticky" (Rewards card is "on top" by default) on new tabs if it was selected. It remains "on top" on subsequent relaunches of the browser unless Talk card is selected. 1.67.x | 1.68.x --- | --- Screenshot 2024-07-02 at 3 02 52 PM | Screenshot 2024-07-02 at 3 03 00 PM Screenshot 2024-07-02 at 3 03 09 PM | Screenshot 2024-07-02 at 3 03 16 PM - Confirmed clicking on the "Learn more" button on the card opened the panel: Screenshot 2024-07-02 at 3 06 54 PM - Confirmed able to hide Rewards card via 3 dots menu - Confirmed able to unhide Rewards card via "Cards" under "Customize Dashboard" - Confirmed able to hide Rewards card via "Cards" under "Customize Dashboard" Example | Example --- | --- Screenshot 2024-07-02 at 3 12 09 PM | Screenshot 2024-07-02 at 3 12 16 PM
Opted into Rewards - Unconnected state - PASSED - Confirmed on a new profile when opted into Rewards, but no custodian connected, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 1.67.x | 1.68.x --- | --- Screenshot 2024-07-02 at 3 16 17 PM | Screenshot 2024-07-02 at 3 16 22 PM Screenshot 2024-07-02 at 3 16 31 PM | Screenshot 2024-07-02 at 3 16 40 PM - Confirmed visiting verified creators increases the count on the Rewards card as expected: Example | Example --- | --- Screenshot 2024-07-02 at 3 18 13 PM | Screenshot 2024-07-02 at 3 19 43 PM - Confirmed clicking on the "Connect account" button on the card opened brave://rewards/#verify in a new tab: Screenshot 2024-07-02 at 3 25 44 PM
Opted into Rewards - Connected state - PASSED - Confirmed on a new profile when opted into Rewards with a custodian connected, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 1.67.x | 1.68.x --- | --- Screenshot 2024-07-02 at 4 15 50 PM | Screenshot 2024-07-02 at 4 15 55 PM Screenshot 2024-07-02 at 4 16 02 PM | Screenshot 2024-07-02 at 4 16 08 PM - Confirmed the balances displayed as expected on the widget (balances on widget matched panel and brave://rewards page) - Confirmed tooltip text on the widget - Confirmed clicking on "Manage ads" on widget tooltip opened brave://rewards page Example | Example | Example | Example --- | --- | --- | --- Screenshot 2024-07-03 at 12 41 02 PM | Screenshot 2024-07-03 at 12 41 09 PM | Screenshot 2024-07-03 at 12 41 21 PM | Screenshot 2024-07-03 at 12 41 29 PM - Confirmed an ads payout banner (one of the following: pending, processing, or completed) displayed on the widget as expected (Processing in this case) 1.67.x | 1.68.x --- | --- Screenshot 2024-07-03 at 1 17 17 PM | Screenshot 2024-07-03 at 1 32 46 PM Below are some pointers on getting these banners to display if you're not familiar with them:
Pre-reqs for all banners: - Be connected to a custodian, then proceed to below - Have ad tokens "cashed in"/redeemed with the server for the current month (in this case, June) For "Pending": - Before launching browser to check, advance computer clock date to between 1st and 7th of next month (in this case, July) - Also have a Charles Proxy rule configured so that the `parameters` endpoint doesn't return a status for the custodian or returns "off". See what is returned for `Uphold` in below response as examples: - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"off","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}` - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}` For "Processing": - Before launching browser to check, advance computer clock date to between 7th and end of next month (in this case, July) - Also have a Charles Proxy rule configured so that the `parameters` endpoint returns "processing". See what is returned for `Uphold` in below response as an example: - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"processing","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}` For "Complete": - Before launching browser to check, advance computer clock date to between 7th and end of next month (in this case, July) - Also have a Charles Proxy rule configured so that the `parameters` endpoint returns "complete". See what is returned for `Uphold` in below response as an example: - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"complete","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}` For "Off": - Before launching browser to check, advance computer clock date to between 7th and end of next month (in this case, July) - Also have a Charles Proxy rule configured so that the `parameters` endpoint returns "off". See what is returned for `Uphold` in below response as an example: - `{"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.196277,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"off","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true}`
Opted into Rewards - Disconnected state - PASSED - Compared disconnected state in 1.68.x to 1.67.x - Confirmed widget prompted to re-connect to custodian - Confirmed clicking on the prompt navigated me to custodian site for re-authorization 1.67.x | 1.68.x --- | --- Screenshot 2024-07-03 at 1 36 24 PM | Screenshot 2024-07-03 at 1 36 31 PM
Opted into Rewards - Custodian spot check - PASSED - In addition to Uphold (used for above checks), confirmed one other custodial option displayed balance on the widget as expected: Self Custody | brave://rewards --- | --- Screenshot 2024-07-03 at 3 06 33 PM | Screenshot 2024-07-03 at 3 06 47 PM
Self Custody notification on widget - PASSED with follow up - Confirmed "Self Custody" notification displayed on widget as expected - Confirmed "Connect account" button directs user to brave://rewards/#verify - Confirmed "Not now" closes the notification - Encountered https://github.com/brave/brave-browser/issues/39393 1.67.x | 1.68.x --- | --- Screenshot 2024-07-03 at 3 02 08 PM | Screenshot 2024-07-03 at 3 02 13 PM
MadhaviSeelam commented 2 months ago

Verification PASSED using

Brave | 1.68.106 Chromium: 126.0.6478.126 (Official Build) beta (64-bit)
-- | --
Revision | 8d682ca0cb836cac019e09be7744d3852e68953e
OS | Windows 11 Version 23H2 (Build 22631.3810)
Talk - PASSED - Confirmed the Talk widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 - Confirmed no "Edit Cards" option displayed below the cards - Confirmed option from the 3 dots menu on the Talk card worked as expected: - Hide Talk --> hid the Talk card from NTP - Confirmed card selection is "sticky" (Talk card is "on top") on new tabs if it was selected. It remains "on top" on subsequent relaunches of the browser unless Rewards card is selected. 1.67.x | 1.68.x --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/644b5c12-23a6-4ec6-99c9-bca13a1279fa)|![image](https://github.com/brave/brave-browser/assets/98358127/3182d2cd-1a4f-4629-b2a6-fe519f51d62c) ![image](https://github.com/brave/brave-browser/assets/98358127/0fe7edb4-a50d-46f8-a728-ec2bee1fcc91)|![image](https://github.com/brave/brave-browser/assets/98358127/4c8e3a40-4b4a-44c9-9718-c8fdaf2797bb) **_Hide talk cards via NTP cards_** - Confirmed able to hide talk card via 3 dots menu 1.67.x | 1.68.x --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/3e012577-e6ab-457c-aa0f-700e9976ee37)|![image](https://github.com/brave/brave-browser/assets/98358127/a77f8b0f-1c4d-4f9a-aad3-789a1a4bdb87) ![image](https://github.com/brave/brave-browser/assets/98358127/3e145be5-d5fa-4079-8ad2-1a363ab1e06e)|![image](https://github.com/brave/brave-browser/assets/98358127/036615a3-0b37-4beb-b5c3-3df633d2de9c) **_Hide and Unhide Talk card via Cards in the Customize Dashboard_** 1. continued from above case `**_Hide talk cards via NTP cards_**` 2. clicked `Add` button in the Dashboard 3. clicked `Hide` button - Confirmed able to unhide Talk card via "Cards" under "Customize Dashboard" - Confirmed able to hide Talk card via "Cards" under "Customize Dashboard" example | example | example ----- | ------ | ------ ![image](https://github.com/brave/brave-browser/assets/98358127/bcad0b77-f64e-4854-a236-79afdeb02e7f)|![image](https://github.com/brave/brave-browser/assets/98358127/98bf61db-a9cc-4938-b39a-ee0523a4de36)|![image](https://github.com/brave/brave-browser/assets/98358127/cc2b11ce-2e77-49d3-bd88-1e9ae6d0fcca) **_About your data_** & **_Start call_** - Confirmed clicking on the "Start call" button on the card opened a new Brave Talk meeting in the tab - Confirmed clicking on "About your data" opened https://brave.com/privacy/browser/#brave-talk-learn in a new tab example | example ----- | ---- ![image](https://github.com/brave/brave-browser/assets/98358127/5e514d7c-d5b5-47de-afbe-03ffdb03971d)|![image](https://github.com/brave/brave-browser/assets/98358127/e002a9d1-f741-4512-9400-4c3f3b440a6d) **_Hide clock & Hide Rewards_** example | example | example ----- | ---- | ----- ![image](https://github.com/brave/brave-browser/assets/98358127/e7daabd7-93e1-4b8b-a2e2-88f365d3af09)|![image](https://github.com/brave/brave-browser/assets/98358127/a4b686a4-d782-4d8b-b9ff-8cbf2d506f67)|![image](https://github.com/brave/brave-browser/assets/98358127/c32c9afa-a1fb-4f75-b669-57e5f4f9590a) **_Dark theme_** example | example | example | example ------ | ----- | ----- | ----- ![image](https://github.com/brave/brave-browser/assets/98358127/6cb6a56e-e8c7-4646-9163-87efe4337ca1)|![image](https://github.com/brave/brave-browser/assets/98358127/ccb417d1-5c9d-4730-a461-d48ca071b0fa)|![image](https://github.com/brave/brave-browser/assets/98358127/af3269cb-6049-4551-af24-c663fd82a286)|![image](https://github.com/brave/brave-browser/assets/98358127/a2538d1b-fabb-4648-8397-245e63216eda)
Rewards - PASSED
Not opted into Rewards - PASSED - Confirmed on a new profile when not opted into Rewards, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 - Confirmed no "Edit Cards" option displayed below the cards - Confirmed each option from the 3 dots menu on the Rewards card worked as expected: - Open Rewards Panel --> opened panel in URL bar - Rewards settings --> opened brave://rewards - Learn more --> opened `https://brave.com/brave-rewards/` in a new tab - Hide Brave Rewards --> hid the Rewards card from NTP - Confirmed card selection is "sticky" (Rewards card is "on top" by default) on new tabs if it was selected. It remains "on top" on subsequent relaunches of the browser unless Talk card is selected. 1.67.x | 1.68.x --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/ff980157-a1c8-42fb-944e-3e34e4c2f806)|![image](https://github.com/brave/brave-browser/assets/98358127/310f0df2-c21b-4405-9090-1cb5d542b6ad) ![image](https://github.com/brave/brave-browser/assets/98358127/89a12698-fd19-4822-8656-fd42892fdefd)|![image](https://github.com/brave/brave-browser/assets/98358127/5df68f62-48f1-459c-b365-609c0ce9bc5e) - Confirmed clicking on the "Learn more" button on the card opened the panel: ![image](https://github.com/brave/brave-browser/assets/98358127/d594521d-5a12-4680-99f6-b4f1e659b8e7) - Confirmed able to hide Rewards card via 3 dots menu - Confirmed able to unhide Rewards card via "Cards" under "Customize Dashboard" - Confirmed able to hide Rewards card via "Cards" under "Customize Dashboard" Example | Example | Example --- | --- | ----- ![image](https://github.com/brave/brave-browser/assets/98358127/3e86d330-5310-41cf-af7e-59b89f4f29bf)|![image](https://github.com/brave/brave-browser/assets/98358127/a0870e79-9361-4c67-a83a-15d0666ce464)|![image](https://github.com/brave/brave-browser/assets/98358127/d419564a-b7b5-4489-a8d0-480adf07ea9f)
Opted into Rewards - Unconnected state - PASSED - Confirmed on a new profile when opted into Rewards, but no custodian connected, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 1.67.x | 1.68.x --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/511494a3-6fab-4e82-842f-bcb7f5e98e01)|![image](https://github.com/brave/brave-browser/assets/98358127/472b4139-d1c7-4c27-a9bc-1bc51e75fd9a) - Confirmed visiting verified creators increases the count on the Rewards card as expected: 1.67.x | 1.68.x --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/71e23066-847f-44b8-b55a-8ab831d5227f)|![image](https://github.com/brave/brave-browser/assets/98358127/3f25a892-c053-4230-b63d-e6e5921df81a) - Confirmed clicking on the "Connect account" button on the card opened brave://rewards/#verify in a new tab: ![image](https://github.com/brave/brave-browser/assets/98358127/9925014b-0116-4a49-a019-ef3079a2f7d7) Dark theme example | example ----- | ----- ![image](https://github.com/brave/brave-browser/assets/98358127/fc216a54-b0bf-42e8-8513-806c13e7a66d)|![image](https://github.com/brave/brave-browser/assets/98358127/96b4caee-874b-4e45-bd96-670291d01bda)
Opted into Rewards - Connected state - PASSED - Confirmed on a new profile when opted into Rewards with a custodian connected, the Rewards widget matches screenshot from https://github.com/brave/brave-core/pull/24211#issue-2353694498 1.67.x | 1.68.x --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/d135bcfb-d1f4-43c5-8427-29d22eea9474)|![image](https://github.com/brave/brave-browser/assets/98358127/78197abf-8c03-436f-b0bc-7cfb11485249) ![image](https://github.com/brave/brave-browser/assets/98358127/026be55f-f9a5-4a82-9eab-ad9d73984a32)|![image](https://github.com/brave/brave-browser/assets/98358127/419eea98-8ac0-4071-9901-552e916331fd) - Confirmed the balances displayed as expected on the widget (balances on widget matched panel and brave://rewards page) - Confirmed tooltip text on the widget - Confirmed clicking on "Manage ads" on widget tooltip opened brave://rewards page rewards card| rewards panel | tooltip | brave://rewards --- | --- | --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/4f47d8de-a000-4c5a-bf1c-1a8c8f192a18)|![image](https://github.com/brave/brave-browser/assets/98358127/bd96240e-8b5e-45d1-9147-382c144b7752)|![image](https://github.com/brave/brave-browser/assets/98358127/7432b635-5091-4dee-be07-fd647782f333)|![image](https://github.com/brave/brave-browser/assets/98358127/6de68f6a-28a2-450e-8324-9a2f29c768c0) - Confirmed the various payout banners eg. processing displayed on the widget as expected - For the "Processing" status banner, confirmed "Check status" link directs to `https://brave.com/payout-status` which redirects to community specific page regarding payout status for the particular payout Processing | Check status --- | ------ ![image](https://github.com/brave/brave-browser/assets/98358127/972f93d9-7296-47ce-979a-d87526311a26)|![image](https://github.com/brave/brave-browser/assets/98358127/18e5812f-8e0b-4721-9636-8c0e31071375) - Confirmed an ads payout banner (one of the following: pending, processing, or completed) displayed on the widget as expected (Processing in this case) 1.67.x | 1.68.x --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/75cad7dc-e8ce-4ffd-812e-dc6293bcb839)|![image](https://github.com/brave/brave-browser/assets/98358127/fa8ea329-7868-4b06-9230-1b826fccaf3c)
Opted into Rewards - Disconnected state - PASSED - Compared disconnected state in 1.68.x to 1.67.x - Confirmed widget prompted to re-connect to custodian - Confirmed clicking on the prompt navigated me to custodian site for re-authorization 1.67.x | 1.68.x --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/b1947d24-d34c-40f0-96da-b6bc8f77b8be)|![image](https://github.com/brave/brave-browser/assets/98358127/ba2b424b-082a-479e-9dfe-27a3a5642928) ![image](https://github.com/brave/brave-browser/assets/98358127/63d10937-a869-4267-abb9-b0a8cf9b0bd8)|![image](https://github.com/brave/brave-browser/assets/98358127/a37a3a63-e643-498c-ac55-e149f7a2c39e)
Opted into Rewards - Custodian spot check - PASSED In addition to Uphold (used for above checks), confirmed one other custodial option (Gemini) displayed balance on the widget as expected: example | example | example --- | --- | ----- ![image](https://github.com/brave/brave-browser/assets/98358127/3cdcb484-b0f6-45c3-8dcc-fb85d5150a9d)|![image](https://github.com/brave/brave-browser/assets/98358127/e9ea07b6-28f1-452c-bb6c-1900957e82fe)|![image](https://github.com/brave/brave-browser/assets/98358127/19ee34c1-05b4-4e84-a18f-eeffbbeaa36a)
Terms of Service notification on widget - PASSED - Confirmed "Terms of Service update" notification displayed on widget as expected for unconnected, connected, and disconnected rewards custodial states - Encountered https://github.com/brave/brave-browser/issues/39386. Unconnected | Connected | Disconnected --- | --- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/85b7543e-2bcd-48fb-bc56-889c78087cf9)|![image](https://github.com/brave/brave-browser/assets/98358127/8846216f-6696-480d-bd48-fd079f4bfa10)|![image](https://github.com/brave/brave-browser/assets/98358127/b125a197-9639-4323-a06d-4d14962ca4ec)
Self Custody notification on widget - PASSED - Confirmed "Self Custody" notification displayed on widget as expected - Confirmed "Connect account" button directs user to brave://rewards/#verify - Confirmed "Not now" closes the notification - Encountered https://github.com/brave/brave-browser/issues/39393 1.67.x |1.68.x --- | ---- ![167](https://github.com/brave/brave-browser/assets/98358127/868090a6-ef0c-4f04-aee8-eb86463a4f09)|![168](https://github.com/brave/brave-browser/assets/98358127/57576f8e-81bb-48b4-bb45-31aa4e707d0f)