brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.98k stars 2.21k forks source link

Search engine favicon should be updated when a different search engine is selected via customize dashboard #38778

Open MadhaviSeelam opened 1 month ago

MadhaviSeelam commented 1 month ago

Description

Found while testing https://github.com/brave/brave-browser/issues/38675. When clicked Customize list via Search widget and changed NTP search engine in the Customize Dashboard, favicon of the search engine is not updated in the Search widget. However selected search engine is shown in the dropdown as expected. This is happening in in both Windows 11 (1.67.101) & Linux (1.67.104)

Steps to reproduce

  1. Installed 1.67.104
  2. launched Brave
  3. enabled Brave Search Widget on the NTP via brave://flags
  4. open a new tab and click on Brave icon in the search widget
  5. click Customize list
  6. unselect Brave and select Qwant
  7. close (x) the dashboard
  8. open a new tab and verify the favicon in the search widget

Actual result

Brave favicon is shown. Had to select the search engine to populate the widget.

2024-06-03_17h11_56

Expected result

Icon should be updated to Qwant logo

image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.67.104 Chromium: 126.0.6478.26 (Official Build) beta (64-bit) Revision 9a4d1cb2f47a60953416cd3f39f0520e4dd4cf0e OS Linux

Channel information

Reproducibility

Miscellaneous information

@rebron cc: @brave/qa-team

stephendonner commented 1 month ago

@MadhaviSeelam mind editing to include the brave://flags portion in the steps, for posterity? 🙇

from to
Screen Shot 2024-06-04 at 12 15 00 AM Screen Shot 2024-06-04 at 12 15 11 AM