Commands in omnibox only show if Brave Search is default - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.94k stars 2.35k forks source link

Commands in omnibox only show if Brave Search is default #38793

Open petemill opened 5 months ago

petemill commented 5 months ago

Description

If default search engine is google, commands don't show up

Steps to reproduce

Set Google as browser's default search engine
Open New Tab
Type "new tab"

Actual result

Suggested browser commands don't show

Expected result

Suggested browser commands show as follows:

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.64

Channel information

[ ] release (stable)
[ ] beta
[ ] nightly

Reproducibility

[ ] with Brave Shields disabled
[ ] with Brave Rewards disabled
[ ] in the latest version of Chrome

Miscellaneous information

"Commands in omnibox" flag should be enabled (which is the default)

petemill commented 5 months ago

Maybe it depends on how many search results come back from the provider, as @rebron reported it's not predictable even with Brave Search as default. Perhaps there's another way we can make it more predictable for the user?