brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.62k stars 2.29k forks source link

`chrome://` scheme should be replaced with `brave://` in the password manager #38836

Closed MadhaviSeelam closed 2 months ago

MadhaviSeelam commented 3 months ago

Description

After signing into a website and clicked Manage passwords page and saving the password, Install app is shown. When clicked to install, there were two instances chrome:// is shown chrome://password-manager and it should be replaced with Brave://. And Brave icon seem to be squished.

Steps to reproduce

  1. Install 1.66.118
  2. launch Brave
  3. login to a website (eg. nytimes.) and save password
  4. click key icon >>Manage passwords
  5. click install app >> install
  6. click hamburger menu
  7. verify App Info

Actual result

Two instances chrome://password-manager is shown in the Install app? dialog & App info menu Brave icon seems squished

example example
image image

Expected result

remove chrome:// instances`? resize Brave icon?

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.66.118 Chromium: 125.0.6422.147 (Official Build) (64-bit)
Revision 07af53490e0a52336cfb99a376f87671be258049
OS Windows 11 Version 23H2 (Build 22631.3672)

Channel information

Reproducibility

Miscellaneous information

@rebron cc: @qa

jagadeshjai commented 3 months ago

@rebron I would like to work on this, Could you please assign to me?

stephendonner commented 2 months ago

Verified PASSED using

Brave | 1.70.30 Chromium: 127.0.6533.73 (Official Build) nightly (x86_64)
-- | --
Revision | 252bfcfa10e3f2a7e92ee1be5b9e488ab43b7218
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.70.30
  2. launched Brave
  3. logged in to techcrunch.com
  4. opened brave://settings/passwords
  5. clicked on the computer icon to trigger Install password manager? dialog
  6. confirmed scheme is brave://password-manager
  7. clicked on Install
  8. after it installed a web-view of the password manager, I clicked on the "hamburger" menu
  9. confirmed non-stretched Brave logo

Confirmed brave://password-manager scheme

example example
Screen Shot 2024-07-31 at 10 10 11 AM Screen Shot 2024-07-31 at 10 10 51 AM