brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

White border appearing around drop down menus on Linux #39069

Closed Brave-Matt closed 1 week ago

Brave-Matt commented 3 months ago

Description

After the update to version 1.67.115 on Linux, there is a white border that appears around/behind browser drop down menus, such as the main menu or bookmark folders, etc.

image

Steps to reproduce

  1. Launch Brave while using Linux/Kubuntu/i3
  2. Click hamburger menu or bookmarks bar folder
  3. Resulting drop-down menu has a white border around the shadow gradient

Actual result

White border/background appears

Expected result

Should be no boarder/background behind drop down menus

Reproduces how often

Easily reproduced

Brave version (brave://version info)

v1.67.115

Channel information

Reproducibility

Miscellaneous information

Original user report: https://community.brave.com/t/white-border-around-dropdown-menus-navigation-menu/553579

suryaanshah commented 2 months ago

can confirm the same on v1.67.116 LinuxMint brave-menu-error

dmitrykvasnikov commented 2 months ago

The same on Arch / i3 (GTK themed) with v1.67.116 screenshot

pythys commented 2 months ago

I also confirm this bug. Arch linux on i3wm

2024-06-17_00-45

Utsunom1ya commented 2 months ago

2024-06-17_05-10 2024-06-17_05-17

Garuda/Archlinux with Hyprland. 6.9.4-zen1-1-zen kernel.

GoWeasel commented 2 months ago

I also confirm this bug. Arch linux on i3wm

rmdhnreza commented 2 months ago

Chrome issue 40937108

TL;DR: On X11, you need a compositor to draw shadows. xcompmgr should be enough.

brave-1 brave-2

harridu commented 2 months ago

Actually I don't think I need a compositor, losing control over the background of my desktop and introducing other weird side effects. What I do need is some checkbox in Brave to turn off a graphical gimmick I didn't ask for.

Please don't make the eye-candy mandatory. There is no such problem for Google Chrome, for example. Thank you

pythys commented 2 months ago

@harridu I think the problem actually originates in Chromium and not necessarily in Brave. It seems to be just more visible in Brave. When I open the menu in dark mode in Chromium I still see some "weird" white that is just more tiny. Take a look below, do you see the white corners? That's possibly the same shadow bug.

2024-06-17_15-06_1

inicula commented 2 months ago

Why wasn't this a problem before 1.67? Did this type of menu not have shadows or what?

harridu commented 2 months ago

You are right, I didn't notice the white corners. It is not as distracting as Brave's giant white frame. Maybe Brave could reduce the white frame?

I would prefer to skip all that eye-candy, but I understand that this would be an enhancement request to chromium.

pythys commented 2 months ago

@harridu Fixing the border might be fixing a mistake with another mistake. The root cause is shadow rendering and I would imagine that's what the brave team should attend to.

If you are annoyed from this bug (as I am) then downgrading is a simple quick solution. I downgraded to version 125.1.66.120 and as the screenshot below shows things are pretty peachy at the moment. 2024-06-17_17-08

Cthulu201 commented 2 months ago

I agree we shouldn't be required to have a compositor, but xcompmgr looks better than picom on my Arch/i3 setup. FWIW in the interim.

egbastos666 commented 2 months ago

I completely disagree that composite usage should be mandatory. That's a complete useless "eye-candy" feature that brings nothing to the end user rather than something "beautiful". There are a lot of linux users that really doesn't care about this kind of things, that uses i3wm, that uses fluxbox exactly because they are simple and use minimal resources and we don't want to run an additional component just to "looks pretty". I think that the best way to handle that is to include a flag on chromium that makes possible to disable composite usage run without any shadow or this kind of things

pythys commented 2 months ago

@egbastos666 I would suggest that introducing a compositor is a discussion in Chromium. Brave as a derivative product is different flavor of Chromium but it is Chromium.

I'm also not sure how "easy" would it be to override chromium in that regard, but I would imagine a much easier solution is to solve whatever needs solving in Chromium.

Cthulu201 commented 2 months ago

I'm seeing a black border in Brave now. Chromium doesn't seem to need a compositor on my Linux box: Version 126.0.6478.114 (Official Build) Arch Linux (64-bit)

martinkirk commented 2 months ago

Same problem here.

Linux: MX-23.3_x64 KDE Brave: Version 1.67.123 Chromium: 126.0.6478.126 (Official Build)

It only happens when compositor is disabled.

I've haven't noticed the same issue with any other apps, specifically, Chromium works just fine with the compositor disabled.

egbastos666 commented 2 months ago

In fact it needs but the side effect when you don't have composite enabled on your environment is just a small white corner:

[image: image.png]

On Thu, Jun 27, 2024 at 12:56 PM martinkirk @.***> wrote:

Same problem here.

Linux: MX-23.3_x64 KDE Brave: Version 1.67.123 Chromium: 126.0.6478.126 (Official Build)

It only happens when compositor is disabled.

I've haven't noticed the same issue with any other apps, specifically, Chromium works just fine with the compositor disabled.

— Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/39069#issuecomment-2195086489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT6FNZRCC3C5OJT3BUFBBUDZJQYZJAVCNFSM6AAAAABJK7SR4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGA4DMNBYHE . You are receiving this because you were mentioned.Message ID: @.***>

floscr commented 2 months ago

Same issue here when running without a compositor.

I agree that it shouldn't be necessary to run compositor for context menus though, as you might disable for the performance overhead.

harridu commented 2 months ago

Hi folks,

FYI, I have reported this as a chromium issue, see

https://issues.chromium.org/issues/347724917

If you've got an account, then please make yourself heard on this page (pro or cons).

Thank you Harri

rubens07 commented 2 months ago

Hello, I fixed this issue by going into the settings in brave://flags and setting the Preferred Ozone platform option to Wayland

swappy-20240710_082735

My system;

martinkirk commented 2 months ago

Hello, I fixed this issue by going into the settings in brave://flags and setting the Preferred Ozone platform option to Wayland

This made no difference on my setup, the problem still exists.

Linux: MX-23.3_x64 KDE Brave: Version 1.67.123 Chromium: 126.0.6478.126 (Official Build)

wknapik commented 1 month ago

Still an issue in 1.67.134, 1.69.118 and 1.70.7 on x11/i3, no compositor

screenshot ![image](https://github.com/user-attachments/assets/ec172d26-4d20-4af5-b271-194f6404bb94)
UltraDoge commented 1 month ago

they never fix that

fmarier commented 1 month ago

It seems like it's a larger issue that just Chromium. I get the same thing in Nautilus, the GNOME file manager, on i3 + xorg if I don't have xcompmgr running: Capture d’écran du 2024-07-29 16-34-50

fmarier commented 1 month ago

That said, some fixes are coming in Chromium 128.

Zutatensuppe commented 1 month ago

It seems like it's a larger issue that just Chromium. I get the same thing in Nautilus, the GNOME file manager, on i3 + xorg if I don't have xcompmgr running:

It does not affect nautilus for me, only brave.

tonysultana commented 1 month ago

I have the same problem on Debian Bookworm with Openbox and compton for the compositor.

Guillex387 commented 1 month ago

Description

After the update to version 1.67.115 on Linux, there is a white border that appears around/behind browser drop down menus, such as the main menu or bookmark folders, etc.

image

Steps to reproduce

  1. Launch Brave while using Linux/Kubuntu/i3
  2. Click hamburger menu or bookmarks bar folder
  3. Resulting drop-down menu has a white border around the shadow gradient

Actual result

White border/background appears

Expected result

Should be no boarder/background behind drop down menus

Reproduces how often

Easily reproduced

Brave version (brave://version info)

v1.67.115

Channel information

  • [x] release (stable)
  • [x] beta
  • [ ] nightly

Reproducibility

  • [ ] with Brave Shields disabled
  • [ ] with Brave Rewards disabled
  • [ ] in the latest version of Chrome

Miscellaneous information

Original user report: https://community.brave.com/t/white-border-around-dropdown-menus-navigation-menu/553579

I have the same problem in my Arch linux with Xorg and Qtile, but in the last update of nightly (1.70.62) I don't have the bug

benjamind10 commented 1 month ago

I have the exact same issue with Ubuntu 24.04 i3wm and can confirm this on two different devices.

jneidel commented 1 month ago

Can confirm that it's fixed in latest (nightly) as reported by @Guillex387

Arch + Xorg + i3 + compositor disabled

wknapik commented 1 month ago

Also fixed for me in 1.70.67 on arch/xorg/i3/no compositor

runlow commented 1 month ago

Installed the brave-nightly-bin AUR package on Archlinux (instead of brave-bin which I usually install). Had to use /bin/brave-nightly instead of /bin/brave, as well as ln -s Brave-Browser Brave-Browser-Nightly in ~/.config/BraveSoftware. Also disabled brave://flags/#brave-web-view-rounded-corners

So switched from brave-bin 1:1.68.137-1 to brave-nightly-bin 1.70.67-1.

This problem seems gone for me now. Menus work as expected, even without a compositor. Thank you.

benjamind10 commented 1 month ago

I can confirm also fixed on nightly version 1.70.66, I did not have to do any additional steps.

Snxrre commented 2 weeks ago

Fixed for me on version 1:1.69.160-1 (newest version of brave-bin in the AUR)

harridu commented 1 week ago

the new version is fine for me

rebron commented 1 week ago

Closing as fixed in 1.69.153 and higher. Our latest version is 1.69.162 released today.

kjozwiak commented 1 week ago

Closing the above as we've received several confirmations that the above has been resolved 👍

tonysultana commented 1 week ago

I am updated and still have the border issue.

Version 1.69.162 Chromium: 128.0.6613.120 (Official Build) (64-bit)

[image: image.png] https://brave.com/latest/ Tony

On Wed, Sep 4, 2024 at 6:37 AM Kamil Jozwiak @.***> wrote:

Closing the above as we've received several confirmations that the above has been resolved 👍

— Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/39069#issuecomment-2328877124, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKLNF77IV42GWVORWRH5ASTZU35H5AVCNFSM6AAAAABJK7SR4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYHA3TOMJSGQ . You are receiving this because you commented.Message ID: @.***>

fmarier commented 1 week ago

@tonysultana Looks like your screenshot didn't make it through GitHub's email reply.

tonysultana commented 1 week ago

It was just a picture of a pop-menu with that heavy transparent border around it.

On Wed, Sep 4, 2024, 12:05 PM Francois Marier @.***> wrote:

@tonysultana https://github.com/tonysultana Looks like your screenshot didn't make it through GitHub's email reply.

— Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/39069#issuecomment-2329679855, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKLNF7YBCVZSCF76SHKPWTDZU5DWRAVCNFSM6AAAAABJK7SR4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGY3TSOBVGU . You are receiving this because you were mentioned.Message ID: @.***>