brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.31k forks source link

Upgrade from Chromium 127 to Chromium 128. #39083

Closed mkarolin closed 2 months ago

mkarolin commented 4 months ago

Major Chromium bump

Upgrade from Chromium 127 to Chromium 128

https://chromium.googlesource.com/chromium/src/+log/127.0.6533.5...128.0.6537.2/?pretty=fuller&n=10000

QA tests

This is a major Chromium version bump, please do full passes.

Desktop affected areas:

  1. Page zoom (check Brave custom range of zoom values)
  2. Tabs styling looks correct
  3. Passwords importing
  4. Speedreader works
  5. Ads notifications look correct
  6. Sync works
  7. Https upgrade of url typed with http:// works
  8. Disabling a specific script in Shields works
  9. Check that various WebUIs do not crash the browser:
    • Playlist
    • AI Chat
    • VPN Panel
    • Bookmarks side panel
    • Shields panel
    • Cookie List Opt-in
    • Speedreader toolbar
    • Wallet Panel
    • Rewards Panel
    • Tipping Panel
    • Any other WebUIs you may think of
  10. Settings UI -> Profile name and icon -> Theme color picker
  11. Windows upgrading from previous version.

iOS affected areas:

  1. Bookmarks + exporting
  2. Password saving
  3. Private mode works

Android affected areas:

  1. Brave Leo panel
  2. Custom Tabs
  3. Bottom toolbar
  4. Phone, app menu in tabs preview mode
  5. Autocomplete at omnibox
  6. New tab page on a light theme
  7. Tablet, menu in tabs preview mode
  8. Bookmarks import
  9. Brave News
stephendonner commented 2 months ago

Verification PASSED using

Brave | 1.70.58 Chromium: 128.0.6613.18 (Official Build) nightly (64-bit)
-- | --
Revision | 4092fbd4ef3e2bd48c3e47e8afd7770bfb9e111f
OS | Windows 10 Version 22H2 (Build 19045.4717)

Page zoom (check Brave custom range of zoom values) - PASSED

* Confirmed both `ctrl` + `+` and `ctrl` + `-` shortcuts * Confirmed ability to zoom in/out/go full-page via the top-level "hamburger" menu -> Zoom (`+`/`-`/`[ ]`) * Confirmed zoom up to `500%` * Confirmed zoom down to `25%` * Confirmed range of zoom-level options in `brave://settings/braveContent` `500%` | `25%` | `main menu` | `full range` --------|-------|--------------|------------- ![image](https://github.com/user-attachments/assets/2ce37c10-195a-4fc8-956c-92bd7ce9ec40) | ![image](https://github.com/user-attachments/assets/92bc6965-866c-46e3-892a-a53133a1b2dd) | ![image](https://github.com/user-attachments/assets/6025d177-32f0-466e-a6e0-4b8d6f866d99) | ![image](https://github.com/user-attachments/assets/2fbf0cdd-c7aa-4c0b-bf08-edfdcb017e2f)

Tabs styling looks correct - PASSED

* Confirmed "squircle"-shaped rounded/square tabs * Confirmed default horizontal tabs view * Confirmed ability to use "compact" view * Confirmed vertical-tabs view Default, "horizontal" tabs ![image](https://github.com/user-attachments/assets/2c33e3f6-35cd-4af4-b077-ae67794b6fff) New-spacing, "compact" horizontal tabs example | example ----------|---------- ![image](https://github.com/user-attachments/assets/d0210c5d-dfb1-4bc6-8bb9-626a5451a33d) | ![image](https://github.com/user-attachments/assets/ed70520f-06ed-4072-adc0-de1b2e70d60f) Vertical tabs ![image](https://github.com/user-attachments/assets/73d5033b-b227-48d5-94d6-0cc0972a4060)

Passwords importing - PASSED

_**from Chrome**_ - `PASSED` `chrome://passwords` | `brave://password-manager/passwords` ------------------------|----------------------- ![image](https://github.com/user-attachments/assets/d950b14f-9b1f-4abc-a8e6-f3078527c600) | ![image](https://github.com/user-attachments/assets/8dfe3ad8-c2d2-4ee2-9212-57898d7cb79d) example | example ---------|--------- ![image](https://github.com/user-attachments/assets/ab29e723-d7ce-4d60-90ba-e2aa6c28aa92) | ![image](https://github.com/user-attachments/assets/bb13da01-5174-4fe8-8bdc-ba2189c9ace0) **_from Edge_** - `PASSED` example | `brave://password-manager/passwords` ----------|------------------------------------------- ![image](https://github.com/user-attachments/assets/24f59390-2323-4168-970f-c08bcb342ed8) | ![image](https://github.com/user-attachments/assets/4d1ae6d4-ff2a-4ec0-b65a-e7f493ad4acd) example | example ----------|---------- ![image](https://github.com/user-attachments/assets/ab1c44e6-6ac1-4cf6-a394-8ae2c3ff82c3) | ![image](https://github.com/user-attachments/assets/1bdf2650-ee6e-4625-86b9-e795853c2949) **_from Brave_** - `PASSED` * Confirmed passwords carried over from upgrading `1.68.137` -> `1.70.58` ### `1.68.137` example | example ----------|---------- ![image](https://github.com/user-attachments/assets/5c086916-a1e6-4a86-a3a3-bc6b28062c26) | ![image](https://github.com/user-attachments/assets/49fcae0e-4052-4299-86a9-31a8dbcf0d6b) | ### `1.70.58` example | example ----------|---------- ![image](https://github.com/user-attachments/assets/a35dc736-abed-4265-a82c-abe501466445) | ![image](https://github.com/user-attachments/assets/50d699ad-db87-45d9-a3b6-62e88d4299f1)

Speedreader works - PASSED

* Confirmed I could enter speedreader mode on `reuters.com` by clicking on the `Turn on Speedreader` icon in the URL bar * Confirmed I could invoke and hear the text-to-speech of the article * Confirmed I could customize the background, font color, style, and other elements example | example | example | example ----------|----------|-----------|---------- ![image](https://github.com/user-attachments/assets/9903f0b4-1fc9-4e64-a338-87e96c7a29f6) | ![image](https://github.com/user-attachments/assets/c942af6a-1b84-467e-97d2-5da0b3f55502) | ![image](https://github.com/user-attachments/assets/c39e62ff-e313-4d50-accc-acf12427fa59) | ![image](https://github.com/user-attachments/assets/9ac19423-e5b6-4c47-9068-e4fff377e833)

Ads notifications look correct - PASSED

* Confirmed ads shown once media stops playing * Confirmed able to dismiss the ad notification * Confirmed able to click on and load ad example | example | example | example | example ----------|----------|------------|----------|---------- ![image](https://github.com/user-attachments/assets/b1d6e397-6414-4c08-a03d-e407b7c0bbec) | ![image](https://github.com/user-attachments/assets/84e53da0-3ae4-4631-9f67-fe77174b5ff6) | ![image](https://github.com/user-attachments/assets/1d0ffe40-054a-49d7-a6ee-2c8e87749a20) | ![image](https://github.com/user-attachments/assets/ad8e66f4-1b1b-42c6-b212-0a7a4b43e188) | ![image](https://github.com/user-attachments/assets/9bb4363d-eb91-499f-b2dc-6a027d3cb93b)

Sync works - PASSED

* Confirmed I could start a new sync chain * Confirmed I could join an existing sync chain via QR code and sync-chain passphrase * Confirmed bookmarks synced between devices * Confirmed I could leave -- and later rejoin (data intact) -- the sync chain example | example | example | example | example ----------|----------|-----------|-----------|---------- ![image](https://github.com/user-attachments/assets/c06eb738-93e4-4ffc-a85d-1671ae0b99e4) | ![image](https://github.com/user-attachments/assets/bd90cc1e-e756-4835-b56d-e105b80fdfd8) | ![image](https://github.com/user-attachments/assets/812ab701-ee35-4997-8eda-eaa0c0ed7c1d) | ![image](https://github.com/user-attachments/assets/a6fbb212-e20d-4c98-935f-fcd04283ee05) | ![image](https://github.com/user-attachments/assets/2cf9d47e-ffbb-4df1-9c37-d510cfe036f5) example | example | example | example | example ----------|-----------|----------|-----------|----------- ![image](https://github.com/user-attachments/assets/d70d8351-028e-4ddd-a2cf-441076aeee86) | ![image](https://github.com/user-attachments/assets/8734078f-37c4-4983-97f6-a279a481343a) | ![image](https://github.com/user-attachments/assets/14a479f4-b491-412c-9867-e726a11f33b3) | ![image](https://github.com/user-attachments/assets/d06101fa-ae5e-414c-a088-74e0d44ef1e0) | ![image](https://github.com/user-attachments/assets/b961b9da-f773-4325-bb6f-1f67da60df84)

HTTPS upgrade of URL typed with http:// works - PASSED

* Confirmed typing and loading `http://https-everywhere.badssl.com/` auto-upgraded to `https://https-everywhere.badssl.com/` ![image](https://github.com/user-attachments/assets/9652c081-c52b-4913-b08c-21d524e67603)

Disabling a specific script in Shields works - PASSED

* Confirmed on `blizzard.com` * Confirmed initial blocking blocks all scripts * Confirmed blocking the main `blizzard.com` script via the `Shields` UI breaks page rendering example | example | example ----------|-----------|---------- ![image](https://github.com/user-attachments/assets/9a77d390-f6f9-45dd-b405-f87bf504a983) | ![image](https://github.com/user-attachments/assets/d6a5ff2a-58b1-4d73-81b9-26757202e347) | ![image](https://github.com/user-attachments/assets/92af7421-8a23-462a-8025-d8faa6fa694c)

Check that various WebUIs do not crash the browser: - PASSED

* Playlist - `PASSED` example | example | example | example ----------|----------|-----------|------------- ![image](https://github.com/user-attachments/assets/b7c8cc3f-3539-4845-bbad-f59985ea9028) | ![image](https://github.com/user-attachments/assets/daca0138-96d5-4077-b681-3f02fe5d0f1a) | ![image](https://github.com/user-attachments/assets/8b802e34-1d1a-48b6-906e-701bc5aa20e3) | ![image](https://github.com/user-attachments/assets/05c71590-24d1-4f18-a892-5992af553032) * AI Chat - `PASSED` example | example | example | example ----------|-----------|----------|---------- ![image](https://github.com/user-attachments/assets/4d568164-5371-4183-9455-edb281ca8cdb) | ![image](https://github.com/user-attachments/assets/d77d8c07-50f0-4f83-b8ff-237a02b6d87f) | ![image](https://github.com/user-attachments/assets/f336115e-9524-44aa-b805-99005e830100) | ![image](https://github.com/user-attachments/assets/b04d7e8a-8c90-47ba-b11d-bcfacb24284f) * VPN panel - `PASSED` example | example | example ----------|-----------|---------- ![image](https://github.com/user-attachments/assets/9c9ee075-678d-4b74-87cc-ec2c872c0cbe) | ![image](https://github.com/user-attachments/assets/b2cdf230-69d9-4f36-9ef4-1517f9964531) | ![image](https://github.com/user-attachments/assets/e5a8d768-6e2b-4707-b4a6-7c345d3a80ef) * Bookmarks side panel - `PASSED` example | example | example ----------|-----------|---------- ![image](https://github.com/user-attachments/assets/f377d9e3-b791-45a5-952e-61e46931a8df) | ![image](https://github.com/user-attachments/assets/a8304caf-44c3-4246-a910-75a19acfa994) | ![image](https://github.com/user-attachments/assets/455bfda8-1019-4ade-b9e5-c4672d372d25) * Shields panel - `PASSED` example | example | example ----------|-----------|----------- ![image](https://github.com/user-attachments/assets/50001df4-4bc1-4341-995b-aa7251b25186) | ![image](https://github.com/user-attachments/assets/1e516539-b49f-4dfc-9baf-c997c6b835a3) | ![image](https://github.com/user-attachments/assets/2c2ce819-32c9-47f8-b618-a2a6368faac0) * Cookie List opt-in - `PASSED` example | example | example | example ----------|-----------|----------|---------- ![image](https://github.com/user-attachments/assets/347ba220-01b7-4c75-8aca-ac63958cdc2b) | ![image](https://github.com/user-attachments/assets/5326bc7a-7740-4838-bb58-b168c1f5cd74) | ![image](https://github.com/user-attachments/assets/de4353f3-1aa7-45d7-b856-59e171e94839) | ![image](https://github.com/user-attachments/assets/965fa311-b88e-4bec-a3f2-08966086c5f7) * Speedreader toolbar - `PASSED` (covered in its own section) * Wallet Panel - `PASSED` example | example | example | example | example ----------|----------|----------|------------|---------- ![image](https://github.com/user-attachments/assets/e3045919-b5b4-4e2d-8300-a81cd7ac54da) | ![image](https://github.com/user-attachments/assets/9e5d6d87-39b4-47de-b62d-5fffaddba1bf) | ![image](https://github.com/user-attachments/assets/810bf121-2c72-42e1-8251-da59f6661097) | ![image](https://github.com/user-attachments/assets/0179f93d-ccb1-4bf1-8066-4dd155a317f9) | ![image](https://github.com/user-attachments/assets/79b11e23-a430-4405-abe0-f5a6ee223a85) | ![image](https://github.com/user-attachments/assets/b9760696-e228-4717-8828-fb315f380695) * Rewards Panel - `PASSED` example | example | example ----------|-----------|---------- ![image](https://github.com/user-attachments/assets/8d07dc01-05b0-45a2-90dd-32d38322879a) | ![image](https://github.com/user-attachments/assets/f7cc4e55-f53a-459f-8acf-d2bf0ccdf110) | ![image](https://github.com/user-attachments/assets/08a6bb91-21bb-460d-aaf9-9969327ef50b) * Tipping Panel - `PASSED` example | example | example | example ----------|----------|-----------|---------- ![image](https://github.com/user-attachments/assets/75fe82ca-a719-4d33-8740-4571c5c70137) | ![image](https://github.com/user-attachments/assets/2b046a82-4895-4ade-a728-e843dd58b7af) | ![image](https://github.com/user-attachments/assets/c9e69cc8-6cd9-43d0-b25b-201d7fe7c555) | ![image](https://github.com/user-attachments/assets/839def6d-e261-49e6-8ca1-4fb2bc42af8d)

Settings UI -> Profile name and icon -> Theme color picker - PASSED

example | example | example ----------|----------|---------- ![image](https://github.com/user-attachments/assets/e2b50e2b-b73d-4793-b766-0c8436c89346) | ![image](https://github.com/user-attachments/assets/78297209-a2af-4d14-9c4d-623cc1ebd410) | ![image](https://github.com/user-attachments/assets/abc5986d-9c3c-45ba-a56a-0c65a4ab0c9a)

Windows upgrading from previous version - PASSED

* Confirmed I could upgrade from `1.70.57` `127.0.6533.100` to `1.70.58` `128.0.6613.18`, via `brave://settings/help` `1.70.57` (`127.0.6533.100`) | `Relaunch` | `1.70.58` (`128.0.6613.18`) ----------|-------------|---------- ![image](https://github.com/user-attachments/assets/0daea8d8-b540-4dd7-8fd8-8c303ae6fadf) | ![image](https://github.com/user-attachments/assets/6e43106d-1caa-490b-a733-fa1c2bdefaa3) | ![image](https://github.com/user-attachments/assets/1c047386-7668-44ad-9ab8-e8c2e403394f)
GeetaSarvadnya commented 2 months ago

Verification PASSED on

Brave | 1.70.65 Chromium: 128.0.6613.27 (Official Build) nightly (64-bit)
-- | --
Revision | 8bf2d6fd36dc289a5918c6c06969c161d81717dc
OS | Windows 10 Version 22H2 (Build 19045.4651)

Settings comparison

- A new settings `Leo` is added as part of Brave via Hamburger menu, confirmed that click on `Leo` hamburger settings menu opens up the Leo panel and user can perform the Leo search queries. ![image](https://github.com/user-attachments/assets/11d16f1c-b96f-45b3-b2d8-e9d357c72a1a) - `Your models` section is added via brave://settings/leo-assistant ![image](https://github.com/user-attachments/assets/a31e2528-3b40-43ed-bdc8-beaed8d391b5)

Brave startup calls

Uni-verse commented 2 months ago

Verification completed on Samsung Galaxy Tab S7 using version:

Brave   1.70.61 Chromium: 128.0.6613.18 (Official Build) canary (64-bit) 
Revision    23eb433c3fd288dd150e23cab7484d6334518988
OS  Android 13; Build/TP1A.220624.014; 33; REL
Brave Leo panel - [x] Brave Leo opt-in flow is working. - [x] Leo UI and panels are working as expected. - [x] Paywall flow is working - [x] Premium upgrade is working, premium status is applied and Claude Sonnet is selectable and chat queries can be sent. Example | Example | Example -|-|- ![Screenshot 2024-08-12 at 2 58 10 PM](https://github.com/user-attachments/assets/a84e9cee-1d4a-42d6-ab82-8653ca539ad2) | ![Screenshot 2024-08-12 at 2 58 19 PM](https://github.com/user-attachments/assets/c05b3a0f-f738-476d-b287-0516b3784358) | ![Screenshot 2024-08-12 at 2 58 40 PM](https://github.com/user-attachments/assets/fbb70b20-7f12-466d-aabf-50eda6b23ea2) ![Screenshot 2024-08-12 at 3 04 38 PM](https://github.com/user-attachments/assets/cacd680b-df5b-48cc-8ac1-80e88c00702f) | ![Screenshot 2024-08-12 at 3 04 54 PM](https://github.com/user-attachments/assets/48c248bd-7d5f-45ec-9ae5-bffee3fecf35) | ![Screenshot 2024-08-12 at 3 05 25 PM](https://github.com/user-attachments/assets/87c2869c-95a7-4853-bfaf-7d71eeb698ae)
Custom Tabs - [x] Links can be opened in Brave custom tabs. - [x] Custom tabs can be minimized and enlarged without issues. - [x] Menu options for Custom tabs are working. Example | Example -|- ![Screenshot 2024-08-12 at 3 13 50 PM](https://github.com/user-attachments/assets/44f6f1f2-be29-4c70-a838-eeb6677704a1) | ![Screenshot 2024-08-12 at 3 13 59 PM](https://github.com/user-attachments/assets/6b7d2086-33e6-4a60-9e8d-d4704a2ab043)
Bottom toolbar **N/A for Tablet**
Phone, app menu in tabs preview mode **N/A**
Autocomplete at omnibox - [x] Autocomplete is shown in the address bar with suggestions enabled/disabled. - [x] Browser suggestions are working when enabled. Example | Example -|- ![Screenshot 2024-08-12 at 5 07 49 PM](https://github.com/user-attachments/assets/e4c311e9-c68c-47e6-aef8-fe4bf7177ea8) | ![Screenshot 2024-08-12 at 5 08 02 PM](https://github.com/user-attachments/assets/55198a76-e73e-405e-ad04-5712593e670d)
New tab page on a light theme - [x] Ensured New Tab Page functionality is working with light theme. - [x] Opening new tabs when light theme enabled. - [x] Opening new tabs is working when theme matches system and is set to light. Example | Example -|- ![Screenshot 2024-08-12 at 3 21 35 PM](https://github.com/user-attachments/assets/97d6a557-e32a-4f05-8d91-5d11d4fda540) | ![Screenshot 2024-08-12 at 3 22 20 PM](https://github.com/user-attachments/assets/57140225-71b7-4406-ba21-3f6026031ad3)
Tablet, menu in tabs preview mode - [x] menu in tabs is working in preview mode. Example | Example -|- ![Screenshot 2024-08-12 at 5 13 43 PM](https://github.com/user-attachments/assets/e24eb911-5af0-469e-a388-638e6acc16ad) | ![Screenshot 2024-08-12 at 5 23 37 PM](https://github.com/user-attachments/assets/cdedfd36-84e8-4033-8283-1aa06f1e4023)
Bookmarks import - Ensured bookmarks can be imported from the file system and imports folder is shown in Bookmarks view. Example | Example | Example -|-|- ![Screenshot 2024-08-12 at 3 18 24 PM](https://github.com/user-attachments/assets/c906d25c-757f-4328-9307-7611a9ad056d) | ![Screenshot 2024-08-12 at 3 18 55 PM](https://github.com/user-attachments/assets/213ec28b-0484-4d4a-bc13-0c3ef8ad2fad) | ![Screenshot 2024-08-12 at 3 19 33 PM](https://github.com/user-attachments/assets/901f3f61-86f3-48d4-ae95-76685806ac4d)
Brave News - [x] Brave News opt-in card is shown for new installs. - [x] Users can opt-in using the card on NTP or from the Brave News setting page. - [x] Brave ads are shown in the news feed and can be loaded in a tab by clicking on them. - [x] Different sources can be added via the Brave News menu and feed is updated with the sources. - [x] Tapping on the articles in feed will open that URL in a new tab. - [x] Brave News is working when Brave Rewards are enabled. Example | Example | Example | Example | Example -|-|-|-|- ![Screenshot 2024-08-12 at 3 34 58 PM](https://github.com/user-attachments/assets/4b641e55-dde1-42d3-8abb-213b812a8dac) | ![Screenshot 2024-08-12 at 3 19 51 PM](https://github.com/user-attachments/assets/11b5695c-4636-4288-a774-f1f47bcb7a2b) | ![Screenshot 2024-08-12 at 3 20 11 PM](https://github.com/user-attachments/assets/8a488bf5-6755-4cfb-9449-c8558faf9030) | ![Screenshot 2024-08-12 at 3 21 15 PM](https://github.com/user-attachments/assets/553e999a-d7b5-4033-8414-d14643ecdb18) | ![Screenshot 2024-08-12 at 3 23 07 PM](https://github.com/user-attachments/assets/fd855c7f-f69a-4546-8344-3eddac6023ff)
kjozwiak commented 2 months ago

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.70.67 Chromium: 128.0.6613.27 (Official Build) canary (64-bit)
--- | ---
Revision | bba8f988a43a602a34d1e29c3ea07731d6bd9130
OS | Android 15; Build/AP31.240617.010; 35; REL

Brave Leo panel - PASSED

* ensured that the `Leo` onboarding is working as expected once the user interacts with `Leo` for the first time * ensured that the `T&S` links within the onboarding model are working as expected * ensured that the `Paywall` is working as expected (also ensured that you can go through the entire flow without issues) * ensured that you can switch between the different language models without any issues * ensured that `New Chat`, `Manage Subscription` and `Advanced settings` worked via the `Leo` panel **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|----------------|----------------|----------------|---------------- ![1000001947](https://github.com/user-attachments/assets/13849eb5-0b5c-4f55-beca-866940064aaa) | ![1000001948](https://github.com/user-attachments/assets/2a229094-d6d1-4f02-a2ca-0c6534aceb1e) | ![1000001949](https://github.com/user-attachments/assets/e9bcab9e-6cd0-4e50-9b79-795eab1d336b) | ![1000001950](https://github.com/user-attachments/assets/d2c8abc7-608d-4e5a-a6e7-d11186524def) | ![1000001951](https://github.com/user-attachments/assets/14b4abf6-cd12-4164-a441-54e479641623) | ![1000001952](https://github.com/user-attachments/assets/e67f4527-df2b-4d64-b7f8-14aec2721665) **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|----------------|----------------|----------------|---------------- ![1000001953](https://github.com/user-attachments/assets/20fa0167-b0c1-4452-a306-75333b606a2d) | ![1000001954](https://github.com/user-attachments/assets/7e5e3477-1923-471b-8932-e312f9712f2f) | ![1000001955](https://github.com/user-attachments/assets/b47d3d61-c781-4987-802f-b5b8e3c88416) | ![1000001956](https://github.com/user-attachments/assets/9f44f48c-d9ee-432e-99c6-d4e32ae03acc) | ![Screenshot_20240812-212134](https://github.com/user-attachments/assets/d6cbeff6-c881-4423-bfe6-54847556c8c3) | ![Screenshot_20240812-212215](https://github.com/user-attachments/assets/aa5b7282-ad8f-4683-908f-75c344940844)

Custom Tabs - PASSED

* ensured that you can open custom links within a third party application without any issues (**Note:** Brave needs to be default) * ensured that the shields panel worked without any issues via `custom tabs` * ensured that `Open in Brave - Nightly browser` worked without any issues and launched Brave Nightly * ensured that the settings under the `Hamburger Menu` are working (`Find in Page`, `Desktop Site`, `Translate`, `Add Home`) * ensured that links within third party applications are being opened within Brave if `Open within target application` isn't set * ensured the above is working while Brave is completely closed & running in the background **`Example`** | **`Example`** | **`Example`** ----------------|----------------|------------------ ![Screenshot_20240812-171153](https://github.com/user-attachments/assets/1783ed70-be2d-4c31-9332-e41b8c386e94) | ![Screenshot_20240812-171159](https://github.com/user-attachments/assets/e2093f6d-9e95-4054-b9f7-ddb469eecc1a) | ![Screenshot_20240812-171227](https://github.com/user-attachments/assets/d794bce0-e9c0-4964-82ea-c31d090fb18a)

Bottom Toolbar - PASSED

* ensured that the default `Home` button redirects to NTP * ensured that you can set a default `Home` URL via `Settings` -> `Homepage` * ensured that tapping/pressing on the `Home` button correctly loads the custom URL/page * ensured that you can enable/disable the `Home` button without issues via `Settings` -> `Homepage` * ensured that you can `Bookmark` webpages via the `Bookmark` button via the bottom toolbar without issues * ensure that the `Bookmark` icon is coloured `Orange` indicating that the current URL has already been bookmarked * ensured that the `Search` icon selects the URL bar and opens the OSK via NTP and when a page is being viewed * ensured the the `Tab` icon shows the correct number of tabs currently opened * ensured that you can open a new NTP via long press -> `New tab` * ensured that you can open a new Private tab via long press -> `New Private tab` * ensured that the `Hamburger Menu` opens `Settings` without any issues **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|----------------|----------------|----------------- ![Screenshot_20240812-172603](https://github.com/user-attachments/assets/5bd511de-a9d1-4983-9bdc-0fa29d5a8184) | ![Screenshot_20240812-172624](https://github.com/user-attachments/assets/a8fb6c33-122d-4fdd-8b8d-219428295892) | ![Screenshot_20240812-172632](https://github.com/user-attachments/assets/3d8bcbf1-e956-4a24-aa15-a2f116175876) | ![Screenshot_20240812-172719](https://github.com/user-attachments/assets/d0a917f5-a88c-468f-8df4-e8b5b6627974) | ![Screenshot_20240812-173055](https://github.com/user-attachments/assets/2a3357f9-3bdc-4cbc-81af-3b26110a73aa)

Phone, app menu in tabs preview mode - PASSED

* ensured that tapping phone numbers within Brave Search results & websites opens the `Phone` application without issues * ensured that the `Hamburger Menu` under the tabs preview worked without any issues * ensured that `New Tab`, `New Private Tab`, `Close all tabs`, `Select tabs`, `Delete browsing data` & `Settings` was working * ensured that the `Hamburger Menu` under the tabs preview while several tabs have been selected worked without issues * ensured that `Deselect all`, `Close tabs`, `Group tabs`, `Bookmark tabs` & `Share Tabs` was working without issues **`Phone application verifications`** **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|----------------|---------------- ![Screenshot_20240812-174511](https://github.com/user-attachments/assets/33513767-4319-49a8-800e-08597bd83ac6) | ![Screenshot_20240812-174514](https://github.com/user-attachments/assets/758794a5-9b6e-42fa-ae73-beb48a01058f) | ![Screenshot_20240812-174300](https://github.com/user-attachments/assets/1c97884f-9b0c-44c6-adea-a12f1d0dc75d) | ![Screenshot_20240812-174304](https://github.com/user-attachments/assets/58682f4a-64a2-445b-98b9-3025ea656ee9) **`Tabs Preview Menu`** **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|----------------|----------------|-----------------|----------------|----------------- ![Screenshot_20240812-174838](https://github.com/user-attachments/assets/0f264220-ef75-417e-a601-bc47a29d62e0) | ![Screenshot_20240812-174853](https://github.com/user-attachments/assets/ed13c443-c264-4407-9b80-2a970476a13b) | ![Screenshot_20240812-174905](https://github.com/user-attachments/assets/bc616534-925d-475b-bd2a-e3dd997e5506) | ![Screenshot_20240812-174909](https://github.com/user-attachments/assets/2b813b1c-3637-4aac-938f-e1cbd876a3b1) | ![Screenshot_20240812-174940](https://github.com/user-attachments/assets/1acb57ae-acd7-4e74-a07a-6b1253584c05) | ![Screenshot_20240812-175425](https://github.com/user-attachments/assets/22b19d5e-aebe-4b81-994a-5f66adbcac06) | ![Screenshot_20240812-175432](https://github.com/user-attachments/assets/655ffc06-298d-40a7-be5d-929115239384)

Autocomplete at omnibox - PASSED

* ensured that rich autocomplete search results are appearing within the omnibox when Brave Search is selected as default * ensured that search history is appearing/being displayed in the omnibox when searching for similar terms * ensured that bookmarks are appearing within the omnibox when searching for the same term/website * ensured that the `Ask Leo` UI is appearing at the bottom of search suggestions and working as expected * ensured that suggestions are NOT being displayed in the omnibox when `Show browser suggestions` is disabled * ensured top sites are not being displayed within the omnibox when `Show top sites suggestions` is disabled **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|----------------|---------------|----------------|----------------- ![1000001959](https://github.com/user-attachments/assets/698a0710-33e3-43c5-aab0-753b0557c8d5) | ![1000001960](https://github.com/user-attachments/assets/87be52fb-78f9-4177-9d55-e1caf558ee75) | ![1000001961](https://github.com/user-attachments/assets/1aab0c82-1153-4c63-86e2-499b1d860b77) | ![1000001962](https://github.com/user-attachments/assets/90ab55d5-d261-4864-8a56-a40548bce0a4) | ![1000001963](https://github.com/user-attachments/assets/a9b7b801-a8e1-495b-884f-80a9e650deb6) | ![1000001964](https://github.com/user-attachments/assets/9418e53a-a7e0-4a10-8d65-67cfed7d5a13)

New tab page on a light theme - PASSED

* ensured the `omnibox` appears correct without any issues * ensured that the `Privacy Stats` are appearing without any issues * ensured that the `Favorite` icons are appearing without any issues * ensured that `Brave News` is appearing without any issues * ensured that the `Bottom Toolbar` is appearing without any issues * ensured that the `Hamburger Menu` appears without any issues **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|----------------|---------------|------------------ ![1000001942](https://github.com/user-attachments/assets/b5083558-d714-4642-bab6-c8baf6cc0b87) | ![1000001943](https://github.com/user-attachments/assets/3a0faa9c-f223-4a1c-8ef8-399716449801) | ![1000001944](https://github.com/user-attachments/assets/a1aa57ca-d651-49f9-81f8-f777fab9dd63) | ![Screenshot_20240812-181854](https://github.com/user-attachments/assets/5d798101-0bd3-4428-a8fa-83f10e76134e) | ![Screenshot_20240812-181859](https://github.com/user-attachments/assets/b220f041-b86e-4b44-9fa2-8f868dca5c82)

Bookmarks import - PASSED

* ensured that importing bookmarks worked without any issues/failures * ensured that the structure of the imported bookmarks is retained * ensured that you can open imported bookmarks without any issues **`Example`** | **`Example`** | **`Example`** ----------------|----------------|--------------- ![1000001966](https://github.com/user-attachments/assets/aad8e2ad-c7e8-4062-a210-706fa613d3e9) | ![1000001967](https://github.com/user-attachments/assets/c1b2c751-0ab2-47ac-9a8d-e11bb25fdf8b) | ![1000001968](https://github.com/user-attachments/assets/1babfabe-91ce-4b25-9a8c-608ee0206096)

Brave News - PASSED

* ensured that the opt-in Brave News modal appears under the NTP without issues * ensured that you can dismiss the opt-in Brave News modal via `X` without any issues * ensured that once dismissed, the modal doesn't appear within other NTP * ensured that you can opt-in into Brave News via the opt-in modal under NTP without issues * ensured that you can opt-in into Brave News via `Settings` * ensured that Brave Ads are being displayed within Brave News with Brave Rewards disabled & enabled * ensured that you can long tap on articles and do the following: * open the targeted article within a new tab via `Open in New Tab` * open the targeted article within a new private tab via `Open in New Private Tab` * ensure that you can disable content from particular sources * ensured that scrolling through Brave News doesn't cause any notifiable performance issues/crashes * ensured that you get a `Load new content` button/modal via the news feed once changes have been made **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|---------------|-----------------|------------------ ![1000001969](https://github.com/user-attachments/assets/c851c9ba-8076-4998-8760-b9668f0d0c0e) | ![1000001970](https://github.com/user-attachments/assets/59bf6da0-d615-473c-9004-39fb039d5ddf) | ![1000001971](https://github.com/user-attachments/assets/372ce882-f90a-48cb-a8d1-09d559be2028) | ![1000001972](https://github.com/user-attachments/assets/0fafefb6-b635-4c61-b7b8-6cf2edfc58eb) | ![1000001973](https://github.com/user-attachments/assets/09968ad6-c9af-4c01-b6c4-a545e10c3ccd) **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ----------------|----------------|---------------|-----------------|------------------ ![1000001974](https://github.com/user-attachments/assets/6eeac00a-61f4-47fa-adc0-98e8d38ef1e1) | ![1000001975](https://github.com/user-attachments/assets/33a6f24a-b0f6-4a96-98c0-c7118fd54d01) | ![1000001976](https://github.com/user-attachments/assets/1a2c9186-b732-46f1-9202-0f4fa1db9e35) | ![1000001977](https://github.com/user-attachments/assets/f75efe1b-06dd-470b-a852-13567be4e4d7) | ![1000001978](https://github.com/user-attachments/assets/a8ff003d-8840-43b3-ba46-0c9c97768e96)
kjozwiak commented 2 months ago

Labelling as QA/No & release-notes/exclude in favor of https://github.com/brave/brave-browser/issues/40348.