brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.96k stars 2.21k forks source link

NOTREACHED() in content::WebUIImpl::ProcessWebUIMessage - getCookieDetails #39104

Open iefremov opened 1 week ago

iefremov commented 1 week ago

https://share.backtrace.io/api/share/ZncLfTLF9HqDJT10x3VamU1 see Logging-NOTREACHED_MESSAGE attribute

web_ui_impl.cc:272: NOTREACHED hit. Unhandled chrome.send("localData.getCookieDetails", [ "localData.getCookieDetails_77",  ]
); from chrome://settings/cookies/detail
[ 00 ] crash_reporter::DumpWithoutCrashing() ( crashpad.cc:270 )
[ 01 ] base::debug::DumpWithoutCrashing(base::Location const&, base::TimeDelta) ( dump_without_crashing.cc:94 )
[ 02 ] logging::(anonymous namespace)::DumpWithoutCrashing(base::debug::CrashKeyString*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::Location const&, base::NotFatalUntil) ( check.cc:132 )
[ 03 ] logging::(anonymous namespace)::NotReachedLogMessage::~NotReachedLogMessage() ( check.cc:145 )
[ 04 ] logging::(anonymous namespace)::NotReachedLogMessage::~NotReachedLogMessage() ( check.cc:143 )
[ 05 ] std::__Cr::default_delete<logging::LogMessage>::operator()(logging::LogMessage*) const ( unique_ptr.h:67 )
[ 06 ] std::__Cr::unique_ptr<logging::LogMessage, std::__Cr::default_delete<logging::LogMessage>>::reset(logging::LogMessage*) ( unique_ptr.h:278 )
[ 07 ] logging::CheckError::~CheckError() ( check.cc:350 )
[ 08 ] content::WebUIImpl::ProcessWebUIMessage(GURL const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::Value::List) ( web_ui_impl.cc:272 )
[ 09 ] content::WebUIImpl::Send(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::Value::List) ( web_ui_impl.cc:129 )
[ 10 ] content::mojom::WebUIHostStubDispatch::Accept(content::mojom::WebUIHost*, mojo::Message*) ( web_ui.mojom.cc:207 )
[ 11 ] mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ( interface_endpoint_client.cc:1036 )
[ 12 ] mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*) ( interface_endpoint_client.cc:368 )
[ 13 ] mojo::MessageDispatcher::Accept(mojo::Message*) ( message_dispatcher.cc:43 )
[ 14 ] mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) ( interface_endpoint_client.cc:721 )
[ 15 ] IPC::ChannelAssociatedGroupController::AcceptOnEndpointThread(mojo::Message, IPC::(anonymous namespace)::ScopedUrgentMessageNotification) ( ipc_mojo_bootstrap.cc:1198 )
jagadeshjai commented 1 week ago

@iefremov Can I work on this?

iefremov commented 1 week ago

@jagadeshjai yeah well, i guess we need a decision from the product team on do we really just want to drop the obsolete UIs, or implement something instead

jagadeshjai commented 1 week ago

@jagadeshjai yeah well, i guess we need a decision from the product team on do we really just want to drop the obsolete UIs, or implement something instead

@iefremov Sure! Could you please mention them here.

jagadeshjai commented 1 week ago

@cdesouza-chromium / @rebron Could you shed some light on this issue and the PR I raised?

cdesouza-chromium commented 6 days ago

I'm not sure that I can comment on this.

jagadeshjai commented 6 days ago

Hmm, I guess @spylogsster / @ShivanKaul Would be the right persons to get input from 🤔.

ShivanKaul commented 6 days ago

This is related to https://github.com/brave/brave-browser/issues/39033