Update 1.67 Japanese translations

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.61k stars 2.29k forks source link

Closed iccub closed 3 months ago

iccub commented 3 months ago

iOS

Update them when ready

iccub commented 3 months ago

Adding to 1.67 milestone so we don't forget about it

iccub commented 3 months ago

Changed copy to verify: Test using Japan region only this ticket affects JP only.

kjozwiak commented 3 months ago

The above requires 1.67.127 or higher for 1.67.x verification 👍

Uni-verse commented 3 months ago

Verified on iPhone 12 running iOS 17.5.1 using version 1.67.127

Ensured the following copy changes for Japan region using template in https://github.com/brave/brave-browser/issues/39385#issuecomment-2195787050. Ensured user is able to complete onboarding flow without issues. Ensured P3A toggle and link to support page works in third screen.

[x] Title of the screen that shows ads are blocked
[x] Subtitle of the screen that shows ads are blocked
[x] Title of the screen that shows embedded videos are blocked
[x] Subtitle of the screen that shows embedded videos are blocked
[x] Title of the screen which requests users to set Brave as default
[x] Subtitle of the screen which requests users to set Brave as default
[x] Title of the button that finishes onboarding without setting the Default browser.
[x] Title of screen which asks users about P3A
[x] Subtitle of the screen which asks users about P3A
[x] Description of the brave P3A support link
[x] Title of the toggle for enable / disable privacy preserving analytics.

Onboarding (Japan)

Onboarding (English)

First screen	Second screen	Third screen	Fourth screen

hffvld commented 3 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.67 (127)
BraveCore: 1.67.127 (126.0.6478.126)

Upgrade profile

STEPS:

Set device language and region to Japanese/Japan
Install and launch Brave 1.67 (125)
Open a few websites and change Brave Shields settings
Open a few websites and sign in > Keep at least 1 website opened and close at least 1 website
Change default SE > Make a search in the Standard and Private tab
Change Leo's language model > Ask a query
Add some Bookmarks
Join Sync chain
Upgrade Brave to 1.67 (127)
Verify that nothing is broken and all updated settings are not reverted to default

ACTUAL RESULTS:

Verified Verify that nothing is broken and all updated settings are not reverted to default