brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.67k stars 2.31k forks source link

Upgrade from Chromium 127.0.6533.17 to Chromium 127.0.6533.26 #39401

Closed emerick closed 3 months ago

emerick commented 3 months ago

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/127.0.6533.17..127.0.6533.26?pretty=fuller&n=10000###

QA tests

Minor Chromium bump

kjozwiak commented 3 months ago

Quick overview of the work remaining re: affected areas due to C127 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via https://github.com/brave/brave-browser/issues/38560#issue-2315856848:

Platforms that still need to check/verify the affected areas due to C127 changes as per https://github.com/brave/brave-browser/issues/38560#issue-2315856848:

kjozwiak commented 3 months ago

The above requires 1.68.107 or higher for 1.68.x verification 👍

stephendonner commented 3 months ago

Verified PASSED using

Brave | 1.68.107 Chromium: 127.0.6533.26 (Official Build) beta (x86_64)
-- | --
Revision | 131a9beda9f0aea74f948286e5e8c63153d9f7f8
OS | macOS Version 11.7.10 (Build 20G1427)
Verify hamburger menu UI, icons, items, ordering - PASSED - Verified the side panel testing in `Settings comparison` section below - Logged and encountered https://github.com/brave/brave-browser/issues/39377
Verify tab UI, style, and functionality (rearranging tabs, tearing off tabs, vertical tabs, tab groups, etc.) - PASSED **Horizontal tabs view:** Confirmed that tabs drag and drop works as expected for Horizontal tabs ![horizontal-drag](https://github.com/brave/brave-browser/assets/387249/9090f8fa-eae6-4467-b4ca-081102f252b8) **Vertical tabs view:** Confirmed that tabs drag and drop works as expected for Vertical tabs ![vertical-drag](https://github.com/brave/brave-browser/assets/387249/efcecead-7ac9-4283-b4a1-243c97240071) **Tab groups** - Confirmed tab groups works as expected ![tab-groups](https://github.com/brave/brave-browser/assets/387249/df66e746-81dc-45ca-9825-33927a42a1d9) **Tab shapes:** - Confirmed that Tab shapes are shown as expected in `Card` tab type - Confirmed that Tab shapes are shown as expected in `Card with preview` tab type - Confirmed that Tab shapes are shown as expected in `Tooltip` tab type Card | Card with preview | Tooltip --------------|--------------|-------------- Screen Shot 2024-07-03 at 12 23 50 PM | Screen Shot 2024-07-03 at 12 25 09 PM | Screen Shot 2024-07-03 at 12 27 19 PM **active/inactive tab colors:** - Confirmed that active/inactive tab colors are shown as expected
Verify tab search UI and functionality - PASSED - Confirmed that all the opened/closed tabs are opened via Tab search panel - Confirmed that user can see recently closed tabs via Tab search panel - Confirmed that user can search specific site via Tab search panel - Confirmed that user can close the specific tab via Tab search panel Example | Example | Example | Example ----------|----------|----------|---------- Screen Shot 2024-07-03 at 12 31 07 PM | Screen Shot 2024-07-03 at 12 31 12 PM | Screen Shot 2024-07-03 at 12 33 02 PM | Screen Shot 2024-07-03 at 12 33 15 PM
Verify clear browsing data functionality - PASSED - Confirmed that browser data can be deleted via hamburger settings menu `Delete browsing data` or via brave://settings/privacy `Delete browsing data` - Click on `Delete browsing data` opens up the `Delete browsing data` popup modal Screen Shot 2024-07-03 at 1 04 23 PM - Confirmed that user can delete the browsing data
Verify all side-panel related functionality - PASSED - Verified the side panel testing in `Settings comparison` section below - Logged and encountered https://github.com/brave/brave-browser/issues/39382
Verify all toolbar related functionality - PASSED **Tab search** - Confirmed that `Tab search` toolbar icon is displayed as expected - Confirmed that all the opened/closed tabs are opened via Tab search panel - Confirmed that user can see recently closed tabs via Tab search panel - Confirmed that user can search specific site via Tab search panel - Confirmed that user can close the specific tab via Tab search panel **Rewards**: - Confirmed that rewards BAT toolbar icon is displayed as expected - Confirmed that Rewards panel works as expected - Confirmed that publisher info is shown as expected on rewards panel - Confirmed that AC notification shown as expected on BR panel Example | Example | Example | Example ----------|-----------|----------|------ Screen Shot 2024-07-03 at 1 14 40 PM | Screen Shot 2024-07-03 at 1 18 38 PM | Screen Shot 2024-07-03 at 1 42 40 PM | Screen Shot 2024-07-03 at 1 52 45 PM **Shields** - Confirmed that shields toolbar icon is displayed as expected - Shield panel is shown as expected in normal view - Shield panel is shown as expected in advanced view - Shield panel is shown as expected disabled mode Example | Example | Example ----------|-----------|---------- Screen Shot 2024-07-03 at 2 01 12 PM | Screen Shot 2024-07-03 at 2 01 19 PM | Screen Shot 2024-07-03 at 2 01 39 PM **Sidebar toolbar icon** - Confirmed that Sidebar toolbar icon is displayed as expected - Confirmed that click on sidebar icon displayed the sidebar panel as expected - Confirmed that icons on the sidebar panel works as expected Example | Example | Example ----------|-----------|--------- Screen Shot 2024-07-03 at 2 03 58 PM | Screen Shot 2024-07-03 at 2 04 43 PM | Screen Shot 2024-07-03 at 2 06 55 PM **Wallet** - Confirmed that wallet toolbar icon is displayed as expected - Confirmed that click on wallet opens up the wallet modal popup - Confirmed that user can create wallet example | example | example | example | example | example ---------|----------|---------|----------|---------|--------- Screen Shot 2024-07-05 at 2 30 18 PM | Screen Shot 2024-07-05 at 2 30 26 PM | Screen Shot 2024-07-05 at 2 30 30 PM | Screen Shot 2024-07-05 at 2 30 34 PM | Screen Shot 2024-07-05 at 2 30 48 PM | Screen Shot 2024-07-05 at 2 30 53 PM example | example | example | example | example | example ---------|----------|---------|----------|---------|--------- Screen Shot 2024-07-05 at 2 30 56 PM | Screen Shot 2024-07-05 at 2 31 09 PM | Screen Shot 2024-07-05 at 2 31 15 PM | Screen Shot 2024-07-05 at 2 31 25 PM | Screen Shot 2024-07-05 at 2 32 13 PM | Screen Shot 2024-07-05 at 2 32 19 PM **VPN** - Confirmed that VPN panel is shown as expected in connected state - Confirmed that VPN panel is shown as expected in disconnected state - Confirmed that VPN panel is shown as expected in connecting state - Confirmed that VPN panel is shown as expected in region selection state - Confirmed that VPN panel is shown as expected in error state Example | Example | Example | Example | Example ----------|-----------|----------|---------|---------- Screen Shot 2024-07-03 at 2 21 58 PM | Screen Shot 2024-07-03 at 2 22 01 PM | Screen Shot 2024-07-03 at 2 22 03 PM | Screen Shot 2024-07-03 at 2 22 22 PM | Screen Shot 2024-07-03 at 2 20 26 PM
Verify profile-related functionality (creating new profiles, guest profiles, avatar selection, profile menu, etc.) - PASSED - Confirmed that user can create a new profile via `Hamburger menu->More tools->Add new profile` - Confirmed that user can pick different avatar for each profile - Confirmed that user can edit the profile name/avatar via profile manager - Confirmed that user can open the guest window via profile menu - Confirmed that user can open guest window via profile manager Example | Example | Example | Example | Example | Example ----------|-----------|---------|-----------|-----------|-------- Screen Shot 2024-07-03 at 2 34 19 PM | Screen Shot 2024-07-03 at 2 34 23 PM | Screen Shot 2024-07-03 at 2 34 32 PM | Screen Shot 2024-07-03 at 2 34 34 PM | Screen Shot 2024-07-03 at 2 34 43 PM | Screen Shot 2024-07-03 at 2 34 46 PM
Verify browser themes functionality and light/dark mode - PASSED - Confirmed that toolbar icons, settings, and omnibox looks as expected in `Light` theme - Confirmed that toolbar icons, settings, and omnibox looks as expected in `Dark` theme **Light theme** Example | Example ----------|--------- Screen Shot 2024-07-03 at 2 39 47 PM | Screen Shot 2024-07-03 at 2 41 44 PM **Dark theme** Example | Example ----------|--------- Screen Shot 2024-07-03 at 2 39 52 PM | Screen Shot 2024-07-03 at 2 41 35 PM **Themes from CWS** Example | Example | Example | Example | Example ----------|---------|------------|-------|---------- Screen Shot 2024-07-03 at 4 15 00 PM | Screen Shot 2024-07-03 at 4 15 27 PM | Screen Shot 2024-07-03 at 4 15 52 PM | Screen Shot 2024-07-03 at 4 16 20 PM | Screen Shot 2024-07-03 at 4 17 03 PM
Verify page info functionality, specifically cookie-related info - PASSED **_Update the cookies setting_** 1. Open a `site A` and and click on the site-information icon and ensured that the third party cookies are blocked on the `site A` Screen Shot 2024-07-03 at 4 48 47 PM 2. Go to `brave://settings/shields` and select `Block all cookies` Screen Shot 2024-07-03 at 4 46 18 PM 3. Reload `site A` and click on the site information icon and ensured that the third party cookies are blocked on `site A` Screen Shot 2024-07-03 at 4 47 09 PM 4. Open the `Shields` panel on `site A` and ensure that _global_ cookies settings are applied Screen Shot 2024-07-03 at 4 47 47 PM 5. Go to `brave://settings/shields` and select `Allow all cookies` Screen Shot 2024-07-03 at 4 48 20 PM 6. Reload `site A` and click on the site-information icon and ensured that the cookies are allowed on the `site A` Screen Shot 2024-07-03 at 4 48 47 PM 7. Open the `Shields` panel on `site A` and ensure that _global_ cookies settings are applied Screen Shot 2024-07-03 at 4 49 19 PM **_Check Allow cookies functionality:_** 1. Clean profile 1.68.111 2. Go to `brave://settings/shields` 3. Change cookies settings to `Block all cookies` Screen Shot 2024-07-03 at 6 09 06 PM 5. Open a site A 6. Open Shields panel and ensure that block all cookies settings selected in the dropdown Screen Shot 2024-07-03 at 6 09 39 PM 7. Click on site information on a Site A and ensure that all the cookies are blocked Screen Shot 2024-07-03 at 6 12 20 PM 8. Go to `brave://settings/cookies` 9. Click on Add button and add a Site B to allow cookies list Screen Shot 2024-07-03 at 6 22 09 PM 9. Open site B in a NTP 10. Click on site information on a Site B and ensure that all the cookies are allowed as site B is added into allow cookies list in step 8 Screen Shot 2024-07-03 at 6 22 34 PM 11. Open shield panel for site B 12. Ensured that global cookies settings are applied as expected Screen Shot 2024-07-03 at 6 22 49 PM Case 1: 1. Clean profile `1.68.111` 14. Open a site 15. Click on the site shield settings 16. Change the trackers and ad blocking settings from `Block third part cookies` to `Block all cookies` 17. Restart the browser 18. Open the site shield settings, confirmed updated cookies settings are retained Case 2: 1. Continuation of case 1 2. Open a site 6. Click on the site shield settings 10. Change the trackers and ad blocking settings from `Block all cookies` to `Allow all cookies` 11. Restart the browser 12. Open the site shield settings, confirmed updated cookies settings are retained Case 3: 1. Continuation of case 2 2. Open a site 4. Click on the site shield settings 5. Change the trackers and ad blocking settings from `Allow all cookies` to `Block third party site cookies` 6. Restart the browser 7. Open the site shield settings, confirmed updated cookies settings are retained
Verify ad notifications UI and functionality - PASSED
1. Notification ads - PASSED - Confirmed that notification ads are shown as expected - Confirmed that ad notification UI looks as expected - Confirmed that users are rewarded for viewing notification ads - Confirmed that notification ads are displayed under ads history Example | Example ----------|----------- Screen Shot 2024-07-05 at 1 27 12 PM | Screen Shot 2024-07-05 at 1 31 16 PM ``` [1276:259:0705/132702.533454:VERBOSE1:notification_ad_handler.cc(176)] Served notification ad impression: placementId: 620ebe62-8c35-4da9-81db-66795df2ce20 creativeInstanceId: d55f52f6-f02b-4808-b6e2-b2a7734ad836 creativeSetId: 45ea5952-37ca-41f0-88c2-4b546b0e6f4b campaignId: 1c1ac828-db13-49bb-9128-090132044b7f advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8 segment: untargeted title: Ad2 body: Ad2 targetUrl: https://brave.com/ [1276:259:0705/132702.533730:VERBOSE6:ads_service_impl.cc(847)] Timeout notification ad with placement id 620ebe62-8c35-4da9-81db-66795df2ce20 in 120 s [1276:259:0705/132702.828734:VERBOSE3:notification_ad_handler.cc(187)] Served notification ad impression with placement id 620ebe62-8c35-4da9-81db-66795df2ce20 and creative instance id d55f52f6-f02b-4808-b6e2-b2a7734ad836 [1276:259:0705/132703.030719:VERBOSE3:notification_ad_handler.cc(194)] Viewed notification ad impression with placement id 620ebe62-8c35-4da9-81db-66795df2ce20 and creative instance id d55f52f6-f02b-4808-b6e2-b2a7734ad836 [1276:259:0705/132703.030910:VERBOSE9:client_state_manager.cc(388)] Saving client state [1276:259:0705/132703.039224:VERBOSE9:client_state_manager.cc(402)] Successfully saved client state [1276:259:0705/132703.041548:VERBOSE3:account.cc(177)] Successfully processed deposit for ad_notification with creative instance id d55f52f6-f02b-4808-b6e2-b2a7734ad836 and view valued at 0.01 [1276:259:0705/132703.041610:VERBOSE1:confirmations.cc(44)] Confirming view for ad_notification with transaction id 9cb0fefc-b428-453b-84ea-034fccc5fb95 and creative instance id d55f52f6-f02b-4808-b6e2-b2a7734ad836 [1276:259:0705/132703.043860:VERBOSE9:confirmation_state_manager.cc(84)] Saving confirmation state [1276:259:0705/132703.082491:VERBOSE9:confirmation_state_manager.cc(98)] Successfully saved confirmation state [1276:259:0705/132703.083411:VERBOSE1:confirmations.cc(84)] Successfully added view confirmation for ad_notification with transaction id 9cb0fefc-b428-453b-84ea-034fccc5fb95 and creative instance id d55f52f6-f02b-4808-b6e2-b2a7734ad836 to the queue [1276:259:0705/132703.084180:VERBOSE1:confirmations.cc(95)] Process view confirmation for ad_notification with transaction id 9cb0fefc-b428-453b-84ea-034fccc5fb95 and creative instance id d55f52f6-f02b-4808-b6e2-b2a7734ad836 in 0 hours, 0 minutes, 5 seconds at 13:27:08.083``` ``` Screen Shot 2024-07-05 at 1 34 28 PM
2. NTP ads - PASSED - Viewed an NTP SI in production env - Confirmed that users are rewarded for viewing NTP ads - Confirmed that NTP ads are displayed under ads history Example | Example | Example --------|------|----------- Screen Shot 2024-07-05 at 2 17 18 PM | Screen Shot 2024-07-05 at 2 18 24 PM | Screen Shot 2024-07-05 at 2 18 27 PM
3. Inline content ads - PASSED - Viewed inline content ads by enabling Brave news - Confirmed that user are rewarded for viewing inline content ads - Confirmed that inline content ads are displayed under ads history panel Example | Example ----------|---------- Screen Shot 2024-07-05 at 1 48 59 PM | Screen Shot 2024-07-05 at 1 49 31 PM ``` [1940:259:0705/134850.573352:VERBOSE1:confirmations.cc(44)] Confirming view for inline_content_ad with transaction id eb31e53f-0089-47b7-b147-f7da00d80b1d and creative instance id 65e86c2c-9877-413b-a3b6-787d1c9d3d97 [1940:259:0705/134850.574404:VERBOSE1:text_classification_model.cc(78)] No text classification probabilities found for en_US locale [1940:259:0705/134850.615951:VERBOSE1:confirmations.cc(84)] Successfully added view confirmation for inline_content_ad with transaction id eb31e53f-0089-47b7-b147-f7da00d80b1d and creative instance id 65e86c2c-9877-413b-a3b6-787d1c9d3d97 to the queue [1940:259:0705/134850.616722:VERBOSE1:confirmations.cc(95)] Process view confirmation for inline_content_ad with transaction id eb31e53f-0089-47b7-b147-f7da00d80b1d and creative instance id 65e86c2c-9877-413b-a3b6-787d1c9d3d97 in 0 hours, 0 minutes, 5 seconds at 13:48:55.615 ``` Screen Shot 2024-07-05 at 1 50 26 PM
4. Search ads - PASSED To trigger a search ad use: `https://search.brave.software/search?q=chainlink` The credentials are in 1password. The server is linked to ads staging server. - Users are not rewarded for viewing search ads (need to check with @btlechowski ) - Confirmed that search ads are displayed under ads history panel Example | Example | Example | Example ----------|--------|-----------|---------- Screen Shot 2024-07-05 at 2 03 27 PM | Screen Shot 2024-07-05 at 2 03 32 PM | Screen Shot 2024-07-05 at 2 04 04 PM | Screen Shot 2024-07-05 at 2 04 08 PM ``` [2476:259:0705/140401.303618:VERBOSE1:confirmations.cc(104)] Successfully processed click confirmation for search_result_ad with transaction id 1f159eee-3c69-415f-90f7-12c641fc1896 and creative instance id c2f2dace-d356-4bce-b5c9-cae75f2bd2aa [2476:259:0705/140401.304998:VERBOSE1:refill_confirmation_tokens.cc(69)] No need to refill confirmation tokens as we already have 47 confirmation tokens which is above the minimum threshold [2476:259:0705/140401.306154:VERBOSE1:confirmations.cc(95)] Process landed confirmation for search_result_ad with transaction id e871f455-5c9a-451f-b216-ff5a3e38114d and creative instance id c2f2dace-d356-4bce-b5c9-cae75f2bd2aa in 0 hours, 0 minutes, 5 seconds at 14:04:06.305 [2476:259:0705/140358.101331:VERBOSE1:confirmations.cc(84)] Successfully added landed confirmation for search_result_ad with transaction id e871f455-5c9a-451f-b216-ff5a3e38114d and creative instance id c2f2dace-d356-4bce-b5c9-cae75f2bd2aa to the queue ``` Screen Shot 2024-07-05 at 2 09 17 PM
Verify omnibox UI and functionality - PASSED **Omnibox:** - Confirmed that info bar color looks as expected in light theme - Confirmed that info bar color looks as expected in Dark theme - Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected - Confirmed that the icons in the URL bar works as expected Light theme | Dark theme | Suggestions --------------|--------------|-------------- Screen Shot 2024-07-03 at 10 09 35 PM | Screen Shot 2024-07-03 at 10 09 07 PM | Screen Shot 2024-07-03 at 10 16 07 PM
Verify default search engine functionality - PASSED ### US (United States) locale
Clean Profile - PASSED * ensured that `Brave` was selected as the default for both Normal/Private windows via `brave://settings/search` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Brave` was selected as the default via `brave://settings/searchEngines` **`Example`** | **`Example`** | **`Example`** | **`Example`** ---------------|-----------------|---------------|---------- Screen Shot 2024-07-04 at 12 16 22 AM | Screen Shot 2024-07-04 at 12 16 31 AM | Screen Shot 2024-07-04 at 12 16 46 AM | Screen Shot 2024-07-04 at 12 17 19 AM
Updated Profile (Google/Google, modified SE) - PASSED * installed `1.48.171` * ensured that `Brave` was the default SE selected under `brave://settings/search` for Normal Windows * changed `Brave` to `Google` for default SE for Normal Windows * changed `Brave` to `Google` for default SE for Private Windows * updated to `1.68.111` and ensured that `Google` is still the default SE in both Normal and Private windows SE * ensured that it wasn't replaced by `Brave` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows **`1.48.171`** | **`1.48.171`** -------------|--------------- Screen Shot 2024-07-05 at 12 23 32 PM | Screen Shot 2024-07-05 at 12 23 39 PM **`1.68.111`** | **`1.68.111`** | **`1.68.111`** -------------|-------------|---------- Screen Shot 2024-07-05 at 12 24 50 PM | Screen Shot 2024-07-05 at 12 25 04 PM | Screen Shot 2024-07-05 at 12 25 34 PM | Screen Shot 2024-07-05 at 12 25 44 PM
Updated Profile (Startpage/DDG - modified SE) - PASSED * installed `1.48.171` * Selected `Startpage` as the default SE selected under `brave://settings/search` for Normal Windows * Change `Brave` to `DDG` as the default SE for Private Windows * updated to `1.68.111` and ensured that previously selected SE is still the default for both Normal and Private windows * Normal Windows = `Startpage` and Private Windows = `DDG` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Brave` was the first engine via the list under `brave://settings/searchEngines` **`1.48.x`** | **`1.48.x`** ------------|------------ Screen Shot 2024-07-05 at 12 34 01 PM | Screen Shot 2024-07-05 at 12 34 13 PM **`1.68.111`** | **`1.68.111`** | **`1.68.111`** | **`1.68.111`** ------------|------------|---------------|-------- Screen Shot 2024-07-05 at 12 31 07 PM | Screen Shot 2024-07-05 at 12 31 18 PM | Screen Shot 2024-07-05 at 12 31 34 PM | Screen Shot 2024-07-05 at 12 31 42 PM
### Poland locale
Clean Profile - PASSED * ensured that `Google` was selected as the default for Normal windows and `Brave` was selected as the default for Private windows via `brave://settings/search` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Google` was selected as the default via `brave://settings/searchEngines` and `Brave` was listed first **`Example`** | **`Example`** | **`Example`** | **`Example`** ---------------|-----------------|---------------|--------------- Zrzut ekranu 2024-07-5 o 11 47 38 | Zrzut ekranu 2024-07-5 o 11 47 47 | Zrzut ekranu 2024-07-5 o 11 47 57 | Zrzut ekranu 2024-07-5 o 11 48 05
Updated Profile (Google/Brave, modified SE) - PASSED * installed `1.48.171` * ensured that `Google` was the default SE selected under `brave://settings/search` for normal windows * changed default SE for Private windows from `Brave` to `Google` * updated to `1.68.111` and ensured that `Google` is still the default SE in both Normal and Private window SE * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Brave` was the first engine via the list under `brave://settings/searchEngines` **`1.48.171`** | **`1.48.171`** ------------|--------------- Zrzut ekranu 2024-07-5 o 12 43 51 | Zrzut ekranu 2024-07-5 o 12 43 58 **`1.68.111`** | **`1.68.111`** | **`1.68.111`** | **`1.68.111` *** ----------------|----------------|--------------|---------------- Zrzut ekranu 2024-07-5 o 12 46 20 | Zrzut ekranu 2024-07-5 o 12 46 45 | Zrzut ekranu 2024-07-5 o 12 47 01 | Zrzut ekranu 2024-07-5 o 12 47 12

Ensure that supported MV2 extensions continue to load and run as expected - PASSED Screen Shot 2024-07-05 at 9 45 57 AM Note: The `Adblock` and `Adblock Plus` extensions are NOT working on both Brave and Chrome, which is fine as per the comments https://bravesoftware.slack.com/archives/C7VLGSR55/p1719861726168549?thread_ts=1719836286.009949&cid=C7VLGSR55
NoScript ™️ - PASSED 1. clean profile 2. opened `brave://settings/extensions/v2` 3. toggled `Enable NoScript ™️ ` to `Enabled`/`On` 4. clicked `Add extension` on the confirmation dialog 5. pinned to the browser toolbar 6. loaded `twitch.tv` 7. confirmed scripts were blocked (no content showing) 8. disabled Brave Shields (content still blocked) 9. clicked on `Trusted` for `Twitch.tv` 10. clicked on `Reload` ### Confirmed the site loaded with its scripts intact example | example | example | example | example | example ---------|---------|----------|----------|----------|--------- Screen Shot 2024-07-05 at 9 50 25 AM | Screen Shot 2024-07-05 at 10 33 59 AM | Screen Shot 2024-07-05 at 10 34 53 AM | Screen Shot 2024-07-05 at 10 37 17 AM | Screen Shot 2024-07-05 at 10 37 22 AM | Screen Shot 2024-07-05 at 10 37 33 AM
uBlock Origin ™️ - PASSED 1. new profile 2. installed `Ublock origin` extension from `brave://settings/extensions/v2` 13. Open cnn.com and disable the shield for cnn.com 14. Reload cnn.com 15. Confirmed that ads are blocked on the site cnn.com and ensured that `Ublock origin` extension works as expected 16. Open brave 17. Open cnn.com and disable shield for cnn.com 18. Ensured that Ads are NOT blocked as expected (as shield is disabled on cnn.com and there are no Adblock extensions installed) 19. Open a new site (e.g nytimes.com) in a new-tab page (new profile) 20. Disable shields for nytimes.com 21. Reload nytimes.com 22. Confirmed that ads are blocked on the site nytimes.com and ensured that `Ublock origin` extension works as expected 23. Open nytimes.com in a new-tab page (new profile) 24. Disable shields for nytimes.com and reload nytimes.com 25. Ensured that Ads are NOT blocked as expected (as shield is disabled on nytimes.com and there are no Adblock extensions installed) step 5 | step 8 | step 12 | step 15 -------|---------|---------|--------- Screen Shot 2024-07-04 at 3 30 54 PM | Screen Shot 2024-07-04 at 3 40 35 PM | Screen Shot 2024-07-04 at 3 44 47 PM | Screen Shot 2024-07-04 at 3 49 51 PM
uMatrix ™️ - PASSED 1. clean profile 3. opened `brave://settings/extensions/v2` 4. toggled `Enable uMatrix ™️ ` to `Enabled`/On` 5. clicked `Add extension` on the confirmation dialog 6. pinned to the browser toolbar 7. loaded `usatoday.com` 8. confirmed scripts were blocked (no content showing) 9. disabled Brave Shields (content still blocked) 10. clicked on the `uMatrix` extensions icon ### Confirmed the site loaded with its ad-blocking scripts working example | example | example | example ---------|----------|---------|---------- Screen Shot 2024-07-05 at 11 08 41 AM | Screen Shot 2024-07-05 at 11 10 48 AM | Screen Shot 2024-07-05 at 11 11 11 AM | Screen Shot 2024-07-05 at 11 12 00 AM
AdGuard ™️ - PASSED 1. new profile 3. opened `brave://settings/extensions/v2` 4. clicked on `Enable AdGuard ™️ ` to toggle it to `On/`Enabled` 5. clicked on `Add extension` on the confirmation dialog 6. waited for the extension to install and auto-configure 7. loaded `sfgate.com` 8. confirmed ads were blocked 9. disabled `Brave Shields` ### Confirmed ads were blocked via `AdGuard ™️ ` example | example | example | example | example ---------|----------|---------|---------|---------- Screen Shot 2024-07-05 at 10 52 50 AM | Screen Shot 2024-07-05 at 10 53 23 AM | Screen Shot 2024-07-05 at 10 55 19 AM | Screen Shot 2024-07-05 at 10 53 36 AM | Screen Shot 2024-07-05 at 10 53 48 AM

Settings comparison

1. New settings `Manifest v2 extensions` is added as part of Brave via `brave://settings/extensions` Example | Example ----------|--------- Screen Shot 2024-07-03 at 10 37 18 PM | Screen Shot 2024-07-03 at 10 35 28 PM 11. A new content settings `Automatic full screen` is added via `brave://settings/content` as part of `CR127` example | example ---------|--------- Screen Shot 2024-07-03 at 10 38 41 PM | Screen Shot 2024-07-03 at 10 38 45 PM

Brave startup calls

hffvld commented 3 months ago

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP31.240517.031 release-keys
Brave build: 1.68.115
Chromium: 127.0.6533.26 (Official Build) beta (64-bit) 

1 2
1 2
hffvld commented 3 months ago

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.68.115
Chromium: 127.0.6533.26 (Official Build) beta (64-bit) 

1 2
1 2
hffvld commented 3 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.68 (115)
BraveCore: 1.68.115 (127.0.6533.26)

1 2
1 2
btlechowski commented 3 months ago

Verified with

Brave 1.68.115 Chromium: 127.0.6533.26 (Official Build) beta (64-bit)
Revision eb9eb125805c393d370bb000a19164da9f344726
OS Linux
Verify hamburger menu UI, icons, items, ordering - PASSED - Verified the side panel testing in `Settings comparison` section below -
Verify tab UI, style, and functionality (rearranging tabs, tearing off tabs, vertical tabs, tab groups, etc.) - PASSED **Horizontal tabs view:** Confirmed that tabs drag and drop works as expected for Horizontal tabs ![image](https://github.com/brave/brave-browser/assets/34715963/792e2e8b-da0e-4f1c-a8a7-4e1e8cdc764f) **Vertical tabs view:** Confirmed that tabs drag and drop works as expected for Vertical tabs ![image](https://github.com/brave/brave-browser/assets/34715963/df6777a2-763f-4f40-92bd-5a2cb1f98fd0) **Tab groups** - Confirmed tab groups works as expected ![image](https://github.com/brave/brave-browser/assets/34715963/d37ec9d6-2ab0-4271-a337-dbf28aa6bcd8) **Tab shapes:** - Confirmed that Tab shapes are shown as expected in `Card` tab type - Confirmed that Tab shapes are shown as expected in `Card with preview` tab type - Confirmed that Tab shapes are shown as expected in `Tooltip` tab type Card | Card with preview | Tooltip --------------|--------------|-------------- ![image](https://github.com/brave/brave-browser/assets/34715963/f5b1ec45-2632-4628-b9e9-f3a7412c1e98)|![image](https://github.com/brave/brave-browser/assets/34715963/76ca26f2-a78d-417a-9f26-b65aa323e08f)|![image](https://github.com/brave/brave-browser/assets/34715963/720af995-53b0-4d12-b909-5459f4d8c2f8) **active/inactive tab colors:** - Confirmed that active/inactive tab colors are shown as expected
Verify tab search UI and functionality - PASSED - Confirmed that all the opened/closed tabs are opened via Tab search panel - Confirmed that user can see recently closed tabs via Tab search panel - Confirmed that user can search specific site via Tab search panel - Confirmed that user can close the specific tab via Tab search panel ![image](https://github.com/brave/brave-browser/assets/34715963/6a736a60-ca07-4345-bd4c-ef8188f40019)|![image](https://github.com/brave/brave-browser/assets/34715963/423daf23-a5f5-4d33-98c7-14099026115f) --|--
Verify clear browsing data functionality - PASSED - Confirmed that browser data can be deleted via hamburger settings menu `Delete browsing data` or via brave://settings/privacy `Delete browsing data` - Click on `Delete browsing data` opens up the `Delete browsing data` popup modal ![image](https://github.com/brave/brave-browser/assets/34715963/e272c8eb-794f-4471-b2ed-292501406031) - Confirmed that user can delete the browsing data
Verify all side-panel related functionality - PASSED - Verified the side panel testing in `Settings comparison` section below
Verify all toolbar related functionality - PASSED **Tab search** - Confirmed that `Tab search` toolbar icon is displayed as expected - Confirmed that all the opened/closed tabs are opened via Tab search panel - Confirmed that user can see recently closed tabs via Tab search panel - Confirmed that user can search specific site via Tab search panel - Confirmed that user can close the specific tab via Tab search panel ![image](https://github.com/brave/brave-browser/assets/34715963/84c58721-a23f-4b5a-9214-e48b464e294c) **Rewards**: - Confirmed that rewards BAT toolbar icon is displayed as expected - Confirmed that Rewards panel works as expected - Confirmed that publisher info is shown as expected on rewards panel - Confirmed that AC notification shown as expected on BR panel ![image](https://github.com/brave/brave-browser/assets/34715963/7ad6f3c3-8c8e-4779-8304-7ae6de08544a) **Shields** - Confirmed that shields toolbar icon is displayed as expected - Shield panel is shown as expected in normal view - Shield panel is shown as expected in advanced view - Shield panel is shown as expected disabled mode ![image](https://github.com/brave/brave-browser/assets/34715963/dff22004-61c1-4240-908d-73542c497b87) **Sidebar toolbar icon** - Confirmed that Sidebar toolbar icon is displayed as expected - Confirmed that click on sidebar icon displayed the sidebar panel as expected - Confirmed that icons on the sidebar panel works as expected ![image](https://github.com/brave/brave-browser/assets/34715963/ef475a36-76ac-4a86-9d16-511b62a1c314)|![image](https://github.com/brave/brave-browser/assets/34715963/3d11d983-79fd-483d-895d-87f2d6a8605a) --|-- **Wallet** - Confirmed that wallet toolbar icon is displayed as expected - Confirmed that click on wallet opens up the wallet modal popup - Confirmed that user can create wallet ![image](https://github.com/brave/brave-browser/assets/34715963/84d52a73-2964-4039-a431-5eb228a3273b)|![image](https://github.com/brave/brave-browser/assets/34715963/aaefe21b-3abb-42fe-863d-2ef7dc33a9af) --|--
Verify profile-related functionality (creating new profiles, guest profiles, avatar selection, profile menu, etc.) - PASSED - Confirmed that user can create a new profile via `Hamburger menu->More tools->Add new profile` - Confirmed that user can pick different avatar for each profile - Confirmed that user can edit the profile name/avatar via profile manager - Confirmed that user can open the guest window via profile menu - Confirmed that user can open guest window via profile manager ![image](https://github.com/brave/brave-browser/assets/34715963/47905fee-0ac4-4e29-a62e-6a14b39d3225)|![image](https://github.com/brave/brave-browser/assets/34715963/84751493-7b63-4d07-82e4-7ef64e7faa35)|![image](https://github.com/brave/brave-browser/assets/34715963/09f326b7-0612-45cb-888d-1735acc663fe) --|--|--
Verify browser themes functionality and light/dark mode - PASSED - Confirmed that toolbar icons, settings, and omnibox looks as expected in `Light` theme - Confirmed that toolbar icons, settings, and omnibox looks as expected in `Dark` theme **Light theme** ![image](https://github.com/brave/brave-browser/assets/34715963/0a3cd3c7-d11e-450d-ab6d-e4cb24ef63da) **Dark theme** ![image](https://github.com/brave/brave-browser/assets/34715963/266c4f80-bb87-4bf5-a7c8-ad9a118fa7f0)
Verify page info functionality, specifically cookie-related info - PASSED **_Update the cookies setting_** 1. Open a `site A` and and click on the site-information icon and ensured that the third party cookies are blocked on the `site A` ![image](https://github.com/brave/brave-browser/assets/34715963/f4bb91e7-54f6-4c24-a0e1-e96e3ba1ff0c) 2. Go to `brave://settings/shields` and select `Block all cookies` ![image](https://github.com/brave/brave-browser/assets/34715963/444de6d5-fb26-4173-aa42-911ba68d3174) 3. Reload `site A` and click on the site information icon and ensured that the third party cookies are blocked on `site A` ![image](https://github.com/brave/brave-browser/assets/34715963/080a86a4-76ae-476c-a2a6-a7ffa6fdd1f9) 4. Open the `Shields` panel on `site A` and ensure that _global_ cookies settings are applied ![image](https://github.com/brave/brave-browser/assets/34715963/d1357df2-27de-4c3f-8fc7-b836fcbfe768) 5. Go to `brave://settings/shields` and select `Allow all cookies` ![image](https://github.com/brave/brave-browser/assets/34715963/5518fcc2-f386-4ed7-af0a-fa3b6ffe87e5) 6. Reload `site A` and click on the site-information icon and ensured that the cookies are allowed on the `site A` ![image](https://github.com/brave/brave-browser/assets/34715963/6fa27402-c3c0-4cfe-8e6f-da9234d5c6f2) 7. Open the `Shields` panel on `site A` and ensure that _global_ cookies settings are applied ![image](https://github.com/brave/brave-browser/assets/34715963/611572cb-5750-4a56-bcd1-54c095cef22c) **_Check Allow cookies functionality:_** 1. Clean profile 1.68.x 2. Go to `brave://settings/shields` 3. Change cookies settings to `Block all cookies` ![image](https://github.com/brave/brave-browser/assets/34715963/444de6d5-fb26-4173-aa42-911ba68d3174) 5. Open a site A 6. Open Shields panel and ensure that block all cookies settings selected in the dropdown ![image](https://github.com/brave/brave-browser/assets/34715963/d1357df2-27de-4c3f-8fc7-b836fcbfe768) 7. Click on site information on a Site A and ensure that all the cookies are blocked ![image](https://github.com/brave/brave-browser/assets/34715963/080a86a4-76ae-476c-a2a6-a7ffa6fdd1f9) 8. Go to `brave://settings/cookies` 9. Click on Add button and add a Site B to allow cookies list ![image](https://github.com/brave/brave-browser/assets/34715963/831d3f93-5810-4342-9a7a-8b0da0abf5ee) 9. Open site B in a NTP 10. Click on site information on a Site B and ensure that all the cookies are allowed as site B is added into allow cookies list in step 8 ![image](https://github.com/brave/brave-browser/assets/34715963/31aba0ce-0ceb-4141-9f22-725a234dd90a) 11. Open shield panel for site B 12. Ensured that global cookies settings are applied as expected ![image](https://github.com/brave/brave-browser/assets/34715963/c4c4ed6a-cca6-49dd-8e9e-d0458d4e79a0) Case 1: 1. Clean profile `1.68.x` 14. Open a site 15. Click on the site shield settings 16. Change the trackers and ad blocking settings from `Block third part cookies` to `Block all cookies` 17. Restart the browser 18. Open the site shield settings, confirmed updated cookies settings are retained Case 2: 1. Continuation of case 1 2. Open a site 6. Click on the site shield settings 10. Change the trackers and ad blocking settings from `Block all cookies` to `Allow all cookies` 11. Restart the browser 12. Open the site shield settings, confirmed updated cookies settings are retained Case 3: 1. Continuation of case 2 2. Open a site 4. Click on the site shield settings 5. Change the trackers and ad blocking settings from `Allow all cookies` to `Block third party site cookies` 6. Restart the browser 7. Open the site shield settings, confirmed updated cookies settings are retained
Verify ad notifications UI and functionality - PASSED
1. Notification ads - PASSED - Confirmed that notification ads are shown as expected - Confirmed that ad notification UI looks as expected - Confirmed that users are rewarded for viewing notification ads - Confirmed that notification ads are displayed under ads history ![image](https://github.com/brave/brave-browser/assets/34715963/bf0addc7-7023-4d9c-848c-1229441765eb)|![image](https://github.com/brave/brave-browser/assets/34715963/58700a97-0019-41f8-a4bb-3297d96e8b5c)|![image](https://github.com/brave/brave-browser/assets/34715963/613241c7-bb8c-4efe-944a-e3d5718c35d3) --|--|--
2. NTP ads - PASSED - Viewed an NTP SI in production env - Confirmed that users are rewarded for viewing NTP ads - Confirmed that NTP ads are displayed under ads history ![image](https://github.com/brave/brave-browser/assets/34715963/c465ab17-491b-4b14-9771-9f1add5d1b96)|![image](https://github.com/brave/brave-browser/assets/34715963/e0c151d6-9f31-46f7-92b5-100d541666d6)|![image](https://github.com/brave/brave-browser/assets/34715963/e2fc3e2d-2392-434a-a034-2e017942eb68) --|--|--
3. Inline content ads - PASSED - Viewed inline content ads by enabling Brave news - Confirmed that user are rewarded for viewing inline content ads - Confirmed that inline content ads are displayed under ads history panel ![image](https://github.com/brave/brave-browser/assets/34715963/ce007b7d-5bd8-48b5-af7d-37bd580eb52c)|![image](https://github.com/brave/brave-browser/assets/34715963/448f8586-151b-4ed9-b047-0aa4efffdbe6)|![image](https://github.com/brave/brave-browser/assets/34715963/a60a8a4d-082c-46fb-b0a3-d9150a3b0a27) --|--|--
4. Search ads - PASSED To trigger a search ad use: `https://search.brave.software/search?q=chainlink` The credentials are in 1password. The server is linked to ads staging server. ![image](https://github.com/brave/brave-browser/assets/34715963/46c48761-1284-4f12-aa96-b03eb69dcddd)|![image](https://github.com/brave/brave-browser/assets/34715963/47ce5dac-e32c-4c14-aea6-0e46d5d2fa9d)|![image](https://github.com/brave/brave-browser/assets/34715963/7a0a0afa-9ae3-4ee0-9865-2362d06f1c81) --|--|--
Verify omnibox UI and functionality - PASSED **Omnibox:** - Confirmed that info bar color looks as expected in light theme - Confirmed that info bar color looks as expected in Dark theme - Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected - Confirmed that the icons in the URL bar works as expected ![image](https://github.com/brave/brave-browser/assets/34715963/0a3cd3c7-d11e-450d-ab6d-e4cb24ef63da)|![image](https://github.com/brave/brave-browser/assets/34715963/266c4f80-bb87-4bf5-a7c8-ad9a118fa7f0)|![image](https://github.com/brave/brave-browser/assets/34715963/46fd5305-95bf-462b-85d3-f68d1838ebe6)|![image](https://github.com/brave/brave-browser/assets/34715963/6c8c9fca-75ab-4b17-8d9d-c2752322feef) --|--|--|--
Verify default search engine functionality - PASSED ### US (United States) locale
Clean Profile - PASSED * ensured that `Brave` was selected as the default for both Normal/Private windows via `brave://settings/search` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Brave` was selected as the default via `brave://settings/searchEngines` ![image](https://github.com/brave/brave-browser/assets/34715963/1c6176d9-d1bd-47ae-9624-ea14a399c5b4)|![image](https://github.com/brave/brave-browser/assets/34715963/42bc14dd-7128-4659-a227-5b80acb0096c)|![image](https://github.com/brave/brave-browser/assets/34715963/5673e479-1f89-4e9a-973b-cb3f40762f16) --|--|--
Updated Profile (Google/Google, modified SE) - PASSED * installed `1.48.171` * ensured that `Brave` was the default SE selected under `brave://settings/search` for Normal Windows * changed `Brave` to `Google` for default SE for Normal Windows * changed `Brave` to `Google` for default SE for Private Windows * updated to `1.68.x` and ensured that `Google` is still the default SE in both Normal and Private windows SE * ensured that it wasn't replaced by `Brave` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows ![image](https://github.com/brave/brave-browser/assets/34715963/e609bf67-55da-4e17-8f9a-42bd7e465413)|![image](https://github.com/brave/brave-browser/assets/34715963/e3a0cdb5-f3f6-4e6c-9218-c59b8d2655e6)|![image](https://github.com/brave/brave-browser/assets/34715963/050d0f1a-cb4c-4ca0-a737-ad6c61d54c7e) --|--|--
### Poland locale
Clean Profile - PASSED * ensured that `Google` was selected as the default for Normal windows and `Brave` was selected as the default for Private windows via `brave://settings/search` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Google` was selected as the default via `brave://settings/searchEngines` and `Brave` was listed first ![image](https://github.com/brave/brave-browser/assets/34715963/41331483-6bee-4c2f-a988-c69bedeaccc3)|![image](https://github.com/brave/brave-browser/assets/34715963/2dba8f8b-b2f9-45a9-bb6a-a2a320595903)|![image](https://github.com/brave/brave-browser/assets/34715963/15a694d1-7edf-4c9d-b718-7d3ad142112b) --|--|--
Updated Profile (Google/Brave, modified SE) - PASSED * installed `1.48.171` * ensured that `Google` was the default SE selected under `brave://settings/search` for normal windows * changed default SE for Private windows from `Brave` to `Google` * updated to `1.68.111` and ensured that `Google` is still the default SE in both Normal and Private window SE * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Brave` was the first engine via the list under `brave://settings/searchEngines` ![image](https://github.com/brave/brave-browser/assets/34715963/84bc5bb8-3fe3-48f4-80f5-4fe4cd9422ef)

Ensure that supported MV2 extensions continue to load and run as expected - PASSED ![image](https://github.com/brave/brave-browser/assets/34715963/ca0357d0-e3d7-4712-900c-eaeac3eff28d)
NoScript ™️ - PASSED 1. clean profile 2. opened `brave://settings/extensions/v2` 3. toggled `Enable NoScript ™️ ` to `Enabled`/`On` 4. clicked `Add extension` on the confirmation dialog 5. pinned to the browser toolbar 6. loaded `twitch.tv` 7. confirmed scripts were blocked (no content showing) 8. disabled Brave Shields (content still blocked) 9. clicked on `Trusted` for `Twitch.tv` 10. clicked on `Reload` ### Confirmed the site loaded with its scripts intact ![image](https://github.com/brave/brave-browser/assets/34715963/4dc98a12-53b4-4d91-9f13-08ae763f0341)|![image](https://github.com/brave/brave-browser/assets/34715963/2326c21d-deaf-4e8b-8f46-1aa8810d4ed8) --|--
uBlock Origin ™️ - PASSED 1. new profile 2. installed `Ublock origin` extension from `brave://settings/extensions/v2` 13. Open cnn.com and disable the shield for cnn.com 14. Reload cnn.com 15. Confirmed that ads are blocked on the site cnn.com and ensured that `Ublock origin` extension works as expected 16. Open brave 17. Open cnn.com and disable shield for cnn.com 18. Ensured that Ads are NOT blocked as expected (as shield is disabled on cnn.com and there are no Adblock extensions installed) 19. Open a new site (e.g nytimes.com) in a new-tab page (new profile) 20. Disable shields for nytimes.com 21. Reload nytimes.com 22. Confirmed that ads are blocked on the site nytimes.com and ensured that `Ublock origin` extension works as expected 23. Open nytimes.com in a new-tab page (new profile) 24. Disable shields for nytimes.com and reload nytimes.com 25. Ensured that Ads are NOT blocked as expected (as shield is disabled on nytimes.com and there are no Adblock extensions installed) ![image](https://github.com/brave/brave-browser/assets/34715963/33b2f1ed-941e-47f7-837e-0fedfd316282)|![image](https://github.com/brave/brave-browser/assets/34715963/f889ea70-51ad-40fe-80d3-7d85540bca5c)|![image](https://github.com/brave/brave-browser/assets/34715963/c1f62343-e5e1-4deb-8760-1ada9577e5b1) --|--|--
uMatrix ™️ - PASSED 1. clean profile 3. opened `brave://settings/extensions/v2` 4. toggled `Enable uMatrix ™️ ` to `Enabled`/On` 5. clicked `Add extension` on the confirmation dialog 6. pinned to the browser toolbar 7. loaded `usatoday.com` 8. confirmed scripts were blocked (no content showing) 9. disabled Brave Shields (content still blocked) 10. clicked on the `uMatrix` extensions icon ### Confirmed the site loaded with its ad-blocking scripts working ![image](https://github.com/brave/brave-browser/assets/34715963/9c66bb4a-f285-48fb-b052-b48ce554c594)
AdGuard ™️ - PASSED 1. new profile 3. opened `brave://settings/extensions/v2` 4. clicked on `Enable AdGuard ™️ ` to toggle it to `On/`Enabled` 5. clicked on `Add extension` on the confirmation dialog 6. waited for the extension to install and auto-configure 7. loaded `sfgate.com` 8. confirmed ads were blocked 9. disabled `Brave Shields` ### Confirmed ads were blocked via `AdGuard ™️ ` ![image](https://github.com/brave/brave-browser/assets/34715963/8cd41994-7820-4ccd-a50d-54015ce6c450)|![image](https://github.com/brave/brave-browser/assets/34715963/7ef0a7d4-7e6f-454e-a3ae-6098db5f076c) --|--

Settings comparison

1. New settings `Manifest v2 extensions` is added as part of Brave via `brave://settings/extensions` ![image](https://github.com/brave/brave-browser/assets/34715963/a8b278fe-08dc-409d-b82a-19418ceb8ab1) 11. A new content settings `Automatic full screen` is added via `brave://settings/content` as part of `CR127` ![image](https://github.com/brave/brave-browser/assets/34715963/e18bd31c-665a-4a01-ab6c-beb89a605c5d)
MadhaviSeelam commented 3 months ago

Verification PASSED using

Brave | 1.68.116 Chromium: 127.0.6533.26 (Official Build) beta (64-bit)
-- | --
Revision | 585ddd90c5c0f551af043be52184e86d1a8fce86
OS | Windows 11 Version 23H2 (Build 22631.3810)

image

kjozwiak commented 3 months ago

Labelling as QA/No & release-notes/exclude in favour of https://github.com/brave/brave-browser/issues/39668#issuecomment-2224859537.