brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.01k stars 2.21k forks source link

[Perf] 10.2% regression in youtube memory usage after cr127 #39456

Open atuchin-m opened 1 week ago

atuchin-m commented 1 week ago

https://brave-perf-dashboard.appspot.com/report?sid=b71ee830eebacc27e31bef999d1b93bdcd827ae6060577bc51541270cffb250b&start_rev=19580&end_rev=20026&rev=19985

Median of segment before: 145595597
Median of segment after: 160466227
Relative change: 10.2%
Test: BravePerf/mac-mini-x64-typical/system_health.memory_desktop/memory:chrome:browser_process:reported_by_os:private_footprint_size/load_media/load_media_youtube_2018

Chromium isn't affected

image
atuchin-m commented 5 days ago

The regression is a results of increasing max_committed_size, when allocated_object_size is stable: link It means it affects only the peak memory usage, but not long term.

atuchin-m commented 2 days ago

v1.69.46:

image

v1.69.51:

image