search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.7k stars 2.31k forks source link

Browser Crashed while dragging tab group out of current window #39486

Open jagadeshjai opened 3 months ago

jagadeshjai commented 3 months ago

Description

brave_crash_while_dragging_group.webm

Steps to reproduce

  1. Enable Splitview via brave://flags/#brave-split-view in Nightly build
  2. Open Browser and create a group with one or two tabs.
  3. Drag that group out of the window.

Actual result

Browser crashed while dragging Grouped tabs out of window.

Expected result

After dragging grouped tabs from the window, it can be attached to a new window or possibly can attach to existing another/same window.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.65 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit)

Channel information

Reproducibility

Miscellaneous information

No response

iefremov commented 3 months ago

@jagadeshjai can you please share what's on brave://crashes?

jagadeshjai commented 3 months ago

Stack trace:

FATAL:tab_strip_model.cc(270)] Check failed: ContainsIndex(index). 
#0 0x7b9d98778b72 base::debug::CollectStackTrace()
#1 0x7b9d98755c9e base::debug::StackTrace::StackTrace()
#2 0x7b9d98625cae logging::LogMessage::Flush()
#3 0x7b9d98625b91 logging::LogMessage::~LogMessage()
#4 0x7b9d985ff4f0 logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage()
#5 0x7b9d985ff54e logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage()
#6 0x7b9d985ff1f3 logging::CheckError::~CheckError()
#7 0x63679e84e025 TabStripModel::GetTabHandleAt()
#8 0x63679c2a281c TabDragController::DetachAndAttachToNewContext()
#9 0x63679eefcb2b TabDragControllerChromium::DetachIntoNewBrowserAndRunMoveLoop()
#10 0x63679eefc42e TabDragControllerChromium::DragBrowserToNewTabStrip()
#11 0x63679eefac39 TabDragControllerChromium::ContinueDragging()
#12 0x63679c2a361a TabDragController::ContinueDragging()
#13 0x63679eef60e1 TabDragControllerChromium::Drag()
#14 0x63679ef4115f TabStrip::TabDragContextImpl::ContinueDrag()
#15 0x63679ef44d3f TabStrip::TabDragContextImpl::OnMouseDragged()
#16 0x7b9d8e1b4c2e views::View::ProcessMouseDragged()
#17 0x7b9d92d06d6b ui::EventDispatcher::DispatchEvent()
#18 0x7b9d92d06466 ui::EventDispatcher::ProcessEvent()
#19 0x7b9d92d06017 ui::EventDispatcherDelegate::DispatchEventToTarget()
#20 0x7b9d92d05cd6 ui::EventDispatcherDelegate::DispatchEvent()
#21 0x7b9d8e1cb2b0 views::internal::RootView::OnMouseDragged()
#22 0x7b9d8e1dde45 views::Widget::OnMouseEvent()
#23 0x7b9d8e233718 views::DesktopNativeWidgetAura::OnMouseEvent()
#24 0x7b9d92d06d6b ui::EventDispatcher::DispatchEvent()
#25 0x7b9d92d06466 ui::EventDispatcher::ProcessEvent()
#26 0x7b9d92d06017 ui::EventDispatcherDelegate::DispatchEventToTarget()
#27 0x7b9d92d05cd6 ui::EventDispatcherDelegate::DispatchEvent()
#28 0x7b9d92d085b5 ui::EventProcessor::OnEventFromSource()
#29 0x7b9d92d098ec ui::EventSource::DeliverEventToSink()
#30 0x7b9d92d097d2 ui::EventSource::SendEventToSinkFromRewriter()
#31 0x7b9d8fd3219d aura::WindowTreeHostPlatform::DispatchEvent()
#32 0x7b9d8e237196 views::DesktopWindowTreeHostLinux::DispatchEvent()
#33 0x7b9d92d12758 base::OnceCallback<>::Run()
#34 0x7b9d92d12524 ui::DispatchEventFromNativeUiEvent()
#35 0x7b9d98b641d1 ui::X11Window::DispatchUiEvent()
#36 0x7b9d98b63d8d ui::X11Window::DispatchEvent()
#37 0x7b9d98b6432d ui::X11Window::DispatchEvent()
#38 0x7b9d8c4d9edf ui::PlatformEventSource::DispatchEvent()
#39 0x7b9d88d5a4f0 ui::X11EventSource::OnEvent()
#40 0x7b9d8ced8b62 x11::Connection::DispatchEvent()
#41 0x7b9d8ced8743 x11::Connection::ProcessNextEvent()
#42 0x7b9d8ced8349 x11::Connection::Dispatch()
#43 0x7b9d88d5f822 ui::(anonymous namespace)::XSourceDispatch()
#44 0x7b9d8731bc44 g_main_context_dispatch
#45 0x7b9d873712b8 (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7200.4+0xab2b7)
#46 0x7b9d873193e3 g_main_context_iteration
#47 0x7b9d9879f141 base::MessagePumpGlib::Run()
#48 0x7b9d986e7dcf base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#49 0x7b9d9867cd1c base::RunLoop::Run()
#50 0x7b9d96955f17 content::BrowserMainLoop::RunMainMessageLoop()
#51 0x7b9d96958ad5 content::BrowserMainRunnerImpl::Run()
#52 0x7b9d96952416 content::BrowserMain()
#53 0x7b9d97931c57 content::RunBrowserProcessMain()
#54 0x7b9d97934746 content::ContentMainRunnerImpl::RunBrowser()
#55 0x7b9d97933de8 content::ContentMainRunnerImpl::Run()
#56 0x7b9d97930489 content::RunContentProcess()
#57 0x7b9d979306f2 content::ContentMain()
#58 0x63679b0153eb ChromeMain
#59 0x7b9d81629d90 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x29d8f)
#60 0x7b9d81629e40 __libc_start_main
#61 0x63679b01502a _start
LaurenWags commented 1 month ago

+1 from https://github.com/brave/brave-browser/issues/40739