brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

[Wallet] Some Solana NFTs are incorrectly grouped #39500

Closed josheleonard closed 4 months ago

josheleonard commented 4 months ago

Description

We are currently using token symbols to group Solana NFTs, which can lead to unrelated NFTs being grouped together

Steps to reproduce

  1. Add multiple Solana NFTs to your wallet that have the same token symbol, but are from different collections
  2. view the portfolio NFTs page
  3. enable the group-by-collection option in the NFT filters

Actual result

Solana NFTs with the same token symbol will be grouped into a single collection

Expected result

Solana NFTs should be grouped by collection name

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.65 Chromium: 127.0.6533.26 (Official Build) nightly (arm64)

Channel information

Reproducibility

Miscellaneous information

No response

srirambv commented 3 months ago

Verification passed on

Brave 1.69.136 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
Revision 47255350e0d135b2172cb9dd2ba344d3d7fe4572
OS Windows 11 Version 23H2 (Build 22631.3880)

https://github.com/user-attachments/assets/0b58851a-7758-436d-aa46-b7bbb5216aca