search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

[ads] Do not classify page content for same document navigations #39506

Closed tmancey closed 3 months ago

tmancey commented 4 months ago

Description

NOTE: We SHOULD still classify page content for initial page load

btlechowski commented 3 months ago

Verified with

Brave 1.69.129 Chromium: 127.0.6533.73 (Official Build) beta (64-bit)
Revision 0ab2f25cd017b563fd72d68048f809659a351a04
OS Linux

Verified test plan from https://github.com/brave/brave-core/pull/24568

multi-page navigation

#### page classifier Verified page is classified on each navigation 1st navigation: ``` [3415:3415:0801/194326.999436:VERBOSE1:text_classification_processor.cc(68)] Classified text with the top segment as technology & computing-software ``` 2nd navigation ``` [3415:3415:0801/194423.430387:VERBOSE1:text_classification_processor.cc(68)] Classified text with the top segment as crypto-crypto ``` #### conversion ``` ```

single-page navigation

#### page classifier on first view ``` [3415:3415:0801/194634.742189:VERBOSE1:text_classification_processor.cc(68)] Classified text with the top segment as pets-birds ``` Verified subsequent navigation does not trigger page classifier #### conversion ``` ```
btlechowski commented 2 months ago

Verification passed on Brave v1.69.145 on Lenovo TB-8506FS (Android 11.0)

Verified test plan from https://github.com/brave/brave-core/pull/24568

multi-page navigation

#### page classifier Verified page is classified on each navigation 1st navigation: ``` 04:17:42.353 V [VERBOSE1:text_classification_processor.cc(68)] Classified text with the top segment as technology & computing-software ``` 2nd navigation ``` 04:18:32.005 V [VERBOSE1:text_classification_processor.cc(68)] Classified text with the top segment as technology & computing-software ```

single-page navigation

#### page classifier on first view ``` 04:20:03.691 V [VERBOSE1:text_classification_processor.cc(68)] Classified text with the top segment as pets-birds ``` Verified subsequent navigation does not trigger page classifier