brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.63k stars 2.3k forks source link

Edit custom search engines #39552

Closed soner-yuksel closed 2 months ago

soner-yuksel commented 3 months ago

Description

We dont have edit functionality for custom search engines. We have add and delete but there is edit. This issue is mentioned in ios channel, creating a follow up issue.

The Add screen can be used for Edit functionality and swipe action can be added next to delete swipe action.

Steps to reproduce

  1. Open Settings - SearchEngines
  2. Try to edit a custom search Engine

Actual result

The custom search engines are editable.

Expected result

They should be editable and the functionality should be added to swipe actions.

2123321

Reproduces how often

Easily reproduced

Brave version

1.67

Device/iOS version

Any

Affected browser versions

hffvld commented 1 week ago

Verified on iPhone 14 and iPad Mini (6th gen) using version(s):

Device/OS:
- iPhone 14 / iOS 17.7
- iPad Mni (6th gen) / iPadOS 18
Brave build: 1.70 (117)
BraveCore: 1.70.117 (129.0.6668.59)

Filed follow-up issue #41210 and #41228

STEPS:

  1. Launch Brave
  2. Hamburger menu > Settings
  3. Search Engines > Add Custom Search Engine
  4. In URL type https://youtube.com/search?q=%s and in Title type YT > Done
  5. Slide the newly created SE to the left > Verify Edit button exists
  6. Tap Edit > Update the URL / Title > Save the changes by tapping the button in the top right corner

ACTUAL RESULTS:


iPhone 14 / iOS 17.7

1 2 3 4 5
1 2 3 4 5

iPad Mni (6th gen) / iPadOS 18

1 2 3 4 5
1 2 3 4 5