Location bar button is not squircle when permission bubble is shown

simonhong commented 3 months ago

Description

Get notifications? button doesn't have our radius and bg color

Left(cr127) vs. right(cr126)

Steps to reproduce

Load https://www.bennish.net/web-notifications.html
Click Authorize

Actual result

See the above screen shot

Expected result

It should have our radius and bg color

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.76 Chromium: 127.0.6533.26 (Official Build) nightly (x86_64)

Channel information

[X] release (stable)
[X] beta
[X] nightly

Reproducibility

[ ] with Brave Shields disabled
[ ] with Brave Rewards disabled
[ ] in the latest version of Chrome

Miscellaneous information

Note: stable/beta 's bg color seems fine. nightly has different bg color. cc @rebron @brave/qa-team

simonhong commented 3 months ago

checking now.

kjozwiak commented 3 months ago

The above requires 1.68.118 or higher for 1.68.x verification 👍

LaurenWags commented 3 months ago

Verified with

Brave | 1.68.118 Chromium: 127.0.6533.26 (Official Build) beta (x86_64)
-- | --
Revision | 2863b4f7f2c566e828c816caafbc2a2ce5fb527f
OS | macOS Version 13.6.7 (Build 22G720)

Encountered https://github.com/brave/brave-browser/issues/39719 while testing.

Reproduced the issue using 1.68.115.

Using 1.68.118, confirmed the Get notifications? button and subsequent "Allowed" or "Blocked" button is now our "squircle" shape. Using 1.68.118, confirmed the blueish tint is removed.