brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

No Confirm Dialog on Exit With Multiple Tabs #39607

Open issuant opened 2 months ago

issuant commented 2 months ago

Description

Unlike with Brave desktop, there's no confirm dialog when you tap the exit button which is very likely to happen accidentally with its awful positioning (#39374). This is a terrible experience when in incognito mode.

Steps to reproduce

  1. Open multiple tabs
  2. Open the 3-dot menu and tap the exit button
  3. Notice no confirm dialog shows up before Brave exits

Actual result

Android Brave exits without throwing up a confirm dialog.

Expected result

Android Brave should show an exit confirm dialog before exiting just like desktop Brave. At the very least, there should be an option to turn this on just like on desktop.

Reproduces how often

Easily reproduced

Brave version

All

Device

Channel information

Reproducibility

Miscellaneous information

No response

issuant commented 2 months ago

@deeppandya @tapanmodh

deeppandya commented 2 months ago

@issuant thank you for the issue. I am going to add the issue for discussion and I will set the priority based on it.