brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.43k stars 2.26k forks source link

New Theme Color Picker Sucks #39629

Open NickTheOnlyNeko opened 1 month ago

NickTheOnlyNeko commented 1 month ago

Description

with all due respect the new color picker sucks, please revert it back to the old version

New: image

Old: image

i like darker tones of certain colors and the "New" color picker sucks to the point of making me want to throw up, you've got it perfectly with the old Version why in hells name did any of you had the need to fck around with it???, if it ain't broke don't FCKING FCK WITH IT!

Steps to reproduce

image then image

Actual result

get rid of the new and get the old one back

Expected result

to get the old Theme Color Picker back

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave: 1.69(Nice!).xx

Channel information

Reproducibility

Miscellaneous information

No response

luzhkovvv commented 1 month ago

It does not need fixing upstream, it's just broken in Brave. In Chrome, you pick the accent color, and the actual interface color is determined both by the color picker and the light/dark switch (dark gets a darker version of the selected color, and light gets a lighter version). In Brave you always get light color, and if you use a dark appearance and color-pick, you end up with weird light panels around dark page content. Brave (with Appearance->Brave colours = Dark) image Chrome (with Appearance->Mode = Dark) image