brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.99k stars 2.36k forks source link

New Theme Color Picker Sucks #39629

Open NickTheOnlyNeko opened 4 months ago

NickTheOnlyNeko commented 4 months ago

Description

with all due respect the new color picker sucks, please revert it back to the old version

New: image

Old: image

i like darker tones of certain colors and the "New" color picker sucks to the point of making me want to throw up, you've got it perfectly with the old Version why in hells name did any of you had the need to fck around with it???, if it ain't broke don't FCKING FCK WITH IT!

Steps to reproduce

image then image

Actual result

get rid of the new and get the old one back

Expected result

to get the old Theme Color Picker back

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave: 1.69(Nice!).xx

Channel information

Reproducibility

Miscellaneous information

No response

luzhkovvv commented 4 months ago

It does not need fixing upstream, it's just broken in Brave. In Chrome, you pick the accent color, and the actual interface color is determined both by the color picker and the light/dark switch (dark gets a darker version of the selected color, and light gets a lighter version). In Brave you always get light color, and if you use a dark appearance and color-pick, you end up with weird light panels around dark page content. Brave (with Appearance->Brave colours = Dark) image Chrome (with Appearance->Mode = Dark) image

tatof commented 2 months ago

Just changed some options and lost my original picked color. Now i'm stuck with this terrible color picker and i can't get my old color back.

is there a config file that i could change with my RGB or HEX color?

NickTheOnlyNeko commented 2 months ago

Just changed some options and lost my original picked color. Now i'm stuck with this terrible color picker and i can't get my old color back.

is there a config file that i could change with my RGB or HEX color?

To get the Hex editor or color picker you'll most likely need to download from Github an old release that still has the old theme and color picker and which from there you can sync the old version through the Brave Sync and then you can change the colors through the old version

Basically: Download an Old Version of Brave from Github > Sync the old version with "Brave Sync" and make sure that it's set to "Sync themes" or "Sync Everything" on both browsers > close the "new/current updated Brave version" > open the old Brave version and change the theme from there with the old color picker, once done you can close the old version and launch the new version and they should have synchronized together and you should have the custom theme from the Old Version of Brave on the new version of Brave👍

tatof commented 2 months ago

haha, oke thanks. That's a lot to only change the theme color. 😂

Doesn anyone know where the color is saved in the config files? Somewhere here %appdata%\Local\BraveSoftware\Brave-Browser\User Data