brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

[Follow up to #36112] Tapping `tooltip` is enabling/disabling the toggle switch on Leo's UI #39654

Open hffvld opened 3 months ago

hffvld commented 3 months ago

Description

Follow-up to #36112.

Steps to reproduce

  1. Launch Brave
  2. Go to any website
  3. Open Leo
  4. In Shape answers based on the page's contents tap the tooltip > Observe the toggle switch is disabled/enabled

Actual result

Shape answers based on the page's contents toggle switch is getting enabled/disabled by tapping the tooltip.


https://github.com/brave/brave-browser/assets/128532965/76f498b9-ac2d-423e-9a11-f15d5d551957

Expected result

Shape answers based on the page's contents toggle switch must not be enabled/disabled by tapping the tooltip.


https://github.com/brave/brave-core/pull/23460#issuecomment-2101039371

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.68.110 Chromium: 127.0.6533.26 (Official Build) beta (64-bit)

Device

Channel information

Reproducibility

Miscellaneous information

No response

stephendonner commented 3 months ago

Same on desktop:

example example
image image
Brave | 1.69.96 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit)
-- | --
Revision | 25973a147e9d4ea0cd7b27c49f55792640a3b827
OS | Windows 10 Version 22H2 (Build 19045.4651)