Closed LorenzoMinto closed 2 weeks ago
The button will still open the SideBar, for now at least, and respect the user's sidebar settings on close. The button will Toggle Leo open or closed. I experimented with the button being highlighted if the Leo panel is showing, but it made the toolbar look like an airplane cockpit given the Sidebar button also highlights (see below), so I'll remove that for now
The above requires 1.69.147
or higher for 1.69.x
verification 👍
Verified with
Brave | 1.69.149 Chromium: 128.0.6613.40 (Official Build) (x86_64)
-- | --
Revision | a6a137ec4f7f0b30e1d3940dbfcde72c32d35baa
OS | macOS Version 13.6.9 (Build 22G830)
Verified test cases listed via https://github.com/brave/brave-browser/issues/39713#issue-2405160230:
Case for "Toolbar button, menu item and quick command do not show up when Windows policy disables it" will be checked separately by @GeetaSarvadnya on Windows.
Verification PASSED on
Brave | 1.69.149 Chromium: 128.0.6613.40 (Official Build) (64-bit)
-- | --
Revision | a6a137ec4f7f0b30e1d3940dbfcde72c32d35baa
OS | Windows 10 Version 22H2 (Build 19045.4780)
Description
We’ve received a lot feedback around “Not being able to find Leo”. And once found, user might find it hard to dismiss it or bring it back into view because of the unfamiliarity with the sidebar element. If we want Leo to be a prominent browser feature we should give it proper placement and make it a feature with one-click access. In the longer term this could become the general access to Browser AI features (not just chat). Note that this placement would not have the risk to conflict with the Search AI feature as it’s not directly related to a query or to search real estate (omnibox)
Clicking the Leo tool would open the Leo panel, preferably without the sidebar component.
Test Plan
Toolbar button opens panel
Toolbar button closes panel
Toolbar button switches panel
Same as above for menu item
Repeat previous tests but instead of toolbar button, use the menu item
Same as above for quick command
Repeat previous tests but instead of toolbar button, use the quick command "Toggle Leo"
Toolbar button, menu item and quick command do not show up in private window
Toolbar button, menu item and quick command do not show up when feature flag is disabled
Toolbar button, menu item and quick command do not show up when Windows policy disables it