brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.43k stars 2.25k forks source link

`if you are not sure` should read `if you're not sure` in tooltip for Server endpoint URL in BYOM #39729

Closed stephendonner closed 1 month ago

stephendonner commented 1 month ago

Description

if you are not sure should read if you're not sure in tooltip for Server endpoint URL in BYOM

Found while testing https://github.com/brave/brave-browser/issues/38646

Steps to reproduce

  1. install 1.69.101
  2. launch Brave
  3. open brave://settings/leo-assistant
  4. click on Add new model
  5. hover over Server endpoint (i)
  6. look at the resulting tooltip

Actual result

...if you are not sure...

Screen Shot 2024-07-12 at 11 48 38 AM

Expected result

Should probably read "...if you're not sure..." Screen Shot 2024-07-12 at 11 48 14 AM

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.69.101 Chromium: 127.0.6533.43 (Official Build) nightly (x86_64)
-- | --
Revision | 9073515479afc03ab66a21bb8175263fc56ba1f1
OS | macOS Version 11.7.10 (Build 20G1427)

Channel information

Reproducibility

Miscellaneous information

cc @rmcfadden3 @macauleyberg @nullhook @rebron @mattmcalister @petemill @bbondy

rmcfadden3 commented 1 month ago

@stephendonner you are the best

stephendonner commented 1 month ago

@stephendonner you are the best

No, @rmcfadden3 you're the best

bsclifton commented 1 month ago

Commander Data does not approve of this 😂 image

stephendonner commented 1 month ago

Verified PASSED using

Brave | 1.69.115 Chromium: 127.0.6533.43 (Official Build) nightly (64-bit)
-- | --
Revision | 0f3c95cf9cac0acfd6d49bd72bb2ed548901a082
OS | Windows 10 Version 22H2 (Build 19045.4651)

Steps:

  1. installed 1.69.115
  2. launched Brave
  3. opened brave://settings/leo-assistant
  4. verified string changes for Leo contractions
  5. opened brave://settings/privacy

(Did not verify the extra-included Wallet strings, but given the code changes tested and that it's a string fix, that's OK.)

Leo strings

example example example example
image image image image

Tor bridges

example example
image image