search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.51k stars 2.26k forks source link

Restore upstream variations/shutdown tests #39773

Closed goodov closed 1 month ago

goodov commented 1 month ago

Description

We recently disabled MetricsService [1] which led to incorrect shutdown handling and broken variations after 5th restart [2]. There are some upstream tests that could've prevented this. We need to re-enable/fix those.

  1. https://github.com/brave/brave-core/pull/24550
  2. https://github.com/brave/brave-browser/issues/39767
atuchin-m commented 1 month ago

A related perf issue: https://github.com/brave/brave-browser/issues/39864