Adding custom token doesn't show the image in Edit token list view - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.53k stars 2.27k forks source link

Adding custom token doesn't show the image in Edit token list view #39785

Open srirambv opened 2 months ago

srirambv commented 2 months ago

Description

Adding custom token doesn't show the image in Edit token list view

Steps to reproduce

Open Edit User Assets from Portfolio
Tap + button bottom right
Add the following details:
- Address: 0x19de6b897ed14a376dda0fe53a5420d2ac828a28
- Network: Ethereum Mainnet
- Token Name: BGB
- Symbol: BGB
- Decimals: 18
- Tap Advanced to reveal Icon URL field
- Enter NFT image url: https://cdn.simplehash.com/assets/cac5edfdef533de6697c93b4944f94eaef649fcf78524a35d01c13e80045d234.svg
Tap Add
Token gets added but doesn't show the image

Actual result

https://github.com/user-attachments/assets/4f75e91a-9427-4453-9166-f8985cb145d1

Expected result

Should show the custom token image

Reproduces how often

Easily reproduced

Brave version

1.68 (115)

Device/iOS version

iPad (iOS 16.7.8)

Affected browser versions

[ ] latest AppStore
[X] latest TestFlight
[ ] previous TestFlight

Reproducibility

[ ] with Brave Shields disabled
[ ] in the latest version of mobile Safari

Miscellaneous information

Note: same steps on iOS 18 works as expected and shows the image

cc: @nuo-xu @StephenHeaps

srirambv commented 1 month ago

Still reproducible with iPad. Adding the icon address only once still doesn't show the image