Control + B shortcut not working in some sites which handles it. - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.54k stars 2.27k forks source link

Control + B shortcut not working in some sites which handles it. #39959

Open jagadeshjai opened 1 month ago

jagadeshjai commented 1 month ago

Description

Shortcut to toggle SidePanel is not working in some sites which handles that key.

Steps to reproduce

Navigate to https://key-test.com/
Press Control + B -> It will reflect in that site.

Actual result

Side panel is not toggling in some sites

Expected result

I think we should toggle side panel when Control + B pressed instead of passing the event to sites.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)

Channel information

[X] release (stable)
[X] beta
[X] nightly

Reproducibility

[X] with Brave Shields disabled
[X] with Brave Rewards disabled
[ ] in the latest version of Chrome

Miscellaneous information

No response

jagadeshjai commented 1 month ago

CC: @rebron / @simonhong