Windows users unable to launch Brave after update to 1.68.128

Brave-Matt commented 1 month ago

Description

Brave won't launch normally for Windows users after the latest update to v1.68.128. Notably, Private windows will launch properly but trying to open the standard browser will not. Disabling extensions (via flag), opening a new profile and reinstalling does not resolve the issue. This has been reported multiple times on our support site/socials:

Steps to reproduce

Launch Brave after update to 1.68.128 on Windows

Actual result

Browser won't launch/crashes

Expected result

Browser opens

Reproduces how often

Easily reproduced

Brave version (brave://version info)

v1.68.128

Channel information

[X] release (stable)
[ ] beta
[ ] nightly

Reproducibility

[ ] with Brave Shields disabled
[ ] with Brave Rewards disabled
[ ] in the latest version of Chrome

Miscellaneous information

Internal Slack thread: https://bravesoftware.slack.com/archives/C012NN4F6UU/p1721848474288939

bsclifton commented 1 month ago

Steps to reproduce:

Fresh profile
Exit Brave
Use an editor to open the Local State file at the root of the profile
Find the section avatar_icon":"chrome://theme/IDR_PROFILE_
Change the value of avatar_icon to be chrome://theme/IDR_PROFILE_AVATAR_28 and save the file
Launch Brave
It crashes

bsclifton commented 1 month ago

As a work-around to folks experiencing this, you can do the above - and then change the IDR_PROFILE_AVATAR_28 part to IDR_PROFILE_AVATAR_26 for example and save. That should fix you

LaurenWags commented 1 month ago

Tried STR from https://github.com/brave/brave-browser/issues/40005#issuecomment-2251241020 on macOS 1.68.128 Chromium: 127.0.6533.73 and confirmed chrome://theme/IDR_PROFILE_AVATAR_28 displays fine on macOS:

Brave | 1.68.128 Chromium: 127.0.6533.73 (Official Build) (x86_64)
-- | --
Revision | 800676fd9ede2eb4174bac98c186e53749c7201f
OS | macOS Version 13.6.7 (Build 22G720)

brave://local-state:

kjozwiak commented 1 month ago

Steps to reproduce:

Fresh profile

Exit Brave

Use an editor to open the Local State file at the root of the profile

Find the section avatar_icon":"chrome://theme/IDR_PROFILE_

Change the value of avatar_icon to be chrome://theme/IDR_PROFILE_AVATAR_28 and save the file

Launch Brave

It crashes

So using the above STR/Cases that @bsclifton mentioned above, I can reproduce the crash pretty easily as per the following:

install 1.67.134 Chromium: 126.0.6478.186
once installed, close Brave and open Local State in a text editor
- C:\Users\kamil\AppData\Local\BraveSoftware\Brave-Browser\User Data\Local State
change "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_26 --> "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_28"
re-launch Brave and go into brave://settings/manageProfile
you'll notice that there's nothing selected under Pick an avatar
create a second profile and you'll notice that the main is a solid yellow circle which doesn't exists as a choice
update to 1.68.128 Chromium: 127.0.6533.73 and you'll notice that Brave won't start/crashes

Example of the above occurring on Win 11 x64:

https://github.com/user-attachments/assets/92f424b3-7a9d-41e2-9e38-5d76b054afe0

kjozwiak commented 1 month ago

The above requires 1.68.131 or higher for 1.68.x verification 👍

kjozwiak commented 1 month ago

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.68.131 Chromium: 127.0.6533.73 (Official Build) (64-bit)
-- | --
Revision | 8167dd98e054f33ff258260aaf64d2eba8110772
OS | Windows 11 Version 23H2 (Build 22631.3958)

Using the STR/Cases from both https://github.com/brave/brave-core/pull/24863#issue-2431149942 & https://github.com/brave/brave-browser/issues/40005#issuecomment-2251398295, ensured that Brave isn't crashing when chrome://theme/IDR_PROFILE_AVATAR_28 as per the following cases:

`Test Case #1` - Clean Install

installed/launched 1.68.131 Chromium: 127.0.6533.73
once launched/closed Brave and opened AppData\Local\BraveSoftware\Brave-Browser-Nightly\User Data\Local State
change "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_26 --> "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_28"
relaunched 1.68.131 Chromium: 127.0.6533.73 and ensured it didn't crash
checked "avatar_icon via AppData\Local\BraveSoftware\Brave-Browser-Nightly\User Data\Local State and ensured that it was now "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_26

Ran through the above several times and ensured that Brave wasn't crashing.

https://github.com/user-attachments/assets/e7a7d90b-9354-4842-b598-6289eb817d0b

`Test Case #2` - Upgrading from `1.68.x` broken State

installed/launched 1.68.128 Chromium: 127.0.6533.73
once launched/closed Brave and opened AppData\Local\BraveSoftware\Brave-Browser-Nightly\User Data\Local State
change "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_26 --> "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_28"
relaunched 1.68.128 Chromium: 127.0.6533.73 and ensured that Brave was crashing on startup
updated Brave via BraveBrowserStandaloneSetup.exe which installs 1.68.131 Chromium: 127.0.6533.73
re-launched Brave several times and ensured it was launching without any issues
checked "avatar_icon via AppData\Local\BraveSoftware\Brave-Browser-Nightly\User Data\Local State and ensured that it was now "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_26

https://github.com/user-attachments/assets/c17d4966-f311-4f71-96f4-deaaa5b0ec5d

`Test Case #3` - Upgrading from `1.67.x` -> `1.68.x`

installed/launched 1.67.134 Chromium: 126.0.6478.186
once launched/closed Brave and opened AppData\Local\BraveSoftware\Brave-Browser-Nightly\User Data\Local State
change "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_26 --> "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_28"
updated Brave via BraveBrowserStandaloneSetup.exe which installs 1.68.131 Chromium: 127.0.6533.73
re-launched Brave several times and ensured it was launching without any issues
checked "avatar_icon via AppData\Local\BraveSoftware\Brave-Browser-Nightly\User Data\Local State and ensured that it was now "avatar_icon":"chrome://theme/IDR_PROFILE_AVATAR_26

https://github.com/user-attachments/assets/bd064d61-8bca-481b-a5eb-79c21dbd3c6a

brave / brave-browser