webcompat toggle list gets out of date

[arthuredelstein]

Description

When a toggle switched in the webcompat UI is flipped, if you hide and re-show the side-panel, the toggle positions are stale.

Steps to reproduce

1. Visit https://browserleaks.com/javascript
2. Open the webcompat side-panel (click Shield > "Block fingerprinting" integer)
3. Toggle one switch to disabled
4. Hide the side-panel (click "<-- Shields" button)
5. Show the side-panel again

Actual result

The toggle switch is in enabled state again. (Note that the actual setting is still disabled, but the toggle switch is displaying a stale value.)

Expected result

The toggle switch should remain disabled.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.70

Channel information

• [ ] release (stable)
• [ ] beta
• [X] nightly

Reproducibility

• [ ] with Brave Shields disabled
• [ ] with Brave Rewards disabled
• [ ] in the latest version of Chrome

Miscellaneous information

No response

[stephendonner]

Verified PASSED using

Brave | 1.70.30 Chromium: 127.0.6533.73 (Official Build) nightly (x86_64)
-- | --
Revision | 252bfcfa10e3f2a7e92ee1be5b9e488ab43b7218
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

1. installed 1.70.30
2. launched Brave
3. loaded https://browserleaks.com/javascript
4. clicked on the Shields icon in the URL bar
5. clicked to toggle Block fingerprinting to Off/Disabled
6. clicked again on the Shields icon

Confirmed the Block fingerprinting pref remained Off

example	example	example	example

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.70.94 Chromium: 128.0.6613.114 (Official Build) beta (64-bit)
-- | --
Revision | 7ee7ec28264896bd8a9aff39cdb9432da38be028
OS | Windows 10 Version 22H2 (Build 19045.4780)

• Verified the test plan from https://github.com/brave/brave-browser/issues/40024#issue-2431269908
• Encountered the issue https://github.com/brave/brave-browser/issues/40765

Confirmed the Block fingerprinting pref remained Off

Example	Example	Example	Example

[MadhaviSeelam]

Verification PASSED using

Brave   1.70.109 Chromium: 128.0.6613.138 (Official Build) beta (64-bit) 
Revision    fec4422ae56f4d9680c71a3c1de60b9a8e5ef32f
OS  Linux

1. installed 1.70.109
2. launched Brave
3. loaded https://browserleaks.com/javascript
4. clicked on the Shields icon in the URL bar
5. verified Block fingerprinting is enabled
6. clicked to toggle Block fingerprinting to Off/Disabled
7. clicked again on the Shields icon
8. Confirmed the Block fingerprinting pref remained Off

step 5	step 6	step 7	step 8