brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.63k stars 2.29k forks source link

SIWE doesn't work with Ledger HW using the Brave Wallet #40037

Open przemerr opened 2 months ago

przemerr commented 2 months ago

Description

When trying to sign in (SIWE) on https://tally.xyz or https://passport.gitcoin.co/ using an address that is connected to a Ledger Nano S plus, the operation fails.

Steps to reproduce

  1. Go to https://passport.gitcoin.co/ or https://www.tally.xyz/gov/wormhole
  2. Try to sign in using a Ledger Nano S plus HW

Actual result

The message to sign doesn't appear on the device. An error message pops-up on gitcoin site image

and on tally.xyz nothing happens after clicking sign in the wallet

Expected result

It should allow to sign the message on the device

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave: 1.68.128 Chromium: 127.0.6533.73 (Official Build) (64-bit) Revision: 800676fd9ede2eb4174bac98c186e53749c7201f OS: Windows 11 Version 23H2 (Build 22631.3880)

Channel information

Reproducibility

Miscellaneous information

No response

josheleonard commented 1 month ago

Signing into https://login.xyz/ also does not work, even without using a hardware wallet

josheleonard commented 1 month ago

Screenshot 2024-08-09 at 9 10 34 AM Screenshot 2024-08-09 at 9 05 44 AM

josheleonard commented 1 month ago

Seeing slightly different results in Nightly (still cant login): 1.70.58 Chromium: 128.0.6613.18 (Official Build) nightly (arm64)

Screenshot 2024-08-09 at 9 32 56 AM