brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.95k stars 2.35k forks source link

Add Sinhala language to Brave desktop #40232

Open wnilanka opened 3 months ago

wnilanka commented 3 months ago

Platforms

Linux, macOS, Windows

Description

Please add Sinhala language to Brave desktop browser.

Language: Sinhala / සිංහල Code: si / සිං

https://github.com/brave/brave-browser/issues/36084#issuecomment-2260000533

(@mkarolin comment) The language is disabled for UI in Chromium (https://issues.chromium.org/issues/40073213). No clear indication as to why, but from what I recall they typically disable languages that don't have full support in V8 (something to do with dates or numbers formatting). It's probably worth opening a separate issue for getting the language enabled in Brave.

https://issues.chromium.org/issues/41287742#comment40 me...@chromium.org There are currently no plans to add it due to binary size constraints. That may be revisited by the Desktop team in the future.

Binary size constraints - Binary size increases are what's blocking Desktop Chrome from adding more languages. Each language is approximately 250kb, and any binary size increase causes a drop in updates.

### Tasks
wnilanka commented 3 months ago

#36084 (comment-2260000533)

wnilanka commented 1 day ago

@rebron @mkarolin See https://github.com/ungoogled-software/ungoogled-chromium/pull/3072 https://github.com/ungoogled-software/ungoogled-chromium/pull/3072/files

Can you enable Sinhala language now?

Image

Brave translation status

Image

Image

See also:

Vivaldi Browser (Chromium-based) Image