brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Cannot use github 0Auth in brave beta on android #40257

Open skamansam opened 1 month ago

skamansam commented 1 month ago

Description

When using github as an oauth provider to login to daily.dev (or any other site that uses github oauth) in brave beta, the security code window should open in brave beta but does not. Instead, a system popup asks which app to use to open the url, but brave beta isn't in the list.

Steps to reproduce

  1. Set brave beta as the default web browser on Android 2.install the official github android app and login. This will be used to confirm the attempted login by entering a security code.
  2. Open brave beta and login to daily.dev using github.

Actual result

After enterin my github credentials, a system popup asking which application to open the url. Brave beta is not in the list.

Expected result

A new window showing my security code should open in brave beta, allowing me to enter it into the github app.

Reproduces how often

Easily reproduced

Brave version

Beta

Device

Channel information

Reproducibility

Miscellaneous information

This happens in the brave beta app and in the system brave widget.

skamansam commented 1 month ago

This happens with Brave stable as well.