search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

[cr128 follow-up] Avoid patching //third_party/polymer/v3_0/BUILD.gn for searchable dropdown #40292

Open mkarolin opened 1 month ago

mkarolin commented 1 month ago

Upstream has removed searchable dropdown from use on Desktop and only left it available on CrOS. We only use it one place on brave://settings/wallet/networks when you want to Add a network. To keep using it we had to copy some upstream code and patch //third_party/polymer/v3_0/BUILD.gn in multiple places.

Perhaps alternatives can be used for this drop-down: having our own implementation or using a regular (non-searchable) drop-down.

cc: @brave/crypto-wallets-front-end @petemill @fallaciousreasoning

browser/resources/settings/ui/searchable_drop_down_cros.html browser/resources/settings/ui/searchable_drop_down_cros.ts

fallaciousreasoning commented 1 month ago

@petemill should this be part of Nala or should we let users construct it out of a Input and Floating element?