brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

Appropriate error message should be shown when not cached media file is played when no internet/wifi connection available #40325

Open MadhaviSeelam opened 3 months ago

MadhaviSeelam commented 3 months ago

Description

Description Found while testing https://github.com/brave/brave-browser/issues/32585. If a media file is not cached (i.e. Automatically add files for offline viewingsetting is disabled) and internet/wifi is disconnected and media played in the playlist panel, it will play for about 3 minutes after disconnecting wifi. The frame is frozen and later if switched to different media file,Failed to play itemerror along withmay be expirederror is shown. YouTube page is shown withConnect to the internetandNo internet connection` message at the bottom. Not sure if this is expected.

Steps to reproduce

  1. Install 1.70.44
  2. launch/relaunch Brave
  3. open brave://settings/braveContent
  4. disable Automatically add files for offline viewing setting
  5. Add few videos to the Playlist
  6. disconnect internet/wifi connection

Actual result

media played for about 3 minutes frame is frozen but nothing happens switching to another file causes an error message to load

https://github.com/user-attachments/assets/379661b8-2d3c-49db-b281-71edb5d3a62e

Expected result

Appropriate error message?

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.70.44 Chromium: 127.0.6533.88 (Official Build) nightly (64-bit)
Revision c6e95da37b2d012afdca7bcc03a727e24cb2bb1c
OS Windows 11 Version 23H2 (Build 22631.3958)

Channel information

Reproducibility

Miscellaneous information

@rebron @bsclifton @sangwoo108 cc: @brave/qa-team

aguscruiz commented 3 months ago

What about something like this https://www.figma.com/design/RxyQnpxi9qtf5HmnAj1yH0/Desktop-Playlist?node-id=3593-23469&t=tGRUeYKbcwW1zKfL-1

What do you think about the copy @rebron

image

rebron commented 3 months ago

The copy looks good. I don't think we need to encourage caching the files.