brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.31k forks source link

Upgrade from Chromium 128.0.6613.18 to Chromium 128.0.6613.27 #40348

Closed mkarolin closed 2 months ago

mkarolin commented 2 months ago

Minor Chromium bump

🕐⚠️ After 128.0.6613.18 is merged into master.

https://chromium.googlesource.com/chromium/src/+log/128.0.6613.18..128.0.6613.27?pretty=fuller&n=10000

QA tests

Minor Chromium bump

kjozwiak commented 2 months ago

Quick overview of the work remaining re: affected areas due to C128 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via https://github.com/brave/brave-browser/issues/39083#issue-2355849903:

Platforms that still need to check/verify the affected areas due to C128 changes as per https://github.com/brave/brave-browser/issues/39083#issue-2355849903:

kjozwiak commented 2 months ago

The above requires 1.69.145 or higher for 1.69.x verification 👍

LaurenWags commented 2 months ago

Verification in progress with

Brave | 1.69.145 Chromium: 128.0.6613.27 (Official Build) beta (x86_64)
-- | --
Revision | b029337c8485766fbc2dd25b11a46c88c8aaf2b4
OS | macOS Version 13.6.9 (Build 22G830)

Verified desktop affected areas as listed via https://github.com/brave/brave-browser/issues/39083#issue-2355849903.

Encountered the following issues:

Page zoom (check Brave custom range of zoom values) - PASSED * Confirmed both `cmd` + `+` and `cmd` + `-` shortcuts * Confirmed ability to zoom in/out/go full-page via the top-level "hamburger" menu -> Zoom (`+`/`-`/`[ ]`) * Confirmed zoom up to `500%` * Confirmed zoom down to `25%` * Confirmed able to easily "Reset" via the magnifying glass icon in URL bar (when zoom level is not 100%) * Confirmed +/- accessible via magnifying glass also zoomed in/out as expected * Confirmed range of zoom-level options in `brave://settings/braveContent` `500%` | `25%` | `URL bar` | `full range` --------|-------|--------------|------------- 1 | 2 | 3 | 4
Tabs styling looks correct - PASS with follow up issue * Confirmed "squircle"-shaped rounded/square tabs * Confirmed default horizontal tabs view * Confirmed vertical-tabs view Encountered https://github.com/brave/brave-browser/issues/40486 while testing. Default, "horizontal" tabs Screenshot 2024-08-14 at 3 08 09 PM Vertical tabs Screenshot 2024-08-14 at 3 11 50 PM Note, ["Compact" view](https://github.com/brave/brave-browser/issues/40044) was not verified on 1.69.x as it is currently only in Nightly.
Passwords importing - Partial Pass, see notes below and follow up issue Note, unable to import passwords from Safari (known limitation). Also unable to import passwords from Firefox (https://github.com/brave/brave-browser/issues/34055), this reproduced on Chrome. Additionally, password import from Firefox is no longer offered on Chrome/Brave. _**from Chrome**_ - `FAILED` Browser crashed when importing from Chrome: https://github.com/brave/brave-browser/issues/40470 Note, passwords aren't imported from Chrome on macOS. This is a known issue: https://github.com/brave/brave-browser/issues/34046 ``` Brave | 1.69.146 Chromium: 128.0.6613.27 (Official Build) (x86_64) -- | -- Revision | 3bd0f984ce99277bd556cac8dd198aba4467a22f OS | macOS Version 13.6.9 (Build 22G830) ``` **_from file_** - `PASSED` 1. On Chrome, export list of passwords to .csv file 2. On Brave, navigate to brave://password-manager/passwords 3. Select the "select a CSV file" link 4. Navigate to your file and import 5. (Optional) delete the file 6. Confirm passwords are imported example | example | example | example --- | --- | --- | --- Screenshot 2024-08-15 at 10 44 39 AM | Screenshot 2024-08-15 at 10 45 02 AM | Screenshot 2024-08-15 at 10 45 21 AM | Screenshot 2024-08-15 at 10 45 36 AM **_from Brave (Upgrade)_** - `InProgress` * Confirmed passwords carried over from upgrading `1.68.141` -> `1.69.146` ### `1.68.141` example | example ----------|---------- Screenshot 2024-08-15 at 12 49 20 PM | Screenshot 2024-08-15 at 12 49 50 PM ### `1.69.146` example | example ----------|---------- Screenshot 2024-08-15 at 12 51 32 PM | Screenshot 2024-08-15 at 12 51 38 PM
Speedreader works - PASSED * Confirmed I could enter speedreader mode on `reuters.com` by clicking on the `Turn on Speedreader` icon in the URL bar * Confirmed I could invoke and hear the text-to-speech of the article * Confirmed I could customize the background, font color, style, and other elements * Confirmed selections were retained when visiting a different article example | example | example | example ----------|----------|-----------|---------- Screenshot 2024-08-15 at 3 28 41 PM | Screenshot 2024-08-15 at 3 28 50 PM | Screenshot 2024-08-15 at 3 30 56 PM | Screenshot 2024-08-15 at 3 31 50 PM
Ads notifications look correct - PASSED * Confirmed system ad notifications display * Confirmed able to dismiss the ad notification * Confirmed able to click on and load ad * Confirmed custom ad notifications display * Confirmed able to dismiss the ad notification * Confirmed able to click on and load ad OS Notification | flag for custom notifications | Custom Notification | Ads History ----------|----------|------------|---------- Screenshot 2024-08-15 at 3 40 14 PM | Screenshot 2024-08-15 at 3 41 43 PM | Screenshot 2024-08-15 at 3 47 49 PM | Screenshot 2024-08-15 at 4 02 52 PM
Sync works - PASSED * Confirmed I could start a new sync chain example | example | example | example ----------|----------|---------|--------- Screenshot 2024-08-15 at 4 20 38 PM | Screenshot 2024-08-15 at 4 20 49 PM | Screenshot 2024-08-15 at 4 20 56 PM | Screenshot 2024-08-15 at 4 22 37 PM * Confirmed I could join an existing sync chain example | example | example | example ----------|----------|---------|--------- Screenshot 2024-08-15 at 4 32 19 PM | Screenshot 2024-08-15 at 4 32 37 PM | Screenshot 2024-08-15 at 4 33 53 PM | Screenshot 2024-08-15 at 4 34 11 PM * Confirmed bookmarks synced between devices example | example ----------|---------- Screenshot 2024-08-15 at 4 35 18 PM | Screenshot 2024-08-15 at 4 35 23 PM
HTTPS upgrade of URL typed with http:// works - PASSED * Confirmed typing and loading `http://https-everywhere.badssl.com/` auto-upgraded to `https://https-everywhere.badssl.com/` example | example | example ----------|----------|-------- Screenshot 2024-08-15 at 4 38 49 PM | Screenshot 2024-08-15 at 4 39 02 PM | Screenshot 2024-08-15 at 4 39 11 PM
GeetaSarvadnya commented 2 months ago

Verification PASSED on

Brave | 1.69.146 Chromium: 128.0.6613.27 (Official Build) (64-bit)
-- | --
Revision | 3bd0f984ce99277bd556cac8dd198aba4467a22f
OS | Windows 10 Version 22H2 (Build 19045.4780)

image

kjozwiak commented 2 months ago

Labelling as QA/No & release-notes/exclude in favor of https://github.com/brave/brave-browser/issues/40467 👍