Open rillian opened 2 months ago
Personally, I find the metadata panel quite helpful in evaluating articles, and having that in a standard place is an advantage reader mode offers. What do you think, @boocmp?
I think we should keep the date, so the first option is preferable.
I think we should keep the date, so the first option is preferable.
Today neither dep for time would satisfy our criteria for rust deps so I'm going to rule out option one. There is a third option though which is to expose the chromium cpp code.
Description
@bridiver complained about the
time
rust crate dependency we use to parse and display publication date metadata. Prior to #10965 we used thechrono
crate instead, but migrated away for poor maintenance. Later it was reintroduced as a dependency ofskus
andfeed-rs
, but never migrated the speedreader code back. So we're using both calendar libraries unnecessarily. There are also some smaller libraries, likehumantime
andspeeddate
which support RFC 3339.Brian also mentioned he'd never seen the relevant feature in action. I noticed we only parse dates from json-ld scripts. These are still used by a number of large publications, e.g. The New York Times. The output looks like this: But we don't handle the
<meta name="article:published_time" content="...">
tags used by e.g. many wordpress blogs.I see two resolutions here, both removing the
time
dependency.chrono
. If we do this we should handle more tags so the feature is more visible.Any thoughts about the importance of this feature?
Steps to reproduce
Here is an example of the date parsing.