various rewards screens/modals have incorrect coloring

LaurenWags commented 2 months ago

Description

On Nightly there are various rewards screens/modals with incorrect coloring - buttons, text, etc. Examples below but there could be others.

Confirmed with @Miyayes this coloring is not expected.

Not specific to C128 as this issue reproduces in non-C128 version of 1.70.x Nightly but is fine on 1.69.x Beta.

Steps to reproduce

On Nightly click on BAT logo --> button/link coloring is incorrect
Click "Start using Rewards and pick a country --> button color is incorrect (maybe focus ring on country field too)
Click on "Continue" --> button/link coloring is incorrect
Connect a custodian
Visit a verified creator and open tip banner --> tip amount and button coloring is incorrect

Note for QA: when verifying, check both light and dark themes

Actual result

Here's 1.70.x/Nightly (incorrect) side by side with 1.69.x/Beta (correct)

1.70.x	1.69.x

Expected result

coloring should be like 1.69.x/Beta

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.70.x (both C127 and C128 versions)

Channel information

[ ] release (stable)
[ ] beta
[X] nightly

Reproducibility

[ ] with Brave Shields disabled
[ ] with Brave Rewards disabled
[ ] in the latest version of Chrome

Miscellaneous information

cc @Miyayes

Miyayes commented 2 months ago

@aguscruiz Is this Nala?

aguscruiz commented 2 months ago

Yeah, seems like the button on those screenshots is not a Nala button and that's why it's breaking (see how it's rounded and Nala's are squircles). If the button is updated to a Nala button that should be fixed.

https://nala.bravesoftware.com/?path=/docs/components-button--docs

GeetaSarvadnya commented 1 month ago

Verification PASSED on

Brave | 1.70.88 Chromium: 128.0.6613.85 (Official Build) beta (64-bit)
-- | --
Revision | 7431803bd1e909ef82982df42e2ea7aacbad755e
OS | Windows 10 Version 22H2 (Build 19045.4780)

Confirmed that rewards screens/modals with correct coloring - buttons, text etc. also ensured that coloring is same like 1.69.x/Beta in light theme and In dark theme the coloring is varied as per the test plan screens https://github.com/brave/brave-core/pull/25090

Light theme: