brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.55k stars 2.28k forks source link

[Perf] 20% regression in cpuTime/system_health.common_desktop after cr128 #40419

Open atuchin-m opened 1 month ago

atuchin-m commented 1 month ago
Alert information:
Median of segment before: 2016.97
Median of segment after: 2431.657
Relative change: 20.6%
Test: BravePerf/win11-hp-laptop-typical/system_health.common_desktop/cpuTime:all_processes:all_threads:all_stages:all_initiators/load_chrome/load_chrome_blank
image
atuchin-m commented 1 month ago
atuchin-m commented 3 weeks ago

A test build with example.com: https://ci.brave.com/job/brave-browser-test-perf-macos/2010/

atuchin-m commented 3 weeks ago

image

atuchin-m commented 3 weeks ago

The traces show that one of the reasons of the regression is that we don't count Brave Extension frame load work before and start to could after. There is also a difference how tracing mechanism classify the renderers (see the screenshot). We actually want to count it, so the new behavior is correct one.

But it doesn't explain changing in the reference (chromium) metrics. However, the ref diff isn't so significant.

image

atuchin-m commented 3 weeks ago

A test win build with chromium: https://ci.brave.com/job/brave-browser-test-perf-windows/1009/