Linker error in Debug build - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.53k stars 2.27k forks source link

Linker error in Debug build #40451

Closed jagadeshjai closed 1 week ago

jagadeshjai commented 4 weeks ago

Description

Screenshot 2024-08-14 at 10 32 55 AM

Screenshot 2024-08-14 at 3 05 17 PM

Seems we need to move generated_api_registration https://github.com/brave/brave-core/blob/b3bafa06f26cb341a510fe8ffc8e49085c1706f9/common/extensions/api/BUILD.gn#L80 under src/brave/browser/extensions/api/ to fix the above linker error and potential cyclic dependency.

Reference: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/extensions/api/BUILD.gn;l=57;drc=e804caa46cd3cf2ed7f9130e01a1c77fe9737f0c

jagadeshjai commented 4 weeks ago

CC: @bbondy Since you were the one who originally wrote these.