Open hamirmahal opened 4 weeks ago
@hamirmahal are you still having this issue?
You do need to have a directory structure like:
/home/hamir/brave-browser/src/brave
where brave-core
is cloned into the brave
folder. Once you do that, you can run npm run init
for the first time.
Based on the error messages seen above, it seems your working directory is /home/hamir/brave-browser/
and I think it might trying to look in parent directory (ex: /home/hamir/
) and not finding base
directory.
I actually removed the brave-browser/src/brave
directory and re-cloned it, and I'm running into another, /home/hamir/brave-browser/src/brave/third_party/bitcoin-core/src
issue. I can open a ticket for it if that'd help.
I may remove the entire brave-browser/
directory and start from scratch, which I was hoping to avoid, to prevent a ~40 GB Chromium re-download.
I'm trying to rerun npm run init
but it doesn't appear to be working.
@hamirmahal OK that last run you did looks good - it finished syncing, so you can now just run npm run sync
(init only needed first time).
Is /home/hamir/brave-browser/src/brave
on the master
branch? That would be important. I would try running:
cd /home/hamir/brave-browser/src/brave
git checkout master
git pull
npm run sync
@hamirmahal OK that last run you did looks good - it finished syncing, so you can now just run
npm run sync
(init only needed first time).
Ah, okay. I thought things went wrong because there was a lot of red text at the end, followed by a message saying that not everything was successful, also in red text. It might be worth modifying that to have some sort of green 'all clear' message to improve the developer experience.
Is
/home/hamir/brave-browser/src/brave
on themaster
branch? That would be important. I would try running:cd /home/hamir/brave-browser/src/brave git checkout master git pull npm run sync
Yeah the red text is not good - but you made it past the sync part, at least it looked that way from the logs. Meaning, your local code should have the latest Chromium and it's supposed to have done a reset.
Something looks off though - those files should absolutely be there.
Just for a sanity check, do you have these files on disk?
/home/hamir/brave-browser/src/base/BUILD.gn
/home/hamir/brave-browser/src/base/version_info/BUILD.gn
/home/hamir/brave-browser/src/v8/BUILD.gn
If not, then the Chromium cloning step might have failed. npm run sync
gets the depot_tools package and does gclient sync
which is supposed to get you up to date.
Hmm... It looks like I have the first and last one, but not the middle one.
0 ~ $ stat /home/hamir/brave-browser/src/base/BUILD.gn
File: /home/hamir/brave-browser/src/base/BUILD.gn
Size: 181856 Blocks: 360 IO Block: 4096 regular file
Device: 10302h/66306d Inode: 39356432 Links: 1
Access: (0664/-rw-rw-r--) Uid: ( 1000/ hamir) Gid: ( 1000/ hamir)
Access: 2024-09-06 15:01:53.909338997 -0700
Modify: 2024-08-21 19:36:11.763904204 -0700
Change: 2024-08-21 19:36:11.763904204 -0700
Birth: 2024-08-21 19:36:11.763904204 -0700
0 ~ $ stat /home/hamir/brave-browser/src/base/version_info/BUILD.gn
stat: cannot statx '/home/hamir/brave-browser/src/base/version_info/BUILD.gn': No such file or directory
1 ~ $ stat /home/hamir/brave-browser/src/v8/BUILD.gn
File: /home/hamir/brave-browser/src/v8/BUILD.gn
Size: 268974 Blocks: 528 IO Block: 4096 regular file
Device: 10302h/66306d Inode: 42433456 Links: 1
Access: (0664/-rw-rw-r--) Uid: ( 1000/ hamir) Gid: ( 1000/ hamir)
Access: 2024-09-06 15:01:55.718351509 -0700
Modify: 2024-08-04 15:58:54.873953157 -0700
Change: 2024-08-04 15:58:54.873953157 -0700
Birth: 2024-08-04 15:58:54.869953132 -0700
Description
npm run sync
fails withSteps to reproduce
npm run sync
Actual result
npm run sync
fails.Expected result
npm run sync
should work.Reproduces how often
Easily reproduced
Brave version (brave://version info)
n/a
Channel information
Reproducibility
Miscellaneous information
No response