search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

Chrome scheme while uninstall Password manager #40512

Open jagadeshjai opened 2 months ago

jagadeshjai commented 2 months ago

Description

Steps to reproduce

  1. Navigate to brave://password-manager/passwords and install the PWA by clicking the icon.
  2. Once installed, open the password manager.
  3. Uninstall the password manager.
  4. Prompt will shown with chrome://password-manager

Actual result

https://github.com/user-attachments/assets/3846b50f-03ff-41c7-8965-1deb50cb0cdf

Expected result

Scheme should be brave://password-manager

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.70.66 Chromium: 128.0.6613.27 (Official Build) nightly (arm64)

Channel information

Reproducibility

Miscellaneous information

Good First Issue.

gelbphoenix commented 2 months ago

It also shows "Open in chromium" when you click on the hamburger menu.

rebron commented 2 months ago

@gelbphoenix what version are you seeing "Open in chromium"? That should be fixed in the latest version 1.69.153.

gelbphoenix commented 2 months ago

@gelbphoenix what version are you seeing "Open in chromium"? That should be fixed in the latest version 1.69.153.

I'm using the latest version on Fedora Workstation 40. (But it can also be a bug within the Flatpak of Brave)