brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.81k stars 2.33k forks source link

Cannot enabled password as sync item #40552

Open A-t-s-u-s-h-i opened 2 months ago

A-t-s-u-s-h-i commented 2 months ago

Description

A user reports that they cannot enable password sync even if biometric auth was passed. It is reproducible on my device(Android13/Brave1.68.137).

スクリーンショット 2024-08-20 11 05 12

https://github.com/user-attachments/assets/c1456eb4-c58e-48b4-a58d-f23df5521f17

Steps to reproduce

  1. Setting => Sync => Select sync option
  2. Enable Password
  3. Done biometric auth

Actual result

Password won't be enabled as sync item

Expected result

It should be enabled

Reproduces how often

Easily reproduced

Brave version

1.68.137

Device

Channel information

Reproducibility

Miscellaneous information

No response

AlexeyBarabash commented 2 months ago

I was able reproduce with my old Android 9 device where there is no any biometric sensor, so the graphic pattern is used.

On devices with a fingerprint sensor enable I wasn't able to reproduce it.

AlexeyBarabash commented 2 months ago

I wasn't able to reproduce it on my dev build, so I have checked all versions:

Stable 1.69.153 - can reproduce Beta 1.70.92 - can't reproduce Nightly 1.71.37 - can't reproduce

francoism90 commented 2 months ago

dup: https://github.com/brave/brave-browser/issues/36190

I have the same issue on Android 15 Beta (Pixel) and Brave stable. Same for on a Chromebook.

OFiberPH commented 2 months ago

Same here, unable to turn on password sync even after authenticating via fingerprint. Tasted on the ff units using the Play store version: Samsung Galaxy Tab S9 Ultra Android 14 Samsung Galaxy S23 Ultra Android 14 Samsung Galaxy A55 5G Android 14

PS: I do have Brave installed on PC and it is added in sync chain. Maybe there is some sort of conflict between PC/Mobile syncing? Can't say for sure.

mbasaglia commented 2 weeks ago

Happens for me as well Brave 1.70.126, Chromium 129.0.6668.100 Samsung Galaxy A54 5G Android 14