brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
18k stars 2.36k forks source link

Add option to send translation query to Brave Search via the context menu #40558

Open polak14 opened 3 months ago

polak14 commented 3 months ago

Description

"Translate selection into $language" in the right-click context menu is not available if Google is not the default search engine.

Steps to reproduce

  1. Set the Normal Window Search Engine to anything other than Google
  2. Visit any site (https://brave.com)
  3. Select any text you want to translate
  4. Right-click to open the Context menu
  5. Select "Translate selection into $language"

Actual result

The option does not exist Screenshot_20240820_175601

Expected result

The option exists Screenshot_20240820_175548

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.141 Chromium: 127.0.6533.120 (Official Build) (64-bit) Revision b3f23500b575d50584510ea1814ef440d30741a8 OS Linux

Also tested on: 1.68.141 Chromium: 127.0.6533.120 (Official Build) (64-bit) Revision b3f23500b575d50584510ea1814ef440d30741a8 OS Windows 10 Version 21H2 (Build 19044.4412)

Channel information

Reproducibility

Miscellaneous information

No response

alnmy commented 3 months ago

i had recently moved to brave browser and had been massively disappointed by the fact that i would need to switch to google from brave search if i were to use the proxied translation service for inline translations. hoping this gets resolved quickly