brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.32k forks source link

https://www.photopea.com/ ads showing in shields #40619

Closed ryanbr closed 1 month ago

ryanbr commented 1 month ago

Description

Opening https://www.photopea.com/

Steps to reproduce

  1. Opening https://www.photopea.com/
  2. wait 5-20secs.
  3. ads and a antii-adblock popup

Actual result

photopeeas

Expected result

photopeeas2

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.69

Channel information

Reproducibility

Miscellaneous information

||pagead2.googlesyndication.com^$xhr,3p,redirect-rule=noop.js,method=head,from=photopea.com related rule

Arthurprnt commented 1 month ago

Hello, By removing ads, some features of the website are broken. For exemple: https://github.com/photopea/photopea/issues/7108

kuckir commented 1 month ago

Hi guys, I am the creator of Photopea. I had to use a different Github account, since you have blocked my official account https://github.com/photopea/

In your last release of Brave, you completely break Photopea. Why do you do it?

https://github.com/photopea/photopea/issues/7085 https://github.com/photopea/photopea/issues/7087 https://github.com/photopea/photopea/issues/7089 https://github.com/photopea/photopea/issues/7090 https://github.com/photopea/photopea/issues/7094 https://github.com/photopea/photopea/issues/7094 https://github.com/photopea/photopea/issues/7100 https://github.com/photopea/photopea/issues/7101 https://github.com/photopea/photopea/issues/7108 https://github.com/photopea/photopea/issues/7109

I hope you are happy to cause your users so much pain. And it is painful for me to have to tell everyone to switch to a different browser.

If you dont fix it in 2 days, Photopea.com in Brave will be just a white screen saying "Switch to a better web browser."

bsclifton commented 1 month ago

Hi @kuckir

I assure you, it's not the intention to break Photopea. This is my first time hearing about the website

Thanks for sharing the specific issues - I'll see if we can help with a webcompat fix. I can confirm the official account is blocked - but I don't see why at the moment. I suspect there may have been some heated messages which other repository owners ended up deleting. I can definitely unblock this account if we're able to keep a good relationship here

Let me share this issue - stay tuned

ShivanKaul commented 1 month ago

@kuckir were you able to repro the breakage? Similar to you, I'm having issues reproducing the issue on Brave: https://github.com/photopea/photopea/issues/7090#issuecomment-2308579027

I've created https://github.com/brave/brave-browser/issues/40735 to track this breakage. We want to get to the bottom of this and figure out what aspect of our blocking is breaking photopea.com.

kuckir commented 1 month ago

I do allow my users to block ads in Photopea.

But I want to tell them, that my income depends on them watching ads, or paying for a Premium account, and ask them to watch ads.

If you will try to remove my message "Are you blocking ads?", I will detect it and I will not allow a user to use any part of my work in such a case.

ryanbr commented 1 month ago

Its been fixed.

ShivanKaul commented 1 month ago

Closing this out since the original issue opened by @ryanbr is fixed and the website breakage also seems to be fixed. Tracking adblock-rust support for the filter mentioned in the issue description here: https://github.com/brave/adblock-rust/issues/391

ShivanKaul commented 1 month ago

(Just a reminder about Brave's blocking goals and policy: https://github.com/brave/brave-browser/wiki/Blocking-goals-and-policy)