search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.85k stars 2.34k forks source link

"Show Leo in the context menu on websites" setting does nothing #40629

Open Infinoid opened 2 months ago

Infinoid commented 2 months ago

Description

I enable this setting. Then I right-click a website and it's not there.

Steps to reproduce

  1. Go to brave://settings/leo-assistant
  2. Enable the "Show Leo in the context menu on websites" setting
  3. Open a website
  4. Right click it
  5. No leo option in popup menu

Actual result

image

Expected result

I was expecting to see a Leo in the context menu.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit) Revision a69e96756922f88cbce3482971d70cfd1ee6f872 OS Linux

Channel information

Reproducibility

Miscellaneous information

Am I misunderstanding what "context menu" means? I think it means the right-click menu.

I am using BYOM, if it matters.

rebron commented 2 months ago

@Infinoid When you select text, do you see the Leo AI tools in the context menu?

Infinoid commented 2 months ago

Yes, I do. Have I misunderstood how the feature works, then?

Infinoid commented 2 months ago

When I use this text-selection context menu, it ignored my default model setting and used Mixtral again (see #40627). But otherwise, it did the thing I asked it to.

Infinoid commented 2 months ago

Should "Leo AI tools" show up in the right-click menu when no page text is highlighted? Maybe that's a feature request.

I had assumed it would be there, and the entire page text would be visible to the AI, but that doesn't seem to be how it works. Apart from that, I don't think there's any bug to fix here.