Currently, if you have the shared pinned tabs feature enabled, you pin a tab and open a contextual side panel for it (for example Leo AI, summarize page), and then you open a new window and activate the pinned tab there, the side panel in the new window has the same content as it did in the old window.
With the upstream change https://chromium.googlesource.com/chromium/src/+/2fd6b53ceaf1144ff7e4cf1a867a954b53271d1b the SidePanelRegistry is no longer owned by the WebContents, but instead is owned by TabFeatures, so when we move the WebContents from the old window to the new window the SidePanelRegistry doesn't move with it. The result is that the old window still has the side panel in the state it was before the move and the new window doesn't show the side panel.
Additional code changes beyond the scope of the Chromium bump are needed to get this working again.
Test plan:
Start the browser and navigate to brave://flags
Search for brave-shared-pinned-tabs and verify that it's set to disabled (default).
Enable the brave-shared-pinned-tabs flag and click Relaunch button.
Once the browser restarts, navigate to brave://settings/appearance and scroll down to the [Tabs] section
Enable the "Show pinned tabs in all windows" in the Settings -> Appearance [Tabs]
Navigate to brave.com
Right-click on the tab and select Pin
Observe the tab is now pinned
Click on Leo AI button and when the side panel opens click Summarize button
Open a new browser window via the hamburger menu
Verify the new window has brave.com pinned tab.
Click on the pinned tab in the new window
Verify that the side panel is opens in the tab and has the same content as it did in the old window
In the old window verify that the side panel is not shown.
mkarolin
commented
3 weeks ago
Description
Currently, if you have the shared pinned tabs feature enabled, you pin a tab and open a contextual side panel for it (for example Leo AI, summarize page), and then you open a new window and activate the pinned tab there, the side panel in the new window has the same content as it did in the old window.
With the upstream change https://chromium.googlesource.com/chromium/src/+/2fd6b53ceaf1144ff7e4cf1a867a954b53271d1b the SidePanelRegistry is no longer owned by the WebContents, but instead is owned by TabFeatures, so when we move the WebContents from the old window to the new window the SidePanelRegistry doesn't move with it. The result is that the old window still has the side panel in the state it was before the move and the new window doesn't show the side panel.
Additional code changes beyond the scope of the Chromium bump are needed to get this working again.
Test plan: