brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.85k stars 2.34k forks source link

Sidebar bug when on autohide. #40723

Open MustaDevelop opened 2 months ago

MustaDevelop commented 2 months ago

Description

When I try to use the sidebar while on "autohide", it gets a little too big.

brave_YGZxXachqP

Steps to reproduce

  1. Set the sidebar to "autohide"
  2. move the cursor to the sidebar

Actual result

The thing shown on the screenshot above.

Expected result

The sidebar should show up normally.

brave_QQQIKuH1pj This screenshot was made while it was on "always on"

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave: 1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit) Revision: a69e96756922f88cbce3482971d70cfd1ee6f872 OS: Windows 10 Version 22H2 (Build 19045.4780)

Channel information

Reproducibility

Miscellaneous information

No response

rebron commented 2 months ago

cc: @simonhong Looks like Windows only?

rebron commented 2 months ago

@MustaDevelop I think this maybe extension related. Can you check by disabling any extensions that may open up in the sidebar/side panel and let us know which one is opening up the panel that way? Otherwise, the panel width is definitely wider than expected.

simonhong commented 2 months ago

From the screenshot above, sidebar UI gets wider(not panel). I heard this issue before but it's really hard to repro. It would be really helpful if we have concrete repro step for this. I'll also try to repro on Windows.

MustaDevelop commented 2 months ago

From the screenshot above, sidebar UI gets wider(not panel). I heard this issue before but it's really hard to repro. It would be really helpful if we have concrete repro step for this. I'll also try to repro on Windows.

Sorry for not showing any clear way to repro it, since this issue is very new to me and never tested it with extensions disabled. I'll give you the results as soon as I try them!

MustaDevelop commented 2 months ago

@MustaDevelop I think this maybe extension related. Can you check by disabling any extensions that may open up in the sidebar/side panel and let us know which one is opening up the panel that way? Otherwise, the panel width is definitely wider than expected.

@rebron I tried it on a Guest profile with no extensions, and had the exact same result.