brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

missing images on panels #40765

Closed LaurenWags closed 1 week ago

LaurenWags commented 2 weeks ago

Description

On 1.69.159 there are missing images on some panels - Rewards, Wallet, VPN. Reproduces for both light and dark themes.

The images are there when using 1.69.157.

Reproduced on by @GeetaSarvadnya

Steps to reproduce

  1. Using 1.69.159 look at Rewards, Wallet, and VPN panels

Actual result

No images

Rewards Wallet VPN
Screenshot 2024-08-29 at 10 12 24 AM Screenshot 2024-08-29 at 10 18 17 AM Screenshot 2024-08-29 at 10 18 46 AM

Expected result

These panels should have images:

Rewards Wallet VPN
Screenshot 2024-08-29 at 10 15 55 AM Screenshot 2024-08-29 at 10 36 42 AM Screenshot 2024-08-29 at 10 36 49 AM

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.69.157 Chromium: 128.0.6613.85 (Official Build) (x86_64)
Revision 14c4bb724553b882abcd2fccd9b5acf1f177fe6d
OS macOS Version 13.6.9 (Build 22G830)

Channel information

Reproducibility

Miscellaneous information

cc @rebron @kjozwiak @brave/qa-team

GeetaSarvadnya commented 2 weeks ago

1.70.94 Chromium: 128.0.6613.114 - Reproduced rewards, wallet and VPN images missing issue on Windows 10 x64 Beta build

Example Example Example
image (5) image (6) image (7)
kjozwiak commented 1 week ago

The above requires 1.69.163 or higher for 1.69,x verification 👍

GeetaSarvadnya commented 3 days ago

Verification PASSED on

Brave | 1.69.168 Chromium: 128.0.6613.138 (Official Build) (64-bit)
-- | --
Revision | 6918a99aa67f8b2c8cfdc9a44e6ad4f9be6c5be9
OS | Windows 10 Version 22H2 (Build 19045.4780)

Verified Rewards, Wallet, and VPN panels on 1.69.168 and ensured that images are shown on all the panels

Rewards Wallet VPN
image image image
image image image
LaurenWags commented 3 days ago

Verified with

Brave | 1.69.168 Chromium: 128.0.6613.138 (Official Build) (x86_64)
-- | --
Revision | 6918a99aa67f8b2c8cfdc9a44e6ad4f9be6c5be9
OS | macOS Version 13.6.9 (Build 22G830)

Verified Rewards, Wallet, and VPN panels have images on 1.69.168 for both light and dark themes.

Light Dark
Screenshot 2024-09-11 at 8 07 36 AM Screenshot 2024-09-11 at 8 08 09 AM
Screenshot 2024-09-11 at 8 10 33 AM Screenshot 2024-09-11 at 8 11 17 AM
Screenshot 2024-09-11 at 8 10 42 AM Screenshot 2024-09-11 at 8 11 27 AM
Screenshot 2024-09-11 at 8 07 46 AM Screenshot 2024-09-11 at 8 07 46 AM
Screenshot 2024-09-11 at 8 07 52 AM Screenshot 2024-09-11 at 8 08 21 AM
btlechowski commented 2 days ago

Verified with

Brave 1.69.168 Chromium: 128.0.6613.138 (Official Build) (64-bit)
Revision 6918a99aa67f8b2c8cfdc9a44e6ad4f9be6c5be9
OS Linux

rewards

image image
image image
image image

wallet

image image