brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

Ad-shield showing ads on ios. #40777

Open ryanbr opened 2 months ago

ryanbr commented 2 months ago

Description

Opening various sites using Ad-shield in ios will show ads, if we attempt to block it the site breaks.

Steps to reproduce

in iOS: (sample sites)

  1. Open https://itainews.com/
  2. Open http://blog.livedoor.jp/kinisoku/archives/5546657.html
  3. Open https://www.pravda.com.ua/eng/articles/2023/10/1/7422200/

Actual result

Showing ads/Not breaking the site.

Expected result

Block ads like on desktop / android

Reproduces how often

Easily reproduced

Brave version

Brave 1.68.1

Device/iOS version

Iphone 15 pro

Affected browser versions

Reproducibility

Miscellaneous information

From uBO:

filters-2022.txt:||html-load.com^$redirect=noopjs,domain=blog.esuteru.com|blog.livedoor.jp|carscoops.com|dziennik.pl|eurointegration.com.ua|flatpanelshd.com|fourfourtwo.co.kr|issuya.com|itainews.com|iusm.co.kr|logicieleducatif.fr|mydaily.co.kr|mynet.com|onlinegdb.com|pravda.com.ua|reportera.co.kr|sportsrec.com|taxguru.in|text-compare.com|thesaurus.net|thestar.co.uk|tweaksforgeeks.com|videogamemods.com|wfmz.com|winfuture.de|worldhistory.org|yorkshirepost.co.uk|automobile-catalog.com|motorbikecatalog.com|maketecheasier.com|etnews.com|wort-suchen.de
filters-2022.txt:blog.esuteru.com,blog.livedoor.jp,carscoops.com,dziennik.pl,eurointegration.com.ua,flatpanelshd.com,fourfourtwo.co.kr,issuya.com,itainews.com,iusm.co.kr,logicieleducatif.fr,mydaily.co.kr,mynet.com,onlinegdb.com,pravda.com.ua,reportera.co.kr,sportsrec.com,taxguru.in,text-compare.com,thestar.co.uk,tweaksforgeeks.com,videogamemods.com,wfmz.com,winfuture.de,worldhistory.org,yorkshirepost.co.uk,etnews.com,wort-suchen.de##+js(nostif, error-report.com
ryanbr commented 2 months ago

||html-load.com^$redirect=noopjs,domain=blog.esuteru.com|blog.livedoor.jp|carscoops.com|dziennik.pl|eurointegration.com.ua|flatpanelshd.com|fourfourtwo.co.kr|issuya.com|itainews.com|iusm.co.kr|logicieleducatif.fr|mydaily.co.kr|mynet.com|onlinegdb.com|pravda.com.ua|reportera.co.kr|sportsrec.com|taxguru.in|text-compare.com|thesaurus.net|thestar.co.uk|tweaksforgeeks.com|videogamemods.com|wfmz.com|winfuture.de|worldhistory.org|yorkshirepost.co.uk|automobile-catalog.com|motorbikecatalog.com|maketecheasier.com|etnews.com|wort-suchen.de

Doesn't seem to work as custom rule in ios

Yuki2718 commented 1 month ago

Test example.com##iframe[src="about:blank"]:remove() on those AS-infected sites. I got positive feedback from AdGuard for iOS user.