brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.96k stars 2.35k forks source link

Include PDFium Library on brave android to open pdf inside browser #40808

Open Trisplus opened 2 months ago

Trisplus commented 2 months ago

Description

Currently, brave android can't open pdf inside the browser. However, desktop versions can open pdf inside the browser. It uses chromium PDFium Library. This should be included in brave android.

Alternatively, PDF.js library should be included. This can open pdf inside any chromium browser. Chrome extension like PDF viewer based on PDF.js, works on extension supported android browser like kiwi Browser and Microsoft Edge Canary Android.

Below screenshot of extension 'PDF Viewer' in Microsoft edge canary android browser showing a pdf. Screenshot_20240909-100758_1_1

Steps to reproduce

  1. Open any url containing pdf file.

Actual result

It downloads the file.

Expected result

Pdf file should opened natively inside browser

Reproduces how often

Easily reproduced

Brave version

All

Device

Channel information

Reproducibility

Miscellaneous information

No response

Trisplus commented 2 months ago

@BrendanEich said this. Screenshot_20240903-081928

Cc @SergeyZhukovsky @bsclifton

Trisplus commented 2 months ago

Adding this information to avoid any future conflicts. Chromium is working on native pdf viewer for android. There is a flag named #android-open-pdf-inline. The work is being done by this man.

SergeyZhukovsky commented 2 months ago

that's awesome, thanks for the info @Trisplus !

deeppandya commented 1 month ago

we have an issue logged in chromium : https://issues.chromium.org/issues/41175661