search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
18k stars 2.36k forks source link

[ads] Conversions should match up to the set cap, not one less #40895

Closed tmancey closed 2 months ago

tmancey commented 2 months ago

Description

If the Conversions/creative_set_conversion_cap feature parameter was set to 3, the creative set conversions were restricted to 2. This is incorrect; they should be capped at 3. Currently, Griffin sets the default value to 0 (unlimited), so this bug isn't active. However, if we decide to change from the unlimited setting in the future, this fix will address any potential issues.

btlechowski commented 1 month ago

Verified on

Brave 1.71.105 Chromium: 129.0.6668.89 (Official Build) beta (64-bit)
Revision f69ba167992437799f1dbcce81e90ba501a3d63e
OS Linux

Conversions/creative_set_conversion_cap/1

1st conversion ``` [45838:45838:1007/054439.658143:VERBOSE1:confirmations.cc(92)] Successfully processed kViewedImpression confirmation for kInlineContentAd with transaction id 9045871f-0157-4164-ad34-74b7368e69d0 and creative instance id 22110568-4125-4b84-b97a-27ef45c5c07c ``` 2nd ``` [45838:45838:1007/054532.566054:VERBOSE1:conversions.cc(137)] 1 out of 1 matching creative set conversions are sorted into 1 buckets [45838:45838:1007/054532.566068:VERBOSE1:conversions.cc(204)] There were no conversion matches ```

Conversions/creative_set_conversion_cap/2

1st conversion ``` [43415:43415:1007/052910.545129:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id 24e7f5b1-f5ef-4dfe-9fb9-48edc4e7bae9 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ``` 2nd ``` [43415:43415:1007/052945.782701:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id 98a43a19-c6c8-477f-8657-3eb10914297d and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ``` 3rd ``` [43415:43415:1007/053151.328501:VERBOSE1:conversions.cc(137)] 1 out of 1 matching creative set conversions are sorted into 1 buckets [43415:43415:1007/053151.340061:VERBOSE1:conversions.cc(204)] There were no conversion matches ```

Conversions/creative_set_conversion_cap/3

1st conversion ``` [43415:43415:1007/052910.545129:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id 24e7f5b1-f5ef-4dfe-9fb9-48edc4e7bae9 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ``` 2nd ``` [43415:43415:1007/052945.782701:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id 98a43a19-c6c8-477f-8657-3eb10914297d and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ``` 3rd ``` [44253:44253:1007/053351.654404:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id f5247588-ea51-43f1-94a3-256043cf4aa3 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ``` 4th ``` [44253:44253:1007/053525.660694:VERBOSE1:conversions.cc(137)] 1 out of 1 matching creative set conversions are sorted into 1 buckets [44253:44253:1007/053525.660857:VERBOSE1:conversions.cc(204)] There were no conversion matches ```

Conversions/creative_set_conversion_cap/0

1st conversion ``` [43415:43415:1007/052910.545129:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id 24e7f5b1-f5ef-4dfe-9fb9-48edc4e7bae9 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ``` 2nd ``` [43415:43415:1007/052945.782701:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id 98a43a19-c6c8-477f-8657-3eb10914297d and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ``` 3rd ``` [44253:44253:1007/053351.654404:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id f5247588-ea51-43f1-94a3-256043cf4aa3 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ``` 4th ``` [45033:45033:1007/053827.104117:VERBOSE1:confirmations.cc(92)] Successfully processed kConversion confirmation for kInlineContentAd with transaction id 2b170834-f42b-454d-9b01-fa6ce32d632e and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae ```