brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.57k stars 2.28k forks source link

Brave update issues on MacOS #40992

Open atuchin-m opened 1 week ago

atuchin-m commented 1 week ago

Description

From time to time browser stops works, all renderer process crash immediately . It's perfectly match the time that a new update is ready. crash-ids: 846c1800-24ac-8e0c-0000-000000000000

[ 0 ] base::apple::(anonymous namespace)::BundleFromPath(base::FilePath const&) ( immediate_crash.h:176 )
[ 1 ] base::apple::SetOverrideFrameworkBundlePath(base::FilePath const&) ( bundle_locations.mm:91 )
[ 2 ] base::apple::(anonymous namespace)::BundleFromPath(base::FilePath const&) ( bundle_locations.mm:69 )
[ 3 ] base::apple::SetOverrideFrameworkBundlePath(base::FilePath const&) ( bundle_locations.mm:91 )
[ 4 ] SetUpBundleOverrides() ( chrome_main_mac.mm:25 )
[ 5 ] ChromeMain ( chrome_main.cc:185 )
[ 6 ] main ( chrome_exe_main_mac.cc:217 )

The details show that there that the old framework and resources were removed, but the browser is still trying to use it.
ls.txt open_files_and_ports.txt

Note, that it's an old issue and it's likely isn't connected with O4 integration.

Steps to reproduce

  1. Wait for the update is ready, don't relaunch the browser.

Actual result

Blank pages on every tab, all the renderer processes crash. Browser works well after the restart.

Expected result

Browser works normally.

Reproduces how often

Intermittent issue

Brave version (brave://version info)

1.71.73 Chromium: 128.0.6613.120 (Official Build) nightly (arm64)

Channel information

Reproducibility

Miscellaneous information

No response

atuchin-m commented 1 week ago

The screencast: https://github.com/user-attachments/assets/5ca41c38-a076-46ed-8689-9cf86a90cc5d

mherrmann commented 1 week ago

@atuchin-m do you happen to have any more specific steps for reproducing? I just installed an old version of Nightly, left it running for 12 hours, then advanced the system clock by another 12 hours. I also got the green "Update" button in the top right corner. But no render process crashes. When I finally restarted, it updated to the latest version as expected.

atuchin-m commented 1 week ago

@mherrmann it happens usually one of 5-10 updates, no particular steps.