search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.55k stars 2.28k forks source link

CR129 - `On-device site data` and `V8 optimizer` content settings icon are inherited from Chrome #40993

Open GeetaSarvadnya opened 1 week ago

GeetaSarvadnya commented 1 week ago

Description

Found while testing https://github.com/brave/brave-browser/issues/40204 CR129 - On-device site data and V8 optimizer content settings icon are inherited from Chrome

Steps to reproduce

  1. Clean profile 1.71.81 cr129
  2. Open brave://settings/content
  3. On-device site data and V8 optimizer content settings icon are inherited from Chrome

Actual result

On-device site data and V8 optimizer content settings icon is inherited from Chrome image

Expected result

The icons should be same as below:

image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.71.81 Chromium: 129.0.6668.31 (Official Build) nightly (64-bit)
Revision 33ed75506c3a0d5a964e5ca61494d6144c52fd7d
OS Windows 10 Version 22H2 (Build 19045.4780)

Channel information

Reproducibility

Miscellaneous information

cc: @brave/qa-team @rebron @mkarolin @simonhong

fallaciousreasoning commented 1 week ago

@GeetaSarvadnya @simonhong I noticed upstream has actually changed nearly all the icons in the additional privacy settings. I'm going to go over them in a bit more detail

fallaciousreasoning commented 1 week ago

Okay, interestingly those two icons weren't Nala icons in the first place! Upstream is doing an overhaul of the icons in settings/privacy.

I've created https://github.com/brave/leo/issues/824 in Nala for the new icons we need, but @aguscruiz is on PTO. For what its worth, the new Chromium icons match our style a lot closer.

https://github.com/brave/brave-core/pull/25524 fixes the icons we have already :smile: I'm going to leave this one open for now, as I can't fix it yet