brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.61k stars 2.29k forks source link

VPN region changed dialog not localized [l10n] #41048

Open Uni-verse opened 2 weeks ago

Uni-verse commented 2 weeks ago

Description

VPN change region dialog is not localized. This is shown anytime the VPN automatic switch is disabled/enabled and when selecting servers from the list.

This is not the case with the protocol change dialog.

Steps to reproduce

  1. Change language to German or French (non-English)
  2. Enable VPN
  3. Open hamburger menu and select VPN Region
  4. Disable the automatic switch

Actual result

Strings not translated in dialog (German)

IMG_7313

Expected result

Should be translated

Reproduces how often

Easily reproduced

Brave version

1.69

Device/iOS version

iPhone

Affected browser versions

Reproducibility

Miscellaneous information

No response

jamesmudgett commented 2 weeks ago

Align location name and flag to the center, cc @kleantzogu, also add the server name below the location so it's more obvious which server is being used.

aguscruiz commented 1 day ago

Have a small suggestion here on how we can make it more centered, we can get rid of the box for the emoji and place it besides the country name: https://www.figma.com/design/J4LKBMftiWhqromRWfUQLG/VPN-flows?node-id=47-28575&t=eoDZ1Eu8Ob5MPKtt-1

image